November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-backup: Do not pass -s with -c
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not pass -s with -c ...................................................................... packaging: engine-backup: Do not pass -s with -c Recent versions of tar do not accept -c (--create) with -s (--same-order). Do not pass -s during create. Bug-Url: https://bugzilla.redhat.com/1282397 Change-Id: I5453cb53189c8ef5ffc66ecf30783ec649aa3536 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5453cb53189c8ef5ffc66ecf30783ec649aa3536 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: filter out some more errors during restore
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: filter out some more errors during restore ...................................................................... packaging: setup: filter out some more errors during restore Add pg 8.4 error about already existing plpgsql. Change-Id: I5b9da78c46e88a9b88039e3d24e7bf4cdb47fdac Bug-Url: https://bugzilla.redhat.com/1244720 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/44879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b9da78c46e88a9b88039e3d24e7bf4cdb47fdac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: Stop gluster processes when host moves to maintenance
by sabose＠redhat.com 16 Nov '15

16 Nov '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Stop gluster processes when host moves to maintenance ...................................................................... gluster: Stop gluster processes when host moves to maintenance Stop glusterd and other gluster processes when a host is moved to maintenance mode, so that data is un-available. Start the glusterd service when host is activated again. starting glusterd service will ensure that all the other gluster services are started. Change-Id: Ib4e00fb30b9d0cc84dcaffe9c89864429470f0aa Bug-Url: https://bugzilla.redhat.com/1205724 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterProcessesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 8 files changed, 76 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e00fb30b9d0cc84dcaffe9c89864429470f0aa Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: hwbi <hwbi2008(a)gmail.com>

1 0

Change in ovirt-engine[master]: webadmin: 'passthrough' vnic should be automatically 'pci-pa...
by alkaplan＠redhat.com 16 Nov '15

16 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: 'passthrough' vnic should be automatically 'pci-passthrough' type ...................................................................... webadmin: 'passthrough' vnic should be automatically 'pci-passthrough' type Bug-Url: https://bugzilla.redhat.com/1269405 Bug-Url: https://bugzilla.redhat.com/1271912 Change-Id: I38f5b631ddd6f6bb86914f0cbfb3e849178a0886 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseInterfaceCreatingManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 2 files changed, 44 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f5b631ddd6f6bb86914f0cbfb3e849178a0886 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dal: Add get BaseDisk list by alias
by rgolan＠redhat.com 16 Nov '15

16 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: dal: Add get BaseDisk list by alias ...................................................................... dal: Add get BaseDisk list by alias Adding a procedure to retrive base disks by alias name. Its mainly required to get the hosted engine direct lun disk quickly for removal. Change-Id: I41e5762c9cf55c4bfb683b11c066877e9e5f6366 Bug-Url: https://bugzilla.redhat.com/1273378 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M packaging/dbscripts/base_disks_sp.sql A packaging/dbscripts/upgrade/04_00_0000_index_base_disks.sql 5 files changed, 34 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41e5762c9cf55c4bfb683b11c066877e9e5f6366 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Log tar creation failures
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Log tar creation failures ...................................................................... packaging: engine-backup: Log tar creation failures Change-Id: I39df58b46fff2e34b04a3d6255bc265006c94031 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39df58b46fff2e34b04a3d6255bc265006c94031 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Fix failure notifications
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix failure notifications ...................................................................... packaging: engine-backup: Fix failure notifications Always check and set FAILURE_NOTIFIED before trying to notify. Without this patch, in certain conditions, we could enter an endless loop while trying to notify the engine about a failure. Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5 Bug-Url: https://bugzilla.redhat.com/1240923 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Do not log cmdline parsing errors
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not log cmdline parsing errors ...................................................................... packaging: engine-backup: Do not log cmdline parsing errors That's especially important for the error about missing log file. Others are also not important to log - we want to log actual failures caught during backup. Bug-Url: https://bugzilla.redhat.com/1240923 Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Block Hotplug/unplug 'pci-passthrough' vNIC types
by alkaplan＠redhat.com 16 Nov '15

16 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Block Hotplug/unplug 'pci-passthrough' vNIC types ...................................................................... engine: Block Hotplug/unplug 'pci-passthrough' vNIC types Bug-Url: https://bugzilla.redhat.com/1273486 Change-Id: Ic7b32ad027016c0d95dd05ab0abbd176951c4be9 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 65 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7b32ad027016c0d95dd05ab0abbd176951c4be9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: correct size unit on export image view
by tnisan＠redhat.com 16 Nov '15

16 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: correct size unit on export image view ...................................................................... webadmin: correct size unit on export image view Disks -> Export Dialog: 'Actual Size' values should be converted using SizeUnit.GiB. Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14 Bug-Url: https://bugzilla.redhat.com/1281288 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/48589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0