Change in ovirt-engine[master]: core: hosted-engine: Fix wrong check of compat version
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: hosted-engine: Fix wrong check of compat version
......................................................................
core: hosted-engine: Fix wrong check of compat version
The version check of the cluster and storage domain was wrong. The check
now is to check that Storage pool is greatr or equals 3.5 and cluster is
greater or equals 3.6.
Change-Id: I0b57c29d4bb2e51c4446eb2a2b52f2d2b28a33bc
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Roy Golan: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b57c29d4bb2e51c4446eb2a2b52f2d2b28a33bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: engine: CommitNetworkChanges only in case that it's known as...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: CommitNetworkChanges only in case that it's known as dirty
......................................................................
engine: CommitNetworkChanges only in case that it's known as dirty
netConfigDirty is a 3-state Boolean. The patch negates the previous
behavior regarding NULL value. Now the config isn't being committed
in case of NULL.
That is to prevent cases that an unknown config is committed.
Change-Id: Ie592306052a315d6ecf6aa4470e2144e631d4c41
Bug-Url: https://bugzilla.redhat.com/1271273
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/50207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie592306052a315d6ecf6aa4470e2144e631d4c41
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine-cli[master]: cli: 'BaseDevices' was removed from Python SDK but not from CLI
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: 'BaseDevices' was removed from Python SDK but not from CLI
......................................................................
cli: 'BaseDevices' was removed from Python SDK but not from CLI
This problem caused:
[oVirt shell (connected)]# action vm test_25 start
===================== UNKNOWN ERROR ==========================
'module' object has no attribute 'BaseDevices'
==============================================================
Solution suggested by Juan Hernandez.
Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e5
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M src/ovirtcli/utils/typehelper.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, approved; Passed CI tests
Petr Horáček: Verified
--
To view, visit https://gerrit.ovirt.org/50246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4333aef51c45d1faef827399d42c5aa4744023e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: engine: CommitNetworkChanges only in case that it's known as...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: CommitNetworkChanges only in case that it's known as dirty
......................................................................
engine: CommitNetworkChanges only in case that it's known as dirty
netConfigDirty is a 3-state Boolean. The patch negates the previous
behavior regarding NULL value. Now the config isn't being committed
in case of NULL.
That is to prevent cases that an unknown config is committed.
Change-Id: Ie592306052a315d6ecf6aa4470e2144e631d4c41
Bug-Url: https://bugzilla.redhat.com/1271273
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved; Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/50205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie592306052a315d6ecf6aa4470e2144e631d4c41
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: fix ExecutionHandler params in javadoc
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: fix ExecutionHandler params in javadoc
......................................................................
core: fix ExecutionHandler params in javadoc
Change-Id: Ic6717aa97685b231250d1c137c55b17d6b2b6fb5
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6717aa97685b231250d1c137c55b17d6b2b6fb5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Remove unnecessary overridden methods from gluster cla...
by mperina@redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Remove unnecessary overridden methods from gluster classes
......................................................................
core: Remove unnecessary overridden methods from gluster classes
Removes unnecessary overridden methods which didn't add any logic and
just called super method.
Change-Id: I8dd57388cae002b384e37ed21c8afb53246e2895
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java
5 files changed, 0 insertions(+), 36 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dd57388cae002b384e37ed21c8afb53246e2895
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Adding convenience methods to Version.java
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Adding convenience methods to Version.java
......................................................................
core: Adding convenience methods to Version.java
Version.compare(version) might be comfusing so adding 4 convenience
methods:
greater(version)
less(version)
greaterOrEquals(version)
lessOrEquals(version)
Change-Id: I04a3b17859776f896b41503f5edd83c6f003cb40
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/VersionTest.java
2 files changed, 60 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/50231
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04a3b17859776f896b41503f5edd83c6f003cb40
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: fix log messages in import-vm
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix log messages in import-vm
......................................................................
core: fix log messages in import-vm
Change-Id: I1d864f9a684c22337b2ae6195612121b3e37d58f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/50222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d864f9a684c22337b2ae6195612121b3e37d58f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: Apply java8 stream API to FenceAgentExecutor
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Apply java8 stream API to FenceAgentExecutor
......................................................................
core: Apply java8 stream API to FenceAgentExecutor
Change-Id: Ifa3a43710dfccf88ea3677c48795eb54544bef30
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java
1 file changed, 11 insertions(+), 17 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49604
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa3a43710dfccf88ea3677c48795eb54544bef30
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: use java8 stream API in FenceProxyLocator
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: use java8 stream API in FenceProxyLocator
......................................................................
core: use java8 stream API in FenceProxyLocator
Replace code in FenceProxyLocator to use Stream API
Change-Id: I3c5f1bcb5bc50a5d06615c592c08d7999db702ca
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java
1 file changed, 13 insertions(+), 22 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49603
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c5f1bcb5bc50a5d06615c592c08d7999db702ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years