Change in ovirt-engine[ovirt-engine-3.5]: engine: forbid single (vm mem) > (host mem)
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: forbid single (vm mem) > (host mem)
......................................................................
engine: forbid single (vm mem) > (host mem)
Forbid running single vm with mem > host physical memory.
Yet we allow running few vms with total mem > host physical memory. (relying on balloning).
This might be unwise yet can occour after migration or/and host downsizing.
Whenever the: (vm mem) > (host mem) the host will start swaping and performance degrage.
If it possible to think of scenrios vm allocated large mem and not using it, and cannot downsize vm mem.
Fix swap and refactor reused messages.
If fail run vm due to insufficent mem. Report the available mem.
Added unit test to SlaValidatorTest
Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98
Bug-Url: https://bugzilla.redhat.com/1197474
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SlaValidatorTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 107 insertions(+), 19 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5f5280c43820732a36a235024ec5c887c9fcb98
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: support OpenStack Volume in provider dialog
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: support OpenStack Volume in provider dialog
......................................................................
webadmin: support OpenStack Volume in provider dialog
Adding support for OpenStack Volume (Cinder) in
add/edit provider dialog:
* Adding appropriate default url for OPENSTACK_VOLUME
* Add data-center editor and set items accordingly.
* Pass the selected data-center ID on save.
Change-Id: Ic30b43378f9968e837611943891cef2bc7ef2104
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml
5 files changed, 106 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic30b43378f9968e837611943891cef2bc7ef2104
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: AsyncDataProvider - getStorageDomainByName
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: AsyncDataProvider - getStorageDomainByName
......................................................................
webadmin: AsyncDataProvider - getStorageDomainByName
Adding getStorageDomainByName method to AsyncDataProvider
in order to get the storage domain associated to
a provider.
Change-Id: Icfe16e440fd9413d6e09e886bb66af35ded5a388
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38933
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfe16e440fd9413d6e09e886bb66af35ded5a388
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: SystemTreeItemCell - OPENSTACK_VOLUME
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: SystemTreeItemCell - OPENSTACK_VOLUME
......................................................................
webadmin: SystemTreeItemCell - OPENSTACK_VOLUME
SystemTreeItemCell - add OPENSTACK_VOLUME to provider branch
to ensure openstack icon on system tree.
Change-Id: Icdfd4f4ecda451ddac5891150b061c654aee186f
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTreeItemCell.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdfd4f4ecda451ddac5891150b061c654aee186f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: add ProviderType OPENSTACK_VOLUME to enums
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: add ProviderType OPENSTACK_VOLUME to enums
......................................................................
webadmin: add ProviderType OPENSTACK_VOLUME to enums
enums.java/properties: adding ProviderType OPENSTACK_VOLUME
Change-Id: I5689a668c64b284c8fd99c7af4359b49275cc9be
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5689a668c64b284c8fd99c7af4359b49275cc9be
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: common.gwt.xml - OpenStackVolumeProviderProperties
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: common.gwt.xml - OpenStackVolumeProviderProperties
......................................................................
webadmin: common.gwt.xml - OpenStackVolumeProviderProperties
Adding OpenStackVolumeProviderProperties to Common.gwt.xml
for UI usage.
Change-Id: I131315a986fe9a790642ec5277ba5945befa1a99
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I131315a986fe9a790642ec5277ba5945befa1a99
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: add StorageType CINDER to enums
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: add StorageType CINDER to enums
......................................................................
webadmin: add StorageType CINDER to enums
enums.java/properties: adding StorageType CINDER
Change-Id: Iea4ac7e78d2487192bb3de88abdbbc9983daf6bd
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea4ac7e78d2487192bb3de88abdbbc9983daf6bd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: webadmin: add StorageDomainType Volume to enums
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: add StorageDomainType Volume to enums
......................................................................
webadmin: add StorageDomainType Volume to enums
enums.java/properties: adding StorageDomainType Volume
Change-Id: Ie8241712e26232bb14c746dd0d53decb22259af1
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8241712e26232bb14c746dd0d53decb22259af1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: frontend: handle ExecuteFailedMessages on runAction
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: frontend: handle ExecuteFailedMessages on runAction
......................................................................
frontend: handle ExecuteFailedMessages on runAction
Frontend -> handleActionResult:
Invoking 'translateExecuteFailedMessages' when 'executeFailedMessages'
are available (i.e. translate error messages upon runAction failure).
Change-Id: I82fb7f297e92d0848c0b25c43c17fc904f1c06b5
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase_CustomFieldSerializer.java
3 files changed, 14 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38941
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82fb7f297e92d0848c0b25c43c17fc904f1c06b5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: catch OpenStackResponseException on execute
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: catch OpenStackResponseException on execute
......................................................................
core: catch OpenStackResponseException on execute
CommandBase -> executeWithoutTransaction:
catch OpenStackResponseException to handle only when necessary
(i.e. when no failure messages have been added).
Change-Id: Ic84ee67e0cb83763d26bba82dd03131d5b97a38d
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic84ee67e0cb83763d26bba82dd03131d5b97a38d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months