March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: aaa: Remove userId parameter from LogoutUserCommand
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Remove userId parameter from LogoutUserCommand ...................................................................... aaa: Remove userId parameter from LogoutUserCommand Removes userId parameter from LogoutUserCommand, because it's redundant as we use supplied sessionId to remove session of the logged-in user. Change-Id: Ia33c7dfd908c68ac06b717c0452e3de4564f35a7 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutUserCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LogoutUserParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 7 files changed, 9 insertions(+), 44 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ori Liel: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia33c7dfd908c68ac06b717c0452e3de4564f35a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: adding missing action group
by tnisan＠redhat.com 10 Mar '15

10 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: core: adding missing action group ...................................................................... core: adding missing action group Adding missing DISK_LIVE_STORAGE_MIGRATION key to LocalizedEnums Change-Id: I4be8a3e779bab3da00d9954488c0fedb48c8a50e Bug-Url: https://bugzilla.redhat.com/1199812 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/38456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4be8a3e779bab3da00d9954488c0fedb48c8a50e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: build: fix recent pep8 warnings
by sbonazzo＠redhat.com 10 Mar '15

10 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: fix recent pep8 warnings ...................................................................... build: fix recent pep8 warnings Fixed errors detected with pep8 1.6.2 E731 do not assign a lambda expression, use a def Sorted all import blocks. Change-Id: If8270af2d6d9f7392361918332afb31b60e2eefd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/check_liveliness.py M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/domains.py M src/ovirt_hosted_engine_setup/mixins.py M src/ovirt_hosted_engine_setup/set_maintenance.py M src/ovirt_hosted_engine_setup/tasks.py M src/ovirt_hosted_engine_setup/vm_status.py M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py M src/plugins/ovirt-hosted-engine-setup/core/conf.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/core/offlinepackager.py M src/plugins/ovirt-hosted-engine-setup/core/preview.py M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/core/shell.py M src/plugins/ovirt-hosted-engine-setup/core/titles.py M src/plugins/ovirt-hosted-engine-setup/engine/add_disk.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_services.py M src/plugins/ovirt-hosted-engine-setup/libvirt/configureqemu.py M src/plugins/ovirt-hosted-engine-setup/libvirt/workarounds.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py M src/plugins/ovirt-hosted-engine-setup/network/firewall.py M src/plugins/ovirt-hosted-engine-setup/network/firewall_manager.py M src/plugins/ovirt-hosted-engine-setup/network/gateway.py M src/plugins/ovirt-hosted-engine-setup/network/iptables.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py M src/plugins/ovirt-hosted-engine-setup/storage/nfs.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/system/sshd.py M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/vdsmconf.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py M src/plugins/ovirt-hosted-engine-setup/vm/cpu.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py M src/plugins/ovirt-hosted-engine-setup/vm/mac.py M src/plugins/ovirt-hosted-engine-setup/vm/machine.py M src/plugins/ovirt-hosted-engine-setup/vm/memory.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 47 files changed, 231 insertions(+), 166 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8270af2d6d9f7392361918332afb31b60e2eefd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: long method refactor
by masayag＠redhat.com 10 Mar '15

10 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: core: long method refactor ...................................................................... core: long method refactor extracted duplicates into methods. this code is more readable with each pair on one line. Can be better if refactored into class, if one doing CR is ok with that, I can do it. Comment: isn't it an error, ending with coma? Change-Id: I832bc8c7e8bdfb2948f2137922e738fc6e702e59 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 31 insertions(+), 30 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/29588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I832bc8c7e8bdfb2948f2137922e738fc6e702e59 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removed pointless caching.
by masayag＠redhat.com 10 Mar '15

10 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: core: removed pointless caching. ...................................................................... core: removed pointless caching. ResourceBundle is already cached. See java.util.ResourceBundle#clearCache() Each HashMap caching is wrong and should not exist in code. Change-Id: I7eb5e71aafb8d8fde253d8713fe6cb7f870d3093 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 20 insertions(+), 32 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/29586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7eb5e71aafb8d8fde253d8713fe6cb7f870d3093 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AuditLogType.UNASSIGNED should not be logged
by masayag＠redhat.com 10 Mar '15

10 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: core: AuditLogType.UNASSIGNED should not be logged ...................................................................... core: AuditLogType.UNASSIGNED should not be logged instead of depending on missing translation & failing AuditLog instance creation, express that using one simple method. Change-Id: I97bf90264d1a1b3d8ea571daa9346d1f6b6d18d1 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/33359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97bf90264d1a1b3d8ea571daa9346d1f6b6d18d1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added missing logging + refactoring
by masayag＠redhat.com 10 Mar '15

10 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: core: added missing logging + refactoring ...................................................................... core: added missing logging + refactoring org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector#saveToDb was missing logging in situation, when 'bundles/AuditLogMessages' resource bundle does not contain specific translation. In that case AuditLog was silently not created and nothing was logged. - added missing logging - overgrown method saveToDb split into few smaller ones. - removed coding smell when dealing with variables 'message' and 'resolvedMessage' - simplified test for empty string. Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 82 insertions(+), 89 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/29244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: vdc query to list storage devices
by masayag＠redhat.com 09 Mar '15

09 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: gluster: vdc query to list storage devices ...................................................................... gluster: vdc query to list storage devices Add VdcQuery to list all the storage devices in the given host. Change-Id: Ie1bb0481bd2b34654c28c5990441d1f6f5302ec2 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 66 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/35314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1bb0481bd2b34654c28c5990441d1f6f5302ec2 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: New VM dialog - advanced options
by tjelinek＠redhat.com 09 Mar '15

09 Mar '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: New VM dialog - advanced options ...................................................................... webadmin: New VM dialog - advanced options When you open the new/edit any VM based dialog, and click "show advanced options" and close the dialog, this setting will be persisted and on next open of the same dialog, you don't need to click it. Restoring this feature after refactoring. Change-Id: I61677816c304c0506d10ec1e297a5d42fcd831e6 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Fred Rolland: Verified -- To view, visit https://gerrit.ovirt.org/38488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61677816c304c0506d10ec1e297a5d42fcd831e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: fix patch files for jasper upgrade 6.0.1
by sradco＠redhat.com 09 Mar '15

09 Mar '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: fix patch files for jasper upgrade 6.0.1 ...................................................................... packaging: fix patch files for jasper upgrade 6.0.1 Signed-off-by: Shirly Radco <sradco(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/1179117 Change-Id: I0b9a59db119d6243ced10ecd96b28eff78a6bf23 --- M ovirt-engine-reports.spec.in M packaging/jasper-customizations/WEB-INF/applicationContext-ovirt-override.xml.in D packaging/jasper-war-patches/ce/100_003_meta-inf_remove_dependecy_to_missing_jars.patch M packaging/jasper-war-patches/ce/300_002_jsp_fix-sso-resend-issue.patch M packaging/jasper-war-patches/ce/900_003_props_enable-full-text-in-supported-formats.patch M packaging/jasper-war-patches/common/100_002_meta-inf_remove_pgsql_jar_from_exclude.patch A packaging/jasper-war-patches/common/200_008_web-inf_add_EngineSimplePreAuthFilter.patch A packaging/jasper-war-patches/common/200_009_web-inf-application_context_override.patch M packaging/jasper-war-patches/common/300_003_jsp_rebrand-tab-headers.patch 9 files changed, 67 insertions(+), 71 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9a59db119d6243ced10ecd96b28eff78a6bf23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0