Change in ovirt-engine[master]: engine: Use typed empty list VmStatisticsDAOTest
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use typed empty list VmStatisticsDAOTest
......................................................................
engine: Use typed empty list VmStatisticsDAOTest
Change-Id: Iaba667b1095e6aacd957cb56167857d9423f047d
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDAOTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/40932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaba667b1095e6aacd957cb56167857d9423f047d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Use typed empty list in extensions
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use typed empty list in extensions
......................................................................
engine: Use typed empty list in extensions
Change-Id: I481e29be6155bbcf5c53213dca172613e4c6dfe9
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GroupSearchResult.java
2 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/40931
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I481e29be6155bbcf5c53213dca172613e4c6dfe9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: gluster: Use typed empty list
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: gluster: Use typed empty list
......................................................................
gluster: Use typed empty list
Change-Id: I48f835e1198a1702c00c2d4a0f4e0d6fd5a096e4
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java
3 files changed, 5 insertions(+), 8 deletions(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/40930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48f835e1198a1702c00c2d4a0f4e0d6fd5a096e4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: Use typed empty list
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Use typed empty list
......................................................................
webadmin: Use typed empty list
Change-Id: I4454b918483d562738c57e5884396fddc8cad4b3
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4454b918483d562738c57e5884396fddc8cad4b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Use typed empty list in BackwardCompatibilityTaskCre...
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use typed empty list in BackwardCompatibilityTaskCreationTest
......................................................................
engine: Use typed empty list in BackwardCompatibilityTaskCreationTest
Change-Id: I6b2712e02c107d9c280aed45675edc75f8a773a2
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b2712e02c107d9c280aed45675edc75f8a773a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Use typed empty list in UpdateVmCommand
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Use typed empty list in UpdateVmCommand
......................................................................
engine: Use typed empty list in UpdateVmCommand
Change-Id: I6db6278f3be3e70d86c7d099145e94a15ed825f6
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6db6278f3be3e70d86c7d099145e94a15ed825f6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Simplify HostValidator hierarchy and cover with tests
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Simplify HostValidator hierarchy and cover with tests
......................................................................
engine: Simplify HostValidator hierarchy and cover with tests
There isn't a good reason for UpgradeHostValidator to extend
HostValidator. It also deserves its testing.
Change-Id: I2f7e396e6523010d1deda9213de70beeaa38c074
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidatorTest.java
5 files changed, 138 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f7e396e6523010d1deda9213de70beeaa38c074
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: consolidate register disk commands and queries
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: consolidate register disk commands and queries
......................................................................
core: consolidate register disk commands and queries
In order to support register Cinder disks in the rest-api,
added the relevant logic to GetUnregisteredDisk(s)Query
and RegisterDiskCommand.
Change-Id: Icc3558c635adb174af4fe89c63185268344d06aa
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredCinderDisksByStorageDomainIdQuery.java
4 files changed, 56 insertions(+), 15 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc3558c635adb174af4fe89c63185268344d06aa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine-sdk[master]: automation: add automation scripts
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: automation: add automation scripts
......................................................................
automation: add automation scripts
Added automation scripts as per
http://www.ovirt.org/CI/Build_and_test_standards
Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A automation/README.md
A automation/build-artifacts.req
A automation/build-artifacts.sh
A automation/check-merged.req
A automation/check-merged.sh
A automation/check-patch.req
A automation/check-patch.sh
7 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for review
Juan Hernandez: Ready for merge
Jenkins CI: Looks good to me; Passed CI tests
David Caro: Verified
--
To view, visit https://gerrit.ovirt.org/39714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in mom[master]: Update mom version to 0.4.4
by alitke@redhat.com
Adam Litke has submitted this change and it was merged.
Change subject: Update mom version to 0.4.4
......................................................................
Update mom version to 0.4.4
Change-Id: I03f6701704d26fc7707014a3c81237a4b7dbd5b5
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40962
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40962
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03f6701704d26fc7707014a3c81237a4b7dbd5b5
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months