May 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: jobs: add ovirt-engine-sdk jobs
by dcaroest＠redhat.com 15 May '15

15 May '15

David Caro has submitted this change and it was merged. Change subject: jobs: add ovirt-engine-sdk jobs ...................................................................... jobs: add ovirt-engine-sdk jobs Change-Id: I5cb5a2347177fe51e43a644a8f2a53d13055b65e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml A jobs/confs/yaml/scms/ovirt-engine-sdk.yaml 2 files changed, 54 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me; Ready for merge; Passed CI tests -- To view, visit https://gerrit.ovirt.org/39751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cb5a2347177fe51e43a644a8f2a53d13055b65e Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in jenkins[master]: Allowing empty .req files on standard build
by dcaroest＠redhat.com 15 May '15

15 May '15

David Caro has submitted this change and it was merged. Change subject: Allowing empty .req files on standard build ...................................................................... Allowing empty .req files on standard build Change-Id: I63651e622c722262e890e4c5b690a06cf62b161e Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/standard_build_artifacts.sh M jobs/confs/shell-scripts/standard_check_merged.sh M jobs/confs/shell-scripts/standard_check_patch.sh 3 files changed, 24 insertions(+), 12 deletions(-) Approvals: David Caro: Verified; Looks good to me; Ready for merge; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63651e622c722262e890e4c5b690a06cf62b161e Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in jenkins[master]: ovirt-engine-wildfly-overlay: new job
by dcaroest＠redhat.com 15 May '15

15 May '15

David Caro has submitted this change and it was merged. Change subject: ovirt-engine-wildfly-overlay: new job ...................................................................... ovirt-engine-wildfly-overlay: new job create rpms on push and merge. Change-Id: Ide75df786e65f6b0b41485c2a3f8608ffa92c6bb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/yaml/jobs/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for review Martin Peřina: Looks good to me Jenkins CI: Looks good to me; Passed CI tests David Caro: Ready for merge -- To view, visit https://gerrit.ovirt.org/40956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide75df786e65f6b0b41485c2a3f8608ffa92c6bb Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Handle snapshot create multi-tab validation error
by sabose＠redhat.com 15 May '15

15 May '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin : Handle snapshot create multi-tab validation error ...................................................................... webadmin : Handle snapshot create multi-tab validation error Snapshot create popup has 2 tabs : 1. General 2. Schedule Some Editors in both tabs have validations for each input elements in the tabs.However, although the validations validate as expected, the problem was as under: When user in some tab and a validation fails in an input element of the other tab, although tab complained of error, it used to go unnoticed as the tab reporting the error is not the one that is active. This patch, activates the tab that has the errors in the following order: 1. If the general tab has any validation failures, it opens up the general tab. 2. If the schedule tab has any failures, it opens up the schedule tab. In accordance with above 2 steps, if both the tabs have validation failures, immaterial of the number of failures in each tab or any other criteria, general tab opens up(Does nothing if its already open). Along with the above this patch also does the following: 1. Refactored EntityModelDateTimeBox and GwtDateTimeBox in accordance with most other widgets. 2. Corrected implementations of handling widget inValidity states. Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1215887 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1218606 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelCheckBoxGroupEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelDaysOfMonthSelectorEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeSnapshotCreatePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml 7 files changed, 183 insertions(+), 34 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Update host general layout.
by awels＠redhat.com 15 May '15

15 May '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Update host general layout. ...................................................................... webadmin: Update host general layout. - Update the new/edit host general panel layout to use patternfly grids for the layout instead of the hodge podge div/tables that were there before. - Converted the controls to be patternfly as well. - Update the ListModelTypeAheadListBox to be patternfly aware. Change-Id: I132100fa06802901c16ab1dead1432c94d5dc347 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124878 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 7 files changed, 236 insertions(+), 143 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/40886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I132100fa06802901c16ab1dead1432c94d5dc347 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: add additional features support in cluster popup.
by sabose＠redhat.com 15 May '15

15 May '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: add additional features support in cluster popup. ...................................................................... webadmin: add additional features support in cluster popup. Add support for addtional features in the cluster pop up. User can enable/disable some extra feature during cluster creation. Addtional features will be shown based on the cluster compatability version shown and services (gluster, virt) enabled. Change-Id: Ic13dda67f3e9a7d7134030c3923470291c3c5aec Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 6 files changed, 195 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic13dda67f3e9a7d7134030c3923470291c3c5aec Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix NPE and visibility issues in CheckBoxGroup
by sabose＠redhat.com 15 May '15

15 May '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: fix NPE and visibility issues in CheckBoxGroup ...................................................................... webadmin: fix NPE and visibility issues in CheckBoxGroup Fixing the NPE issue in setValue() and items clearning issue setAcceptableValues() of CheckBoxGroup Change-Id: Ia4f1d371d6c6cbecad9642641d762e954016105d Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/CheckBoxGroup.java 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/40798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f1d371d6c6cbecad9642641d762e954016105d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: add feature comptability check for VDS
by sabose＠redhat.com 15 May '15

15 May '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: add feature comptability check for VDS ...................................................................... engine: add feature comptability check for VDS Some times checking for the cluster compatibility version is not enough to support some features across multiple comptability versions. So we need to have some machanism while adding a node to cluster to check that vdsm supports all the required features required for the cluster. This patch adds feature compatability check for VDS. List of all additional features will be maintained in a master table. List of features will be shown in the new/edit cluster dialog based on the compatability version selected as well as the services gluster/virt enabled. User can select the features he wants in the cluster and cluster will be initialized with that set of feature during cluster creation. When a node is added to the cluster, it checks that all the required features for the cluster are supported by vdsm. This is done in a generic way so that it can used in different features in future. Currently it is used to check whether the vdsm supports gluster37 features. gluster37 features are supported in 3.6 cluster by default. It is also supported in 3.5 cluster with this feature check. Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByClusterIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByVersionAndCategoryQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AdditionalFeature.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SupportedAdditionalClusterFeature.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterFeaturesByVersionAndCategoryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDaoImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterFeatureDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/cluster_features_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1390_add_cluster_features_table.sql 38 files changed, 1,296 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Corrected gluster volume snapshot creation logic
by kmayilsa＠redhat.com 15 May '15

15 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected gluster volume snapshot creation logic ...................................................................... gluster: Corrected gluster volume snapshot creation logic Corrected the gluster volume snapshot creation logic to fail with proper error if the snapshot creation failed at gluster side. Change-Id: I3067fd548170ae50017ce5332a24898fdc3a3da6 Bug-Url: https://bugzilla.redhat.com/1212936 Bug-Url: https://bugzilla.redhat.com/1216315 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 5 insertions(+), 6 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3067fd548170ae50017ce5332a24898fdc3a3da6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Corrected volume snapshot scheduling issues
by kmayilsa＠redhat.com 15 May '15

15 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Corrected volume snapshot scheduling issues ...................................................................... gluster: Corrected volume snapshot scheduling issues Corrected the below issues with gluster volume snapshot scheduling screen - 1. If an error during scheduling, after closing the error dialog the screen used to wait. Corrected the same. 2. Removed un-necessary check for start at field 3. Timezone listing is made more meaningful withi GMT difference 4. GMT is default selected in time zones list now Change-Id: I2e5708a3b225dbc4731e99805cff401562906971 Bug-Url: https://bugzilla.redhat.com/1219151 Bug-Url: https://bugzilla.redhat.com/1218874 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java 4 files changed, 38 insertions(+), 26 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e5708a3b225dbc4731e99805cff401562906971 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0