May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: raising if no LUN is available
by sbonazzo＠redhat.com 14 May '15

14 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: raising if no LUN is available ...................................................................... packaging: setup: raising if no LUN is available Raising if no LUN is available on the selected target to nicely abort. Change-Id: I12c6c8f8dffa1bdf395269ac0d7b7a7f0ce91503 Bug-Url: https://bugzilla.redhat.com/1220137 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c6c8f8dffa1bdf395269ac0d7b7a7f0ce91503 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Use concrete proc for updating host updates
by masayag＠redhat.com 14 May '15

14 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use concrete proc for updating host updates ...................................................................... engine: Use concrete proc for updating host updates The specific stored procedure will update the minimal columns in vds_dynamic when updates were detected for the host. Change-Id: Id5f8f0fabbe38664bb7cd2f44293e80e5fde0833 Bug-Url: https://bugzilla.redhat.com/1157368 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5f8f0fabbe38664bb7cd2f44293e80e5fde0833 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Allow creation of new disks as copy of any existing...
by tjelinek＠redhat.com 14 May '15

14 May '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Allow creation of new disks as copy of any existing disk ...................................................................... restapi: Allow creation of new disks as copy of any existing disk This patch allows to copy a VM, Template or floating Disk to a different or same storage domain. A new optional argument has been added: "name". If the name is set, the copied disk's alias will be set to the given value. If not, the alias of the copied disk will be used. Example: POST to .../api/disks/<disk id>/copy <action> <storage_domain id="14e6e9f3-9fe9-493b-b9ba-793cb441f9ad" /> <disk><alias>newDiskAlias</alias></disk> </action> Bug-Url: https://bugzilla.redhat.com/1132066 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> Change-Id: I8931d2464d6ad17a80d9b394f16d01a2c47d7575 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8931d2464d6ad17a80d9b394f16d01a2c47d7575 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add proc for updating a host available updates
by masayag＠redhat.com 14 May '15

14 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add proc for updating a host available updates ...................................................................... engine: Add proc for updating a host available updates The stored procedure performs the exact minimal changes required for updating the availability of updates for the given host. Change-Id: Ie76af614aea740f6ccd5a1ce5d611be67f8827d1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M packaging/dbscripts/vds_sp.sql 4 files changed, 43 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76af614aea740f6ccd5a1ce5d611be67f8827d1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Enable 'Upgrade' action for all host types
by masayag＠redhat.com 14 May '15

14 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Enable 'Upgrade' action for all host types ...................................................................... webadmin: Enable 'Upgrade' action for all host types With the UpgradeHost action, also non ovirt-node hosts can be upgraded. The patch adds the required functionality for it and adjusts the behavior of ovirt-node upgrade flow to use the new command. Change-Id: Ic064f6e8bdefe47fc0a16df2660afcb53782bbec Bug-Url: https://bugzilla.redhat.com/1157368 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/RpmVersionUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralInfoView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/alert/InLineAlertWidget.java 12 files changed, 286 insertions(+), 169 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/40706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic064f6e8bdefe47fc0a16df2660afcb53782bbec Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Allow GWT to work with Hibernate
by masayag＠redhat.com 14 May '15

14 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Allow GWT to work with Hibernate ...................................................................... webadmin: Allow GWT to work with Hibernate Hibernate collections serialization is not supported by GWT. This patch provides serialization techniques to some commonly user Hibernate collections, so that objects can be serialized to the browser. Change-Id: I54f2b14a54d3e90c3e27746b024e2260131bc13d Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/hibernate/collection/internal/PersistentBag.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liran Zelkha: Verified -- To view, visit https://gerrit.ovirt.org/40804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54f2b14a54d3e90c3e27746b024e2260131bc13d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: vdsbroker: async vdscommand
by oourfali＠redhat.com 14 May '15

14 May '15

Oved Ourfali has submitted this change and it was merged. Change subject: vdsbroker: async vdscommand ...................................................................... vdsbroker: async vdscommand Now we are able to run vdscommands without waiting on result from vdsm. The command when set to be asynchronous returns VDSAsyncReturnValue which provide isRequestCompleted method to check whether the result arrived or not. Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AsyncCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSAsyncReturnValue.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 5 files changed, 93 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : Add json rpc request completed method
by oourfali＠redhat.com 14 May '15

14 May '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Add json rpc request completed method ...................................................................... engine : Add json rpc request completed method Add method in FutureMap to determine if the request has completed. This can be used to determine if the get method should be invoked. Change-Id: I6e0ef961927c3fb17656ecac12d245c25b2ee367 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java 2 files changed, 22 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0ef961927c3fb17656ecac12d245c25b2ee367 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: monitor: implement NUMA aware KSM policy
by alitke＠redhat.com 13 May '15

13 May '15

Adam Litke has submitted this change and it was merged. Change subject: monitor: implement NUMA aware KSM policy ...................................................................... monitor: implement NUMA aware KSM policy Add parameter to HostKSM.py collector to collect merge_across_nodes Add parameter to KSM.py controller to udpate merge_across_nodes kernel flag Used Entity.py to debug by monitoring the state of variables change Change-Id: I26caf0abe0a33a82b242549ba2ba4ad7f01ec925 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=840114 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/40130 Reviewed-by: Jenkins CI Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/HostKSM.py M mom/Controllers/KSM.py 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, approved Dudi Maroshi: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26caf0abe0a33a82b242549ba2ba4ad7f01ec925 Gerrit-PatchSet: 8 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: Generalize the action type is messages
by masayag＠redhat.com 13 May '15

13 May '15

Moti Asayag has submitted this change and it was merged. Change subject: host-deploy: Generalize the action type is messages ...................................................................... host-deploy: Generalize the action type is messages In order to reuse the same can-do-action message from different commands, the hard-coded action type should be replaced with a parameter. Change-Id: Id1bd86f61b8727f8a4271ed29c73005cc26b7f4c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 15 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1bd86f61b8727f8a4271ed29c73005cc26b7f4c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0