May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5.3_rc
by sradco＠redhat.com 13 May '15

13 May '15

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5.3_rc ...................................................................... build: post ovirt-engine-dwh-3.5.3_rc Change-Id: Ia571e35a96418c9077c6a0d2efa0be55c07fb239 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia571e35a96418c9077c6a0d2efa0be55c07fb239 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Fix broken test
by kmayilsa＠redhat.com 13 May '15

13 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Fix broken test ...................................................................... engine: Fix broken test Change-Id: Ib95e770efd1416a16e4a3179700e47dd8b590417 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommandTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib95e770efd1416a16e4a3179700e47dd8b590417 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: List only the cluster with nodes attached
by kmayilsa＠redhat.com 13 May '15

13 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: List only the cluster with nodes attached ...................................................................... webadmin: List only the cluster with nodes attached Modified to list only the clusters which have nodes attached during cluster volume snapshot configurations manipulation. Change-Id: I1d4dac68de44cecfc853b2388c23bfe3d1cc09cf Bug-Url: https://bugzilla.redhat.com/1202391 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 2 files changed, 23 insertions(+), 2 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d4dac68de44cecfc853b2388c23bfe3d1cc09cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Query to get list of cluster with nodes
by kmayilsa＠redhat.com 13 May '15

13 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Query to get list of cluster with nodes ...................................................................... engine: Query to get list of cluster with nodes Introduced a BLL query to get the list of clusters which have nodes attached with. Change-Id: I5c06388ec88436518ce2e8bd3855d64ba66400b7 Bug-Url: https://bugzilla.redhat.com/1202391 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllClustersHavingHostsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M packaging/dbscripts/vds_groups_sp.sql 6 files changed, 54 insertions(+), 0 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c06388ec88436518ce2e8bd3855d64ba66400b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: ovirt-engine-dwh-3.5.3
by sradco＠redhat.com 13 May '15

13 May '15

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5.3 ...................................................................... build: ovirt-engine-dwh-3.5.3 Change-Id: Idbc7eba0c4739dc7e8563f04470d8e5eac1193ff Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc7eba0c4739dc7e8563f04470d8e5eac1193ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Added range values to QoS error message - revisited
by rgolan＠redhat.com 13 May '15

13 May '15

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Added range values to QoS error message - revisited ...................................................................... webadmin: Added range values to QoS error message - revisited revisited to use the ConfiguredRangeValidator internal ${range} key Change-Id: I05779f7c655dc7354af647e2c154efd19c66f28b Bug-Url: https://bugzilla.redhat.com/1142333 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/QosRangeValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkQoS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 117 insertions(+), 31 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/40854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05779f7c655dc7354af647e2c154efd19c66f28b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin : Handle snapshot create multi-tab validation error
by kmayilsa＠redhat.com 13 May '15

13 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Handle snapshot create multi-tab validation error ...................................................................... webadmin : Handle snapshot create multi-tab validation error Snapshot create popup has 2 tabs : 1. General 2. Schedule Some Editors in both tabs have validations for each input elements in the tabs.However, although the validations validate as expected, the problem was as under: When user in some tab and a validation fails in an input element of the other tab, although tab complained of error, it used to go unnoticed as the tab reporting the error is not the one that is active. This patch, activates the tab that has the errors in the following order: 1. If the general tab has any validation failures, it opens up the general tab. 2. If the schedule tab has any failures, it opens up the schedule tab. In accordance with above 2 steps, if both the tabs have validation failures, immaterial of the number of failures in each tab or any other criteria, general tab opens up(Does nothing if its already open). Along with the above this patch also does the following: 1. Refactored EntityModelDateTimeBox and GwtDateTimeBox in accordance with most other widgets. 2. Corrected implementations of handling widget inValidity states. Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1215887 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1218606 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelCheckBoxGroupEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelDaysOfMonthSelectorEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeSnapshotCreatePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml 7 files changed, 183 insertions(+), 34 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88c05aa369758ce174b0dc85f83a253e608d6c0e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Cleanup for host upgrade related methods
by masayag＠redhat.com 13 May '15

13 May '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Cleanup for host upgrade related methods ...................................................................... webadmin: Cleanup for host upgrade related methods Change-Id: I645a981a113dbd74983f52d9c5846395607c470c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/40632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I645a981a113dbd74983f52d9c5846395607c470c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Allow passing --otopi-environment
by sbonazzo＠redhat.com 13 May '15

13 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Allow passing --otopi-environment ...................................................................... packaging: setup: Allow passing --otopi-environment Change-Id: I555592dd60411e29f953b847d7dce6a81bc0eda2 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/bin/ovirt-hosted-engine-setup 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555592dd60411e29f953b847d7dce6a81bc0eda2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Fix broken test
by masayag＠redhat.com 13 May '15

13 May '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix broken test ...................................................................... engine: Fix broken test Change-Id: Ib95e770efd1416a16e4a3179700e47dd8b590417 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommandTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib95e770efd1416a16e4a3179700e47dd8b590417 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0