Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-el6-3.5.3_rc1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-live-el6-3.5.3_rc1
......................................................................
build: ovirt-live-el6-3.5.3_rc1
Change-Id: I5ffbe314af7fae5eaedd3d1c006d4b1602156f99
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
M centos/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ffbe314af7fae5eaedd3d1c006d4b1602156f99
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Support host upgrade in NonOperational status
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Support host upgrade in NonOperational status
......................................................................
engine: Support host upgrade in NonOperational status
Change-Id: Ib1e41db5ef392531e48cf1b7c80b0f49d4f73c9c
Bug-Url: https://bugzilla.redhat.com/1157368
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
Objections:
Jenkins CI: Fails
--
To view, visit https://gerrit.ovirt.org/40838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e41db5ef392531e48cf1b7c80b0f49d4f73c9c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Update host for updates availability if needed
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Update host for updates availability if needed
......................................................................
engine: Update host for updates availability if needed
Updating the host should be performed only when the value
returned from querying the host differs from the actual
host value.
Change-Id: Id71eeb6bda3b5424cbdde089ccc09b981b29a6b1
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id71eeb6bda3b5424cbdde089ccc09b981b29a6b1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Hide c'tor of AvailableUpdatesFinder
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Hide c'tor of AvailableUpdatesFinder
......................................................................
engine: Hide c'tor of AvailableUpdatesFinder
AvailableUpdatesFinder is annotated as a singleton
and in order to preserve it as such, it should be
injected and not instantiated via a c'tor.
Change-Id: I60000c91e7ea81c84d7bb1db7ba48e96961067a0
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/AvailableUpdatesFinder.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60000c91e7ea81c84d7bb1db7ba48e96961067a0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Upgrade should start when host in maintenance
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Upgrade should start when host in maintenance
......................................................................
engine: Upgrade should start when host in maintenance
If the internal upgrade command was started, it means the
host was already moved to maintenance state. Therefore,
only if the upgrade command wasn't created, the status of
the maintenance command should be inspected.
Change-Id: Ib45faad4a3c6a18ce978e2dfd6b74948ff682c77
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib45faad4a3c6a18ce978e2dfd6b74948ff682c77
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Grammar fix
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Grammar fix
......................................................................
core: Grammar fix
Fixed the common mistake of using "more then" instead of "more than"
throughout the codebsae.
Change-Id: Idd4bba75e08bf89ce4bac5672c710ba313192f91
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M packaging/dbscripts/create_functions.sql
9 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/40898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd4bba75e08bf89ce4bac5672c710ba313192f91
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Move RetrieveImageDataVDSCommand log execution to DEBU...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Move RetrieveImageDataVDSCommand log execution to DEBUG level
......................................................................
core: Move RetrieveImageDataVDSCommand log execution to DEBUG level
Change-Id: I4066204d929c4af0ba9cbbbc4411dbe1a65d2c38
Bug-Url: https://bugzilla.redhat.com/1216116
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40873
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4066204d929c4af0ba9cbbbc4411dbe1a65d2c38
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Update host for available updates when ISOs are checked
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Update host for available updates when ISOs are checked
......................................................................
engine: Update host for available updates when ISOs are checked
When the GetoVirtISOsQuery is called, no input is persisted for
the host. Storing the updates availability will allow the user
to examine the host entity (in UI or Rest) for that information.
Change-Id: Ib9cf358ccfa986220cff871b02cf1b588495a086
Bug-Url: https://bugzilla.redhat.com/1157368
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsQuery.java
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9cf358ccfa986220cff871b02cf1b588495a086
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Block upgrade of host which wasn't installed before
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Block upgrade of host which wasn't installed before
......................................................................
engine: Block upgrade of host which wasn't installed before
An upgrade cannot be executed for a host which failed to
install before and never reported its capabilities to the
engine. For that use-case, the user should use the
"Install Host" flow.
Change-Id: I6bcf8e7342a6087921afaac834991029cf3eeedb
Bug-Url: https://bugzilla.redhat.com/1157368
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bcf8e7342a6087921afaac834991029cf3eeedb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: engine: Provide a precise feedback about updates
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Provide a precise feedback about updates
......................................................................
engine: Provide a precise feedback about updates
oVirt-node check for available updates should compare
the version of the updates to the current version of
the installed OS of the ovirt-node.
Applying this functionality will prevent the ability
to install the same OS version or previous versions
on the node via the 'Upgrade' action.
Change-Id: If9987cdf2cd4a149083368ddca965055e88fb6cb
Bug-Url: https://bugzilla.redhat.com/1157368
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9987cdf2cd4a149083368ddca965055e88fb6cb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months