Change in ovirt-engine[master]: core: configurable parent for create image template
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: configurable parent for create image template
......................................................................
core: configurable parent for create image template
We used to assume that CreateImageTemplateCommand is called from
AddVmTemplateCommand, so the parent command was hard-coded in
CreateImageTemplateCommand.
This patch modifies CreateImageTemplateCommand such that it will take
the parent command from the parameters instead. This change is needed
for adding commands that extend AddVmTemplateCommand such as add
template from snapshot.
Change-Id: If81b0e84e32674c094a2fbeaf1a2e26f2296a7f3
Bug-Url: https://bugzilla.redhat.com/1003492
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
Objections:
Jenkins CI: Fails
--
To view, visit https://gerrit.ovirt.org/41412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If81b0e84e32674c094a2fbeaf1a2e26f2296a7f3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: Enable creation of non-stateless VMs from 'latest' tem...
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Enable creation of non-stateless VMs from 'latest' templates
......................................................................
core: Enable creation of non-stateless VMs from 'latest' templates
Removed error message that appeared when user wanted to create a
non-stateless VM from 'latest' version of a template.
Change-Id: Ia6720b4c00fc81aa16838551c60891d91c8ae703
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1196570
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 0 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6720b4c00fc81aa16838551c60891d91c8ae703
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-reports[master]: reports: Fixed error in br49 trash-icon resource
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: reports: Fixed error in br49 trash-icon resource
......................................................................
reports: Fixed error in br49 trash-icon resource
Change-Id: I80427d9376bef42082249cfd91be7442299dcb37
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Service_level/Hosts/heatmap_report_cpu_usage_br49.xml
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41499
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80427d9376bef42082249cfd91be7442299dcb37
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core:force bool fence agents options value
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core:force bool fence agents options value
......................................................................
core:force bool fence agents options value
This patch fixes a error caused by fence-agents package that broke
backward compatibility.
fence-agents used to accept boolean agent flags as secure or lanplus
either as 'lanplus' or 'lanplus=1' or 'lanplus=true'
Now, we can not pass such options without a true/1 value
This patch fixes the issue by changing such flags in 2 places
1) The default options set by agent implicitly
2) The existing options stored in the fence_agents table
This patch does not address encrypted options and such should be
redefined
This will be clearly communicated via the BZ release notes.
Change-Id: I45f7a245dc01186f85619efd062c6f326c40d095
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1225082
Signed-off-by: emesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_05_1270_fix_bool_fence_agents_options.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 36 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41482
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45f7a245dc01186f85619efd062c6f326c40d095
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: core: return created image from scratch
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: return created image from scratch
......................................................................
core: return created image from scratch
In several future flows we need to know the volume id of an image which
is created from scratch. This patch returns the DiskImage instance as
the return value of the end-action phase of AddImageFromScratchCommand.
Change-Id: I6a41d57bfb1bf48f0a2c6a3703e612b27da50db8
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/36425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a41d57bfb1bf48f0a2c6a3703e612b27da50db8
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: Core, UI: Allow '-' in network name
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: Core, UI: Allow '-' in network name
......................................................................
Core, UI: Allow '-' in network name
Engine now allows '-' in logical network name.
Change-Id: I2c5bf32dd510c386faff2ee1d041621451f2e352
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910215
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Verified
--
To view, visit https://gerrit.ovirt.org/41019
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c5bf32dd510c386faff2ee1d041621451f2e352
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.3-1
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: post ovirt-engine-reports-3.5.3-1
......................................................................
build: post ovirt-engine-reports-3.5.3-1
Change-Id: Ieef3a0b8727a8dc1ce17f9ee0f4622a3677fd24f
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieef3a0b8727a8dc1ce17f9ee0f4622a3677fd24f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.3-1
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: ovirt-engine-reports-3.5.3-1
......................................................................
build: ovirt-engine-reports-3.5.3-1
Change-Id: Ie94b96ced94219e89d6724de28397536cf10fc6f
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie94b96ced94219e89d6724de28397536cf10fc6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: gluster: change brick creation failure audit log to error
by sabose@redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: change brick creation failure audit log to error
......................................................................
gluster: change brick creation failure audit log to error
Change the severity of Brick Creation failure to Error.
Change-Id: Id87851b03a1581f503ab15ec00e2738b81ef4a77
Bug-Url: https://bugzilla.redhat.com/1220784
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/41054
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id87851b03a1581f503ab15ec00e2738b81ef4a77
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5.3
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: post ovirt-engine-dwh-3.5.3
......................................................................
build: post ovirt-engine-dwh-3.5.3
Change-Id: Ie6d80e4665c3979b9cb325493354608f0c7b99c4
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6d80e4665c3979b9cb325493354608f0c7b99c4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months