May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: ovirt-engine-dwh-3.5.3
by sradco＠redhat.com 27 May '15

27 May '15

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5.3 ...................................................................... build: ovirt-engine-dwh-3.5.3 Change-Id: I18fbf1ababfbe1316e3a372745227080c7cbaa86 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18fbf1ababfbe1316e3a372745227080c7cbaa86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: fix for JSON RPC issue in glusterCreateBrick
by sabose＠redhat.com 27 May '15

27 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix for JSON RPC issue in glusterCreateBrick ...................................................................... gluster: fix for JSON RPC issue in glusterCreateBrick Renaming the parameters as required in the in JSON RPC for glusterCreateBrick Change-Id: I561b6edde3ed31a3bda67369a7f208e7cecdca54 Bug-Url: https://bugzilla.redhat.com/1201263 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/40863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I561b6edde3ed31a3bda67369a7f208e7cecdca54 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: addHost form leaves json checkbox locked when swit...
by oourfali＠redhat.com 27 May '15

27 May '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters ...................................................................... webadmin: addHost form leaves json checkbox locked when switching between clusters Edit host dialog needs a change listener to enable and disable json checkbox Change-Id: I38bfe657750819a772a97251f3cee93cc2de9d76 Bug-Url: https://bugzilla.redhat.com/1209754 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38bfe657750819a772a97251f3cee93cc2de9d76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: addHost form leaves json checkbox locked when swit...
by oourfali＠redhat.com 26 May '15

26 May '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters ...................................................................... webadmin: addHost form leaves json checkbox locked when switching between clusters Edit host dialog needs a change listener to enable and disable json checkbox Change-Id: I38bfe657750819a772a97251f3cee93cc2de9d76 Bug-Url: https://bugzilla.redhat.com/1179689 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38bfe657750819a772a97251f3cee93cc2de9d76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: sos: adapt to engine sosreport to sos 3.2
by sbonazzo＠redhat.com 26 May '15

26 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: adapt to engine sosreport to sos 3.2 ...................................................................... sos: adapt to engine sosreport to sos 3.2 SOS plugins have been refactored between sos 2 and sos 3, enabling additional plugins for sos > 3 Change-Id: I6a875df5d3cd7f8946092fe9b0976b6541f9a1d4 Bug-Url: https://bugzilla.redhat.com/1218526 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a875df5d3cd7f8946092fe9b0976b6541f9a1d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Gonz Rafuls <grafuls(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: config: fix exception handling
by sbonazzo＠redhat.com 26 May '15

26 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: fix exception handling ...................................................................... config: fix exception handling Fix: Traceback (most recent call last): File "/usr/bin/engine-log-collector", line 1437, in <module> setup_pg_defaults() File "/usr/bin/engine-log-collector", line 165, in setup_pg_defaults pg_user = get_pg_var('admin') or pg_user File "/usr/bin/engine-log-collector", line 138, in get_pg_var if e.errno != errno.ENOENT: NameError: global name 'e' is not defined Change-Id: I87c5beb46a5bd8df6e01e0472db0f5dc45bfd9c1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87c5beb46a5bd8df6e01e0472db0f5dc45bfd9c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: don't return used bricks in GetUnusedGlusterBricksQ...
by sabose＠redhat.com 26 May '15

26 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: don't return used bricks in GetUnusedGlusterBricksQuery ...................................................................... gluster: don't return used bricks in GetUnusedGlusterBricksQuery There is an issue with the filtering logic in query GetUnusedGlusterBricksQuery. Brick directory will not be just brick mount point, it will be a directory inside the brick mount point. Hence changing the logic accordigly Change-Id: I2fb08502a31b02484f9d902172832ccdfa4ef48a Bug-Url: https://bugzilla.redhat.com/1216318 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/40843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fb08502a31b02484f9d902172832ccdfa4ef48a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin : Fix volume main and sub tab column id issue
by kmayilsa＠redhat.com 26 May '15

26 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fix volume main and sub tab column id issue ...................................................................... webadmin : Fix volume main and sub tab column id issue This patch does the following, 1. Adding column's to MainTabVolumeView require columns to override AbstractColumn or handle id on own. But overriding AbstractColumn provides base implementation for ColumnWithElementId#configureElementId which actually assigns ids for columns. Accordingly changes are performed in, [i] Changed VolumeActivityColumn 2. Now, ApplicationTemplates#statusTemplate takes a SafeHtml and a string id. Some of the cells corrected as part of this patch used to treat tooltips as ids and now this patch corrects it by adding new templates to ApplicationTemplate for handling tooltip requiring images and also handles ids for such columns. Accordingly changes are performed in, [i] GlusterCapacityCell and hence VolumeCapacityCell and BrickCapacityCell [ii] VolumeInfoCell Change-Id: Ifded690b427ba8eb17bba272360f916850f76891 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1220393 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeCapacityCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickCapacityCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java 6 files changed, 19 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve anmolbabu: Verified Kanagaraj M: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifded690b427ba8eb17bba272360f916850f76891 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: change the value in RaidType to String
by sabose＠redhat.com 26 May '15

26 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: change the value in RaidType to String ...................................................................... gluster: change the value in RaidType to String Changing the type of value in RaidType to String from int. VDSM expects these values to be string instead of int. Change-Id: I84d2eaf3e20a81035740e313fdc101d373029011 Bug-Url: https://bugzilla.redhat.com/1215000 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RaidType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/CreateBrickPopupPresenterWidget.java 7 files changed, 31 insertions(+), 31 deletions(-) Approvals: Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/40842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84d2eaf3e20a81035740e313fdc101d373029011 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: Remove RAID types 1, 2, 5 from the list.
by sabose＠redhat.com 26 May '15

26 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Remove RAID types 1,2,5 from the list. ...................................................................... gluster: Remove RAID types 1,2,5 from the list. Remove the RAID types 1,2,5 from the list of RAID types from create brick pop up as they are not recommand for Gluster. Change-Id: If7c4baf52fba9bc6c8cd704ca6e04e2a5d4d2c02 Bug-Url: https://bugzilla.redhat.com/1209441 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RaidType.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/40841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c4baf52fba9bc6c8cd704ca6e04e2a5d4d2c02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0