May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: fix for JSON RPC issue in glusterCreateBrick
by sabose＠redhat.com 28 May '15

28 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix for JSON RPC issue in glusterCreateBrick ...................................................................... gluster: fix for JSON RPC issue in glusterCreateBrick Renaming the parameters as required in the in JSON RPC for glusterCreateBrick Change-Id: I561b6edde3ed31a3bda67369a7f208e7cecdca54 Bug-Url: https://bugzilla.redhat.com/1201263 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I561b6edde3ed31a3bda67369a7f208e7cecdca54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: don't return used bricks in GetUnusedGlusterBricksQ...
by sabose＠redhat.com 28 May '15

28 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: don't return used bricks in GetUnusedGlusterBricksQuery ...................................................................... gluster: don't return used bricks in GetUnusedGlusterBricksQuery There is an issue with the filtering logic in query GetUnusedGlusterBricksQuery. Brick directory will not be just brick mount point, it will be a directory inside the brick mount point. Hence changing the logic accordigly Change-Id: I2fb08502a31b02484f9d902172832ccdfa4ef48a Bug-Url: https://bugzilla.redhat.com/1216318 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fb08502a31b02484f9d902172832ccdfa4ef48a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: change the value in RaidType to String
by sabose＠redhat.com 28 May '15

28 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: change the value in RaidType to String ...................................................................... gluster: change the value in RaidType to String Changing the type of value in RaidType to String from int. VDSM expects these values to be string instead of int. Change-Id: I84d2eaf3e20a81035740e313fdc101d373029011 Bug-Url: https://bugzilla.redhat.com/1215000 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RaidType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/CreateBrickPopupPresenterWidget.java 7 files changed, 31 insertions(+), 31 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84d2eaf3e20a81035740e313fdc101d373029011 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Remove RAID types 1, 2, 5 from the list.
by sabose＠redhat.com 28 May '15

28 May '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Remove RAID types 1,2,5 from the list. ...................................................................... gluster: Remove RAID types 1,2,5 from the list. Remove the RAID types 1,2,5 from the list of RAID types from create brick pop up as they are not recommand for Gluster. Change-Id: If7c4baf52fba9bc6c8cd704ca6e04e2a5d4d2c02 Bug-Url: https://bugzilla.redhat.com/1209441 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RaidType.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/41531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c4baf52fba9bc6c8cd704ca6e04e2a5d4d2c02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: ovirt-live-3.5.3-rc2
by sbonazzo＠redhat.com 28 May '15

28 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-live-3.5.3-rc2 ...................................................................... ovirt-live-3.5.3-rc2 Change-Id: Idc4704b53d86a8690d5ac01fd6f9ab3ce8d09d21 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc4704b53d86a8690d5ac01fd6f9ab3ce8d09d21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Move Job, Step to JPA
by masayag＠redhat.com 27 May '15

27 May '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Move Job, Step to JPA ...................................................................... core: Move Job, Step to JPA Moving the Job and Step entities to JPA Change-Id: Ifcfda7b055d37c92c1346b100101c27d594d21fb Bug-Url: https://bugzilla.redhat.com/1159621 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java M backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/ExternalSystem.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/JobSubjectEntity.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/JobSubjectEntityId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DaoCdiIntegrationTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/test-beans.xml M packaging/dbscripts/job_sp.sql 19 files changed, 621 insertions(+), 990 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/34553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcfda7b055d37c92c1346b100101c27d594d21fb Gerrit-PatchSet: 56 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: set requires HE
by dougsland＠redhat.com 27 May '15

27 May '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: set requires HE ...................................................................... spec: set requires HE Return the requires Hosted Engine plugin. Change-Id: I02f7505be03587344ab7cd49c5fb372418cb24d1 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/41519 Reviewed-by: Jenkins CI Tested-by: Jenkins CI --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f7505be03587344ab7cd49c5fb372418cb24d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Correctly copy memballoon device from template
by ofrenkel＠redhat.com 27 May '15

27 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Correctly copy memballoon device from template ...................................................................... core: Correctly copy memballoon device from template When memballoon device is present in the template and enabled in the VM, it is copied from the template. If it is absent in the template, but enabled in the VM, it is created for the VM. Change-Id: I8585a7301ebedb8b93f46dde2677747c5afc1d6f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1218690 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 21 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8585a7301ebedb8b93f46dde2677747c5afc1d6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: adapt to engine sosreport to sos 3.2
by sbonazzo＠redhat.com 27 May '15

27 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: adapt to engine sosreport to sos 3.2 ...................................................................... sos: adapt to engine sosreport to sos 3.2 SOS plugins have been refactored between sos 2 and sos 3, enabling additional plugins for sos > 3 Change-Id: I6a875df5d3cd7f8946092fe9b0976b6541f9a1d4 Bug-Url: https://bugzilla.redhat.com/1225117 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 82e9694d03992d35b62f5ba91c28086ad6fca936) --- M src/__main__.py 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a875df5d3cd7f8946092fe9b0976b6541f9a1d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Refactoring in AddVmFromTemplateCommand.canDoAction()
by ofrenkel＠redhat.com 27 May '15

27 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Refactoring in AddVmFromTemplateCommand.canDoAction() ...................................................................... core: Refactoring in AddVmFromTemplateCommand.canDoAction() Removed redundant reference to diskInfoDestinationMap. Change-Id: Ib621adcc77c09e9ec532312a18cdb2bc5b5c8a7f Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib621adcc77c09e9ec532312a18cdb2bc5b5c8a7f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0