June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: setup: Stop services only when needed
by sradco＠redhat.com 17 Jun '15

17 Jun '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Stop services only when needed ...................................................................... packaging: setup: Stop services only when needed Added env key for stopping dwhd. Stopping dwhd defaults to False and is set to True in setup/cleanup if needed. Change-Id: I1925ca82cb48027e4fef2c439f3d83e8058fadd9 Bug-Url: https://bugzilla.redhat.com/1198107 Bug-Url: https://bugzilla.redhat.com/956226 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/service.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/clear.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/42430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1925ca82cb48027e4fef2c439f3d83e8058fadd9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce restore from Cinder snapshot
by mlipchuk＠redhat.com 17 Jun '15

17 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce restore from Cinder snapshot ...................................................................... core: Introduce restore from Cinder snapshot Intoroduce restore for Cinder snapshot. Change-Id: Ibd2c3ed4b2f2d0684476d9df9090d95dda72fd4e Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommandCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreFromSnapshotParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 285 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd2c3ed4b2f2d0684476d9df9090d95dda72fd4e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce restore all cinder snapshots command.
by mlipchuk＠redhat.com 17 Jun '15

17 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce restore all cinder snapshots command. ...................................................................... core: Introduce restore all cinder snapshots command. Introduce restore for all cinder snapshts command. Change-Id: I3189bd1c586957800eb5784877cd605ae9f847fc Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreAllCinderSnapshotsCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllCinderSnapshotsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 3 files changed, 173 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42338 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3189bd1c586957800eb5784877cd605ae9f847fc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Rename CindeBroker method
by mlipchuk＠redhat.com 17 Jun '15

17 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Rename CindeBroker method ...................................................................... core: Rename CindeBroker method Rename Cinder broker method to make it more clear Change-Id: I0bc64e0f850f202ccd3c67decfcb6cc02312ce1b Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bc64e0f850f202ccd3c67decfcb6cc02312ce1b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support restore for Cinder snapshot
by mlipchuk＠redhat.com 17 Jun '15

17 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support restore for Cinder snapshot ...................................................................... core: Support restore for Cinder snapshot Add support for restoring VM snapshot with snapshots. Change-Id: I87e08dd1736b1f49d6fd265d2492ac44b55f0ae4 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 72 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/42339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e08dd1736b1f49d6fd265d2492ac44b55f0ae4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Stop services only when needed
by sbonazzo＠redhat.com 17 Jun '15

17 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Stop services only when needed ...................................................................... packaging: setup: Stop services only when needed Added env keys for stopping engine, fence-kdump-listener, websocket-proxy. Stopping the engine defaults to True and can be disabled by other plugins. The others default to False and are set to True if needed. Change-Id: Ic562409546a717b6c07f848c1f0f6e7ddc2d1c77 Bug-Url: https://bugzilla.redhat.com/1198107 Bug-Url: https://bugzilla.redhat.com/956226 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py 9 files changed, 73 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/42411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic562409546a717b6c07f848c1f0f6e7ddc2d1c77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Remove log-setup-event
by sbonazzo＠redhat.com 17 Jun '15

17 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Remove log-setup-event ...................................................................... packaging: setup: Remove log-setup-event Remove the script ovirt-engine-log-setup-event.sh, which adds info about setup/upgrade/etc start/stop events to /var/lib/ovirt-engine/setup-history.txt . Existing log files should be enough to get this info. It needlessly slowed down engine-setup and related tools. Change-Id: I5305f63f0d493ca394518498f56c2ae9f265f185 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in D packaging/bin/ovirt-engine-log-setup-event.sh.in M packaging/setup/ovirt_engine_setup/constants.py D packaging/setup/plugins/ovirt-engine-common/base/distro-rpm/__init__.py D packaging/setup/plugins/ovirt-engine-common/base/distro-rpm/log_setup_event.py 7 files changed, 0 insertions(+), 222 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/42401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5305f63f0d493ca394518498f56c2ae9f265f185 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, webadmin: Vm Icons REST related changes
by ofrenkel＠redhat.com 17 Jun '15

17 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core, webadmin: Vm Icons REST related changes ...................................................................... core, webadmin: Vm Icons REST related changes * Icon validation unified in Add/UpdateVmCommand and Add/UpdateVmTemplateCommand * New queries for convenient rest implementation GetAllVmIconsQuery, GetVmIconDefaultQuery, GetVmIconQuery * Query parameters that are used to upload large icon are marked by HasVmIcon interface * Error messages in frontend part Change-Id: I20440c2443f9217d0fa896fff2911943467954e9 Bug-Url: https://bugzilla.redhat.com/1103175 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmIconsQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmIconDefaultQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmIconQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IconValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HasVmIcon.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmIcon.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmIconDefaultParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 21 files changed, 246 insertions(+), 9 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20440c2443f9217d0fa896fff2911943467954e9 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Added performance wrappers
by sbonazzo＠redhat.com 17 Jun '15

17 Jun '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Added performance wrappers ...................................................................... packaging: engine-backup: Added performance wrappers Added --fast-restore, --small-size, --fast-backup . Change-Id: I95e91f1228082ea0266630d09511aaac42e000ca Bug-Url: https://bugzilla.redhat.com/1213153 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 70 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Jenkins CI: Verified; Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/42443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95e91f1228082ea0266630d09511aaac42e000ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Added storage missing fields to Cloner
by tnisan＠redhat.com 17 Jun '15

17 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added storage missing fields to Cloner ...................................................................... webadmin: Added storage missing fields to Cloner Change-Id: I0b9f7fc6952c974e3adb2bc3692de70c241d38da Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Jenkins CI: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/42086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9f7fc6952c974e3adb2bc3692de70c241d38da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0