Change in ovirt-engine[master]: core: Small fixes in TimeZone display values
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: core: Small fixes in TimeZone display values
......................................................................
core: Small fixes in TimeZone display values
Renamed display values of time zones mapped to 'GMT' to
help users differentiate between them.
Change-Id: I1ef9e1a3f1e459b6a4513a608a650ede1b6a6570
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232695
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/43603
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef9e1a3f1e459b6a4513a608a650ede1b6a6570
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: OvfManager handles Vm Icons
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: OvfManager handles Vm Icons
......................................................................
core: OvfManager handles Vm Icons
Vm Icons are not serialized to OVF format. OvfManager now can set icon
properties according to operating system id and fallback to default
icons which prevents null values in icon columns of vm_static table.
Change-Id: I30bfb275885ba673743cd700b0389ded9e038f40
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1243029
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmIconDefaultsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmIconDefaultsProvider.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
12 files changed, 132 insertions(+), 2 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43543
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30bfb275885ba673743cd700b0389ded9e038f40
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: restapi: Avoid having leftovers when adding NFS SD.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: restapi: Avoid having leftovers when adding NFS SD.
......................................................................
restapi: Avoid having leftovers when adding NFS SD.
If the process, of adding/importing NFS Storage Domain,
fails while validating the storage domain name,
the storage server connection data, which was added in the process,
does not gets deleted from the DB.
The proposed fix validates the name inside the try catch clause.
Change-Id: I7b001468fbbb3a30c08f8efdf0db74db946874d5
Bug-Url: https://bugzilla.redhat.com/1208057
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/43923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b001468fbbb3a30c08f8efdf0db74db946874d5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernández
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Remove redundant comment.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove redundant comment.
......................................................................
core: Remove redundant comment.
Change-Id: Ic6833ef6139746f706e3a26226592da71fab0c8a
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/43922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6833ef6139746f706e3a26226592da71fab0c8a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: build: reduce usage of sjf4j-jdk14 spring-test
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: build: reduce usage of sjf4j-jdk14 spring-test
......................................................................
build: reduce usage of sjf4j-jdk14 spring-test
move some of the usages to test scope.
also reorder the effected pom.xmls so that format will match others and
test scope will follow the common scope.
Change-Id: I9f89fbb9af76a0712ade2862f42ad0d1beeb0010
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
5 files changed, 68 insertions(+), 85 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liran Zelkha: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/43898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f89fbb9af76a0712ade2862f42ad0d1beeb0010
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: engine: Remove redundant assignment
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Remove redundant assignment
......................................................................
engine: Remove redundant assignment
Change-Id: Iccb5f3ae94b66dd166d91c770816cd7b416d8b20
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccb5f3ae94b66dd166d91c770816cd7b416d8b20
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: engine: Postpone certs validity check service start
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Postpone certs validity check service start
......................................................................
engine: Postpone certs validity check service start
Due to race between the host broker initialization and the
attempt to obtain host certificates, there is a need to
delay the certification check service, to allow the engine
to obtain connectivity to the host and properly restart
the brokers.
Change-Id: I350fb5a68992b1de7af20bcb3b4c816eabafc80f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I350fb5a68992b1de7af20bcb3b4c816eabafc80f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: engine: Wrap cert validity check with try-catch
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Wrap cert validity check with try-catch
......................................................................
engine: Wrap cert validity check with try-catch
In certain cases the startup of the service fails.
This patch capture the exception and prints it to allow
a simple debug.
Change-Id: Ibe1dfafe7775286fbe30c4b6893ac2c2215527c6
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java
1 file changed, 35 insertions(+), 26 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe1dfafe7775286fbe30c4b6893ac2c2215527c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: userportal, webadmin: use proper width values in form panel
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: use proper width values in form panel
......................................................................
userportal,webadmin: use proper width values in form panel
- The widths of the form items on the panel were defined but then
promptly reset to half the available width on updates. This patch
fixes the updates so they take the original value into account.
Change-Id: I355404e186defb1a2901b2ad9e520515818d102a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230723
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java
2 files changed, 53 insertions(+), 18 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I355404e186defb1a2901b2ad9e520515818d102a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in samples-uiplugins[master]: Introducing ProgressBar plugin (initial demo version)
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: Introducing ProgressBar plugin (initial demo version)
......................................................................
Introducing ProgressBar plugin (initial demo version)
This plugin tracks user's progress of using the oVirt system
through achievements organized in different categories.
The goal of this plugin is to encourage users to explore all
features available in oVirt.
This plugin uses following development stack:
* AngularJS, Model-View-Controller framework for JavaScript
http://angularjs.org/
* Bootstrap, visual component framework for CSS
http://getbootstrap.com/
* UI Bootstrap, Bootstrap's visual components ported to AngularJS
http://angular-ui.github.io/bootstrap/
* Jasmine, Behavior-Driven Development style testing framework
for JavaScript
http://pivotal.github.io/jasmine/
* Karma, test runner for JavaScript
http://karma-runner.github.io/
Check out README file for details on installation
and setting up local development environment.
Change-Id: I77b44668eb9fa5ce4c7753feffd86fe6b94f1d49
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
A progressbar-plugin-demo/.gitignore
A progressbar-plugin-demo/README
A progressbar-plugin-demo/karma.conf.js
A progressbar-plugin-demo/progressbar.json
A progressbar-plugin-demo/src/css/progress-tab.css
A progressbar-plugin-demo/src/js/init-service.js
A progressbar-plugin-demo/src/js/init.js
A progressbar-plugin-demo/src/js/tab-controller.js
A progressbar-plugin-demo/src/js/tab.js
A progressbar-plugin-demo/src/lib/angular/js/angular-animate.js
A progressbar-plugin-demo/src/lib/angular/js/angular-animate.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-animate.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular-cookies.js
A progressbar-plugin-demo/src/lib/angular/js/angular-cookies.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-cookies.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular-loader.js
A progressbar-plugin-demo/src/lib/angular/js/angular-loader.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-loader.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular-resource.js
A progressbar-plugin-demo/src/lib/angular/js/angular-resource.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-resource.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular-route.js
A progressbar-plugin-demo/src/lib/angular/js/angular-route.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-route.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular-sanitize.js
A progressbar-plugin-demo/src/lib/angular/js/angular-sanitize.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-sanitize.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular-touch.js
A progressbar-plugin-demo/src/lib/angular/js/angular-touch.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular-touch.min.js.map
A progressbar-plugin-demo/src/lib/angular/js/angular.js
A progressbar-plugin-demo/src/lib/angular/js/angular.min.js
A progressbar-plugin-demo/src/lib/angular/js/angular.min.js.map
A progressbar-plugin-demo/src/lib/angular/version.txt
A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap-theme.css
A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap-theme.min.css
A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap.css
A progressbar-plugin-demo/src/lib/bootstrap/css/bootstrap.min.css
A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.eot
A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.svg
A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.ttf
A progressbar-plugin-demo/src/lib/bootstrap/fonts/glyphicons-halflings-regular.woff
A progressbar-plugin-demo/src/lib/bootstrap/version.txt
A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap-tpls.js
A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap-tpls.min.js
A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap.js
A progressbar-plugin-demo/src/lib/ui-bootstrap/js/ui-bootstrap.min.js
A progressbar-plugin-demo/src/lib/ui-bootstrap/version.txt
A progressbar-plugin-demo/src/plugin.html
A progressbar-plugin-demo/src/progress-tab.html
A progressbar-plugin-demo/test/js/init-service-specs.js
A progressbar-plugin-demo/test/js/test-util.js
A progressbar-plugin-demo/test/lib/angular/js/angular-mocks.js
A progressbar-plugin-demo/test/lib/angular/version.txt
54 files changed, 42,897 insertions(+), 0 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/23013
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77b44668eb9fa5ce4c7753feffd86fe6b94f1d49
Gerrit-PatchSet: 2
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
9 years, 5 months