July 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: select virtio drivers iso on import vm

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: select virtio drivers iso on import vm ...................................................................... webadmin: select virtio drivers iso on import vm The user can now select which virtio drivers to use when he imports a VM from an external provider (using virt-v2v). This selection is optional. Change-Id: I7fd184bb4847dd07e1ac6b831c6857eeb8a16fc7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.ui.xml 4 files changed, 108 insertions(+), 29 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fd184bb4847dd07e1ac6b831c6857eeb8a16fc7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix stored procedure with SQL language.

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: core: Fix stored procedure with SQL language. ...................................................................... core: Fix stored procedure with SQL language. Stored procedure with SQL language. Need special arguments references. As specified here: http://www.postgresql.org/docs/current/static/xfunc-sql.html section 35.4.1 This bug need further consideration to be caught by testing framework. Solution: change stored procedure to use plpgsql language. Change-Id: If59c2349d16dde4f6a64e654230db66fe3bd53f2 Bug-Url: https://bugzilla.redhat.com/1244154 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Dudi Maroshi: Verified Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/43884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If59c2349d16dde4f6a64e654230db66fe3bd53f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in jenkins[master]: deploying new YAML conf: ignore empty xml diff file

by eedri＠redhat.com

Eyal Edri has submitted this change and it was merged. Change subject: deploying new YAML conf: ignore empty xml diff file ...................................................................... deploying new YAML conf: ignore empty xml diff file Change-Id: I1625e4596c83cd8b1b25dd1e5b3bee18aa20c56f Signed-off-by: Paz Dangur <pdangur(a)redhat.com> --- M jobs/confs/groovy-scripts/archive_jobs.groovy 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests Paz Dangur: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/43806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1625e4596c83cd8b1b25dd1e5b3bee18aa20c56f Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Vertical alignment of Run Once dialog > Linux boot...

by vszocs＠redhat.com

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Vertical alignment of Run Once dialog > Linux boot options ...................................................................... webadmin: Vertical alignment of Run Once dialog > Linux boot options Fix of vertical alignmet in 'Run Once' dialog, section 'Linux boot options' Change-Id: I811402cd8ffd5acde51ba9c9ecc1617c678e57e4 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1200952 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811402cd8ffd5acde51ba9c9ecc1617c678e57e4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Set volume classification as snapshot for image snapshot.

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set volume classification as snapshot for image snapshot. ...................................................................... core: Set volume classification as snapshot for image snapshot. Volume classification is a DB column which specifies whether a volume is an active volume or a snapshot. Once a snapshot is added, we should update the volume classification of the snapshot to snapshot instead of volume. Change-Id: Ieed6f7183bb2540dcbcf8d2ddd36a4bf4dfe6a61 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieed6f7183bb2540dcbcf8d2ddd36a4bf4dfe6a61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Avoid NPE when trying to commit Cinder snapshot

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Avoid NPE when trying to commit Cinder snapshot ...................................................................... core: Avoid NPE when trying to commit Cinder snapshot Avoid NPE once we commit a Cinder snapshot which doesn't has any descendants Change-Id: Ifb0a12462750860e217b01c0e333d804d07e875e Bug-Url: https://bugzilla.redhat.com/1245505 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RestoreFromCinderSnapshotCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb0a12462750860e217b01c0e333d804d07e875e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Remove visibility modifier from HostResource

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Remove visibility modifier from HostResource ...................................................................... restapi: Remove visibility modifier from HostResource Change-Id: Iba4c2c132798451f45aeee148d374215a98c5c1b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/43883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba4c2c132798451f45aeee148d374215a98c5c1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: add use_sysprep and use_cloud_init for Vm creation

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: add use_sysprep and use_cloud_init for Vm creation ...................................................................... restapi: add use_sysprep and use_cloud_init for Vm creation By default we attach sysprep for new Windows VM - added new tags for the user to determine the behaviour, for backward compatibility the default is to attach sysprep for new Windows VMs. Change-Id: Iffc4c7ea50efd2ea332918e1b31594e3a949f4ee Bug-Url: https://bugzilla.redhat.com/1190663 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties 5 files changed, 28 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc4c7ea50efd2ea332918e1b31594e3a949f4ee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernández Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in jenkins[master]: Fixed issue when user group already exists

by dcaroest＠redhat.com

David Caro has submitted this change and it was merged. Change subject: Fixed issue when user group already exists ...................................................................... Fixed issue when user group already exists It was working until now because it did never exist on the vms Change-Id: I168d23f111c61aae1751d48deb342b08ff5e8b3b Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me Barak Korren: Looks good to me David Caro: Verified; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/43865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I168d23f111c61aae1751d48deb342b08ff5e8b3b Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: Remove suppportedProtocols from getVdsCaps verification

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: Remove suppportedProtocols from getVdsCaps verification ...................................................................... Remove suppportedProtocols from getVdsCaps verification supportedProtocols parameters is not in used since ovirt-2.x https://gerrit.ovirt.org/43571 removes this value from vdsm report for getCaps. This following patch fix the test that handles it. Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Change-Id: I23c9bd7494a0d8daffc34ef5a883e0a455faf931 --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/MarshallingTestCase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23c9bd7494a0d8daffc34ef5a883e0a455faf931 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2015