July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: inject refresher-factory
by ahadas＠redhat.com 19 Jul '15

19 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: inject refresher-factory ...................................................................... core: inject refresher-factory There was a right comment in RefresherFactory that says it should have been injected. This patch does it, RefresherFactory is set as a singleton and is being injected into VdsManager instead of having static methods in RefreshFactory. Change-Id: I0c1f9035c937042288dfae200a08561abee23f9c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c1f9035c937042288dfae200a08561abee23f9c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: make PollVMStatsRefresher abstract
by ahadas＠redhat.com 19 Jul '15

19 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: make PollVMStatsRefresher abstract ...................................................................... core: make PollVMStatsRefresher abstract Better class hierarchy for poll-based vm-stats refreshers is to have an abstract class that contains the common things for polling and then specific refreshers will extend it. This patch changes PollVMStatsRefresher to be abstract and presents a new refresher PollListAndAllVmStatsRefresher that extends it and implements the legacy polling that we used to have before 3.6. In addition, PollAllVmStatsOnlyRefresher is changed to implement only the things that varies instead of override the 'poll' method. Change-Id: I2d6277d3ca0ab14a9431284a13744943b6a4945b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollAllVmStatsOnlyRefresher.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollListAndAllVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java 4 files changed, 62 insertions(+), 36 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d6277d3ca0ab14a9431284a13744943b6a4945b Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove polling specific code from vm-stats refresher
by ahadas＠redhat.com 19 Jul '15

19 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: remove polling specific code from vm-stats refresher ...................................................................... core: remove polling specific code from vm-stats refresher This patch moves the code that is specific to polling from VMStatsRefresher to PoolVMStatsRefresher. This way, VMStatsRefresher becomes purely abstract. Change-Id: Ie3406bc6b3ab4a603de53a6140f631436b92a1f8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java 3 files changed, 47 insertions(+), 55 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3406bc6b3ab4a603de53a6140f631436b92a1f8 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: consider extkey flags when dumping
by masayag＠redhat.com 19 Jul '15

19 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: consider extkey flags when dumping ...................................................................... exttool: consider extkey flags when dumping Change-Id: I961bd0184322371a88a062b964d94634afa1bddd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961bd0184322371a88a062b964d94634afa1bddd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix console().readPassword()
by masayag＠redhat.com 19 Jul '15

19 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: core: fix console().readPassword() ...................................................................... core: fix console().readPassword() may return null on EOF. Change-Id: Ia20f7ff534233f15bb2d4ebbc87d37c373ab4066 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/cryptotool/Main.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/ToolConsole.java 5 files changed, 19 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia20f7ff534233f15bb2d4ebbc87d37c373ab4066 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforce avoiding HC setup
by sbonazzo＠redhat.com 17 Jul '15

17 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: enforce avoiding HC setup ...................................................................... packaging: setup: enforce avoiding HC setup Enforce avoiding HC setup Change-Id: Iece38ae35c971e29fbc9148b87f275549286932a Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/ovirt-hosted-engine-setup/storage/glusterfs.py 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iece38ae35c971e29fbc9148b87f275549286932a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: validate ISO file type
by sbonazzo＠redhat.com 17 Jul '15

17 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate ISO file type ...................................................................... packaging: setup: validate ISO file type Validate ISO file type if booting from ISO image Change-Id: I155ea7058470daf1c1eb17b23d53a752ef738282 Bug-Url: https://bugzilla.redhat.com/1032069 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py 1 file changed, 27 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I155ea7058470daf1c1eb17b23d53a752ef738282 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: sercon: rename ssh certs when copying in /etc
by sbonazzo＠redhat.com 17 Jul '15

17 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: sercon: rename ssh certs when copying in /etc ...................................................................... sercon: rename ssh certs when copying in /etc Fixes missing rename of the certs file when copied on the final path under /etc. Previously the files where just copied. Change-Id: I9aff7680a125b06b388b3e7730ecaa82d7548eed Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/43239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aff7680a125b06b388b3e7730ecaa82d7548eed Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: Revert "packaging: setup: adding --deploy-hc CLI option" Ski...
by sbonazzo＠redhat.com 17 Jul '15

17 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "packaging: setup: adding --deploy-hc CLI option" Skipping HC stuff on master, keeping it on 2.0 as an HC developing branch. ...................................................................... Revert "packaging: setup: adding --deploy-hc CLI option" Skipping HC stuff on master, keeping it on 2.0 as an HC developing branch. This reverts commit b3f6536acb863fb0b6e798676e54f3fce0ed8155. Change-Id: If41326575992b97b5767170fcc85de0d36978ed8 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M man/ovirt-hosted-engine-setup.8 M src/bin/hosted-engine.in M src/bin/ovirt-hosted-engine-setup M src/plugins/ovirt-hosted-engine-setup/core/misc.py M templates/Makefile.am D templates/hc.answer.conf.in 7 files changed, 2 insertions(+), 49 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If41326575992b97b5767170fcc85de0d36978ed8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: publish-rpms-nightly-master: drop reports from f22
by sbonazzo＠redhat.com 17 Jul '15

17 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: publish-rpms-nightly-master: drop reports from f22 ...................................................................... publish-rpms-nightly-master: drop reports from f22 dropping ovirt-reports from F22 on master, missing java-1.7 dep. Change-Id: Ice7f405afb70a66575aaa47e25027752dd6cc4b9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 10 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice7f405afb70a66575aaa47e25027752dd6cc4b9 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0