July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: findbugs warning
by amureini＠redhat.com 22 Jul '15

22 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: findbugs warning ...................................................................... core: findbugs warning Fix findbugs warning resulting from a recent addition of exponential backoff to the CommandExecutor class. Change-Id: Ibae9da8ad479be440cfe96390349a07b4317e859 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae9da8ad479be440cfe96390349a07b4317e859 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: decrease idle time for multi-phase CoCo commands
by amureini＠redhat.com 21 Jul '15

21 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: decrease idle time for multi-phase CoCo commands ...................................................................... core: decrease idle time for multi-phase CoCo commands Commands with multiple phases such as Live Merge can spend a lot of time idling, waiting on state transitions or child commands. This patch changes the CommandExecutor to lower the wait time between invoking callbacks when certain state changes occur such as a command status change to successful/failed or upon child command completion. Change-Id: I22ad7df3e6f6b85a72170db1ccb4ebac655eb576 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22ad7df3e6f6b85a72170db1ccb4ebac655eb576 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: capped exponential backoff for CoCo CommandExecutor
by amureini＠redhat.com 21 Jul '15

21 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: capped exponential backoff for CoCo CommandExecutor ...................................................................... core: capped exponential backoff for CoCo CommandExecutor Some commands run by CoCo complete quickly and would benefit from faster polling; however, some may take longer to complete and polling too often consumes unnecessary CPU. This is a good use case for capped exponential backoff, which is implemented here purely in-memory. New commands will poll 1 second, doubling until reaching the AsyncCommandPollingRateInSeconds configuration value. Change-Id: Id89929ba0d8aa8e80ae358acbe7cc763a92be135 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 36 insertions(+), 8 deletions(-) Approvals: Greg Padgett: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id89929ba0d8aa8e80ae358acbe7cc763a92be135 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: set description for cinder disk snapshot
by derez＠redhat.com 21 Jul '15

21 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: set description for cinder disk snapshot ...................................................................... core: set description for cinder disk snapshot Set description for snapshot in createSnapshot method (CinderBroker). Change-Id: I8554ffec9341f34e5eea8c1756490fab6699065c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8554ffec9341f34e5eea8c1756490fab6699065c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm-jsonrpc-java: new repo required by slf4j
by dcaroest＠redhat.com 21 Jul '15

21 Jul '15

David Caro has submitted this change and it was merged. Change subject: vdsm-jsonrpc-java: new repo required by slf4j ...................................................................... vdsm-jsonrpc-java: new repo required by slf4j When we build vdsm-jsonrpc-java using slf4j we need 1.7+ version which is available in jpackage repo. Bug-Url: https://bugzilla.redhat.com/1243339 Change-Id: Ib4bc76b3d02b0118362e6be8b48753b5a25d0d27 Required-For: https://gerrit.ovirt.org/#/c/43775/ Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M jobs/confs/yaml/jobs/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me Jenkins CI: Passed CI tests David Caro: Ready for merge -- To view, visit https://gerrit.ovirt.org/43823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4bc76b3d02b0118362e6be8b48753b5a25d0d27 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: RadioboxCell - ensure onBrowserEvent invocation
by derez＠redhat.com 21 Jul '15

21 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: RadioboxCell - ensure onBrowserEvent invocation ...................................................................... webadmin: RadioboxCell - ensure onBrowserEvent invocation RadioboxCell- currently, onBrowserEvent method isn't invoked (which, for example, prevents FieldUpdater from updating...). Hence, added the default method signature of onBrowserEvent to ensure invocation. More specifically, this fix is required for the FieldUpdater of 'vmConfColumn' in VmSnapshotCustomPreviewPopupWidget. Change-Id: I9a3686a6513778e70c7029ff5c991304a0eee3e9 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/RadioboxCell.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a3686a6513778e70c7029ff5c991304a0eee3e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add frozen flag to VdsServer snapshot api
by derez＠redhat.com 21 Jul '15

21 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add frozen flag to VdsServer snapshot api ...................................................................... core: add frozen flag to VdsServer snapshot api Added 'frozen' boolean to 'snapshot' api in order to indicate whether the VM has been frozen. VDSM uses that information to decide if 'quiesce' flag should be sent to libvirt (see https://gerrit.ovirt.org/43293) Change-Id: I979659a744351b65362274b39027616dabfa099c Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 7 files changed, 51 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979659a744351b65362274b39027616dabfa099c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: certificate checker should start after ResourceManager
by masayag＠redhat.com 21 Jul '15

21 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: core: certificate checker should start after ResourceManager ...................................................................... core: certificate checker should start after ResourceManager Change-Id: I422a17db641c9427bf5eea9ac5d6ef5f16de6909 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422a17db641c9427bf5eea9ac5d6ef5f16de6909 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Extract startup recovery actions from ResourceManager
by masayag＠redhat.com 21 Jul '15

21 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Extract startup recovery actions from ResourceManager ...................................................................... core: Extract startup recovery actions from ResourceManager Extract startup recovery actions from ResourceManager. That fixes the circular dependency problem that is described in the bug. Change-Id: Ie3022029c1474581274549a1d6a5068059e9bd33 Bug-Url: https://bugzilla.redhat.com/1244718 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/startup/recovery/RecoveryStartupBean.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 2 files changed, 151 insertions(+), 55 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified; Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3022029c1474581274549a1d6a5068059e9bd33 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Bump RPM release number
by juan.hernandez＠redhat.com 21 Jul '15

21 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Bump RPM release number ...................................................................... cli: Bump RPM release number Change-Id: I4136f225a99dc25ac99efdd0803c54fb53b035c4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4136f225a99dc25ac99efdd0803c54fb53b035c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0