July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Delete VdcRole class which isn't in use
by oourfali＠redhat.com 21 Jul '15

21 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Delete VdcRole class which isn't in use ...................................................................... engine: Delete VdcRole class which isn't in use Change-Id: I32eea2c229f9a171bae0735f76354c32466fd68b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdcRole.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 2 files changed, 0 insertions(+), 35 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32eea2c229f9a171bae0735f76354c32466fd68b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove visibility modifier from interface
by oourfali＠redhat.com 21 Jul '15

21 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Remove visibility modifier from interface ...................................................................... engine: Remove visibility modifier from interface Change-Id: I45dd381b9a4e9d4a0e9f23bff0e4c3bee3f5a6c5 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartup.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45dd381b9a4e9d4a0e9f23bff0e4c3bee3f5a6c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: virtio drivers for windows guest conversion
by ahadas＠redhat.com 21 Jul '15

21 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: virtio drivers for windows guest conversion ...................................................................... core: virtio drivers for windows guest conversion When converting a guest that is installed with Windows, virt-v2v replace its drivers with virtio drivers. The user can select which virtio drivers to use from the iso-domain, and these drivers will be mounted before the conversion starts so virt-v2v will be able to use them. Change-Id: I4f77c0980d903061f20e03851eec5406ee181540 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromExternalProviderCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConvertVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromExternalProviderParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConvertVmVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConvertVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 7 files changed, 59 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/42258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f77c0980d903061f20e03851eec5406ee181540 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: OvfManagerTest fix
by shavivi＠redhat.com 20 Jul '15

20 Jul '15

Shahar Havivi has submitted this change and it was merged. Change subject: core: OvfManagerTest fix ...................................................................... core: OvfManagerTest fix Tests were failing if operating system was set to non-default value. Change-Id: I91cb2368ed04e413fa06d911117b64029d3b3dce Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91cb2368ed04e413fa06d911117b64029d3b3dce Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: rest: Catch IOExcetpion BackendApiResource
by amureini＠redhat.com 20 Jul '15

20 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: rest: Catch IOExcetpion BackendApiResource ...................................................................... rest: Catch IOExcetpion BackendApiResource Use the caught IOException in BackendApiResource#getSchema() to make FindBugs/Coverity happy. Change-Id: Ibb71d2adf17aaa792a09d391d0fda9ab558bb588 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb71d2adf17aaa792a09d391d0fda9ab558bb588 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: 1.0.11 version bump
by vfeenstr＠redhat.com 20 Jul '15

20 Jul '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: 1.0.11 version bump ...................................................................... 1.0.11 version bump Change-Id: I971363830f76f1022562ca6ed2801e515e62da2c Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ChangeLog M configure.ac M debian/changelog M debian/copyright M ovirt-guest-agent.rhel6.spec M ovirt-guest-agent.spec 6 files changed, 357 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I971363830f76f1022562ca6ed2801e515e62da2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: UI: New VM: vmId validation error.
by shavivi＠redhat.com 19 Jul '15

19 Jul '15

Shahar Havivi has submitted this change and it was merged. Change subject: UI: New VM: vmId validation error. ...................................................................... UI: New VM: vmId validation error. On creating a new VM and setting a wrong GUID for VM Id field (ie failed the validation for VM Id) the validation is not reset - hence giving a new valid/empty GUID the VM Id still marked as invalid. https://bugzilla.redhat.com/1242505 Change-Id: I3e99fc55da171bd2fb404565b709efff7af76301 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e99fc55da171bd2fb404565b709efff7af76301 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Missing breaks in VdsBrokerObjectsBuilder
by amureini＠redhat.com 19 Jul '15

19 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Missing breaks in VdsBrokerObjectsBuilder ...................................................................... core: Missing breaks in VdsBrokerObjectsBuilder This patch adds the missing break statements in VdsBrokerObjectsBuilder.buildDiskImagesFromDevices(Map<String, Object>). It fixed Coverity defect 1311881. Change-Id: Ib4d77b2253f4442523bd9ab7678fce3024e9d7d4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4d77b2253f4442523bd9ab7678fce3024e9d7d4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Documentation fix to S_S_C_Resource
by amureini＠redhat.com 19 Jul '15

19 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Documentation fix to S_S_C_Resource ...................................................................... restapi: Documentation fix to S_S_C_Resource Documentation for getStorageConnectionSubResource in StorageServerConnectionsResource, stated that @param id is the StorageDomain's id- when actually it is the server connection id. Change-Id: I78a76b3f5886b3cd984092fc94e774b8115c60e6 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/43804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78a76b3f5886b3cd984092fc94e774b8115c60e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Modifiers for TestStorageHandlingCommandBase
by amureini＠redhat.com 19 Jul '15

19 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Modifiers for TestStorageHandlingCommandBase ...................................................................... core: Modifiers for TestStorageHandlingCommandBase Fixed modifiers for TestStorageHandlingCommandBase, as per Coverity defect CID 1311876. Change-Id: I8948caee30417b3d28f344734e35d737e66475fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8948caee30417b3d28f344734e35d737e66475fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0