August 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: fix actual size of imported disks using v2v

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: fix actual size of imported disks using v2v ...................................................................... core: fix actual size of imported disks using v2v The actual size of disks that are imported using virt-v2v (for now the sources can be either VMware or OVA file), is reported from VDSM in bytes, therefore DiskImage#setActualSizeInBytes should be used. Change-Id: Iaa20122ae716db01ca16fff28ea8fdba6fcac70d Bug-Url: https://bugzilla.redhat.com/1236075 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa20122ae716db01ca16fff28ea8fdba6fcac70d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: sercon: minor ovirt-vmconsole-list.py cleanups

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: sercon: minor ovirt-vmconsole-list.py cleanups ...................................................................... sercon: minor ovirt-vmconsole-list.py cleanups - add debug command line option - leverage ovirt-configured logging - use specific logger: was using top level logger (logging.something()) because of a typo. - make sure we close the file-like returned by urllib2. - make sure to logs exceptions on syslog Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py 1 file changed, 37 insertions(+), 18 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/44176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: cancel vm conversion

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: cancel vm conversion ...................................................................... webadmin: cancel vm conversion Change-Id: I27cdefc477530c9033e4f8cc54e482ff6d07eda8 Bug-Url: https://bugzilla.redhat.com/1236075 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 3 files changed, 46 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27cdefc477530c9033e4f8cc54e482ff6d07eda8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: spec: vmconsole setup plugin needs the engine's

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: packaging: spec: vmconsole setup plugin needs the engine's ...................................................................... packaging: spec: vmconsole setup plugin needs the engine's For now at least, until we one day make it independent. So require it. Bug-Url: https://bugzilla.redhat.com/1236571 Change-Id: I58e74e0a635675bf7148935edf986ab5f87e3c0f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44761 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58e74e0a635675bf7148935edf986ab5f87e3c0f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: spec: vmconsole setup plugin needs the engine's

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: vmconsole setup plugin needs the engine's ...................................................................... packaging: spec: vmconsole setup plugin needs the engine's For now at least, until we one day make it independent. So require it. Bug-Url: https://bugzilla.redhat.com/1236571 Change-Id: I58e74e0a635675bf7148935edf986ab5f87e3c0f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58e74e0a635675bf7148935edf986ab5f87e3c0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: NetworkValidatorTest members modifiers

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: NetworkValidatorTest members modifiers ...................................................................... core: NetworkValidatorTest members modifiers Made constant strings and private utility methods static, as per proper Java conventions. Change-Id: I23fcb2466a603740528b210d142abb97a91b27a5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23fcb2466a603740528b210d142abb97a91b27a5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VmInterfaceManagerTest members modifiers

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmInterfaceManagerTest members modifiers ...................................................................... core: VmInterfaceManagerTest members modifiers Made constant strings and private utility methods static, as per proper Java conventions. Change-Id: I2d46116edc0d318228608cfdc2e9ed3b3fd3714e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d46116edc0d318228608cfdc2e9ed3b3fd3714e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: VnicProfileValidatorTest members modifiers

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: VnicProfileValidatorTest members modifiers ...................................................................... core: VnicProfileValidatorTest members modifiers Made constant strings and private utility methods static, as per proper Java conventions. Change-Id: Ide7e4933b8dff36dd924cae3c535f2a9c8c616be Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide7e4933b8dff36dd924cae3c535f2a9c8c616be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: XmlRpcStringUtilsTest assertions

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: XmlRpcStringUtilsTest assertions ...................................................................... core: XmlRpcStringUtilsTest assertions Flipped the direction of the assertEquals call to be the proper direction in order to get the right output if one of these tests fails. Change-Id: If8b097051949fe939b3c6d3cad076f195ba693f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcStringUtilsTest.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8b097051949fe939b3c6d3cad076f195ba693f5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: IPAddressPatternTest modifiers

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: IPAddressPatternTest modifiers ...................................................................... core: IPAddressPatternTest modifiers Made private utility classes static, as per proper Java conventions. Change-Id: Ic454eeeb2adbc5c01fe5ae451910e60a20820801 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/44519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic454eeeb2adbc5c01fe5ae451910e60a20820801 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 5 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits August 2015