November 2016 - Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Disable verify on refs/meta/config branch
by Code Review 14 Nov '16

14 Nov '16

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Disable verify on refs/meta/config branch ...................................................................... Disable verify on refs/meta/config branch The current setting in the hook is to grade (verify -1) stable branches if there are no bug-url found, but it catch also refs/meta/config or meta/config branches (that should be ignored). Change-Id: I6a265b78a06b4ecc7c5dd9ecfc380c491873107d Fixes: OVIRT-838 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_bug_url 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shlomo Ben David: Verified; Passed CI tests Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a265b78a06b4ecc7c5dd9ecfc380c491873107d Gerrit-PatchSet: 2 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove vm guest agent interfaces in a single query
by Code Review 14 Nov '16

14 Nov '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove vm guest agent interfaces in a single query ...................................................................... core: remove vm guest agent interfaces in a single query The monitoring aggregates the changed VM guest agent interfaces but then iterates over all the VMs with changed interfaces and remove their interfaces one-by-one. Interacting with the DB within loop has never been a best-practice. This patch changes the removal of VM guest agent interfaces so they will be removed for all the given VMs in a single query. Note that while a better solution would be to have some kind of identifier for raws in vm_guest_agent_interfaces (and then we won't need to remove and add all the interfaces on every change) seems possible, this is a less-risky change that can be backported. Change-Id: I89e89a116b9247171e7708704b14c2b8c7b41943 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M packaging/dbscripts/network_sp.sql 5 files changed, 18 insertions(+), 16 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/65860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89e89a116b9247171e7708704b14c2b8c7b41943 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllJobsQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllJobsQuery Daos ...................................................................... core: @Inject GetAllJobsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I097cff1d18b448ecfc8e99b639e29277ab16c8f8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllJobsQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I097cff1d18b448ecfc8e99b639e29277ab16c8f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllHostsQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllHostsQuery Daos ...................................................................... core: @Inject GetAllHostsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I516bb042ba9aef6b0ed4826cb41814ab7d863da1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllHostsQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I516bb042ba9aef6b0ed4826cb41814ab7d863da1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllHostNamesPinnedToVmByIdQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllHostNamesPinnedToVmByIdQuery Daos ...................................................................... core: @Inject GetAllHostNamesPinnedToVmByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: If5d0fdf0470e2a2805b55c54c9239840fc524eb6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllHostNamesPinnedToVmByIdQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5d0fdf0470e2a2805b55c54c9239840fc524eb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllEventMessagesQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllEventMessagesQuery Daos ...................................................................... core: @Inject GetAllEventMessagesQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I17b9705caa645b0df23b149e8a51f712bd2d26f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllEventMessagesQuery.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17b9705caa645b0df23b149e8a51f712bd2d26f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllClustersQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllClustersQuery Daos ...................................................................... core: @Inject GetAllClustersQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Icaa270f91214755da376a82a5e2a55a9ac5a53f9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllClustersQuery.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaa270f91214755da376a82a5e2a55a9ac5a53f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllBookmarksQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllBookmarksQuery Daos ...................................................................... core: @Inject GetAllBookmarksQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I1e62184652139372043036dd8672667ace497f7f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllBookmarksQuery.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e62184652139372043036dd8672667ace497f7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllAuditLogsByVMTemplateIdQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllAuditLogsByVMTemplateIdQuery Daos ...................................................................... core: @Inject GetAllAuditLogsByVMTemplateIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Iaea07c1aa029844c08d87429d540fe0ca151b49b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMTemplateIdQueryTest.java 2 files changed, 10 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaea07c1aa029844c08d87429d540fe0ca151b49b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllAuditLogsByVMIdQuery Daos
by Code Review 14 Nov '16

14 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllAuditLogsByVMIdQuery Daos ...................................................................... core: @Inject GetAllAuditLogsByVMIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I28a10c5992d9188e7b972093e3381a1dbc3e71c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllAuditLogsByVMIdQueryTest.java 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28a10c5992d9188e7b972093e3381a1dbc3e71c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0