November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: @Inject GetAllStoragePoolsQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllStoragePoolsQuery Daos ...................................................................... core: @Inject GetAllStoragePoolsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ie0fd43bda0fa43c060f035e92f433cfdc9b961f2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetAllStoragePoolsQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0fd43bda0fa43c060f035e92f433cfdc9b961f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetUnregisteredEntitiesQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetUnregisteredEntitiesQuery Daos ...................................................................... core: @Inject GetUnregisteredEntitiesQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I721081c99d0b68bd07cc9a9dc481967be1ff4e50 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredEntitiesQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQueryTest.java 3 files changed, 10 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I721081c99d0b68bd07cc9a9dc481967be1ff4e50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetStoragePoolByIdQueryTest injections
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetStoragePoolByIdQueryTest injections ...................................................................... core: GetStoragePoolByIdQueryTest injections Inject the @Mock daos instead of reinventing the wheel and explicitly setting the DAOs in the qurey under test. Change-Id: Id4ab5da5d074b4ee9e18942b62a05b6af1134e8c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQueryTest.java 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ab5da5d074b4ee9e18942b62a05b6af1134e8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetImagesListByStoragePoolIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetImagesListByStoragePoolIdQuery Daos ...................................................................... core: @Inject GetImagesListByStoragePoolIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ie5f4d73f1b17d74e7824f634ee1b1344a774ec7b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/GetImagesListByStoragePoolIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/GetImagesListByStoragePoolIdQueryTest.java 2 files changed, 17 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5f4d73f1b17d74e7824f634ee1b1344a774ec7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAvailableStoragePoolVersionsQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAvailableStoragePoolVersionsQuery Daos ...................................................................... core: @Inject GetAvailableStoragePoolVersionsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I00682417d22f387d57e63eb4dce546587cb86261 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetAvailableStoragePoolVersionsQuery.java 1 file changed, 13 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00682417d22f387d57e63eb4dce546587cb86261 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetExistingStorageDomainListQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetExistingStorageDomainListQuery Daos ...................................................................... core: @Inject GetExistingStorageDomainListQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ieda5de830d23449d52ecfcb33635020a3d0db5f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetExistingStorageDomainListQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieda5de830d23449d52ecfcb33635020a3d0db5f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetPermittedStorageDomainsByStoragePoolIdQuery...
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetPermittedStorageDomainsByStoragePoolIdQuery Daos ...................................................................... core: @Inject GetPermittedStorageDomainsByStoragePoolIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I2f7a061bcfad1ca2ccd28c3fb8e6faebb6d6e918 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetPermittedStorageDomainsByStoragePoolIdQuery.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f7a061bcfad1ca2ccd28c3fb8e6faebb6d6e918 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetStorageDomainsByVmTemplateIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetStorageDomainsByVmTemplateIdQuery Daos ...................................................................... core: @Inject GetStorageDomainsByVmTemplateIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ifc4159f698fceb89fb323f29f03a4d7997f62cc9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsByVmTemplateIdQuery.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc4159f698fceb89fb323f29f03a4d7997f62cc9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetUnregisteredBlockStorageDomainsQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetUnregisteredBlockStorageDomainsQuery Daos ...................................................................... core: @Inject GetUnregisteredBlockStorageDomainsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I055dec5fa07107293d59421d2d04df92cd87d826 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQueryTest.java 2 files changed, 9 insertions(+), 32 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055dec5fa07107293d59421d2d04df92cd87d826 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllStorageDomainsQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllStorageDomainsQuery Daos ...................................................................... core: @Inject GetAllStorageDomainsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I32aa4ba2a70302bbdaac9667cebbf7691ce1df64 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetAllStorageDomainsQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32aa4ba2a70302bbdaac9667cebbf7691ce1df64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0