November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetLunsByVgIdQuery#getLunsForVgId param
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQuery#getLunsForVgId param ...................................................................... core: GetLunsByVgIdQuery#getLunsForVgId param Use the vgId passed to the method instead of just assuming getVgId(). This has no functional benefit, as CURRENTLY the only place that uses this method passes getVgId(), but it is more correct, and will prevent hard-to-find bugs in the future. Change-Id: I52a331e8582e6a40a354b0b40a62ba120fec314e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52a331e8582e6a40a354b0b40a62ba120fec314e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetDeviceListQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetDeviceListQuery Daos ...................................................................... core: @Inject GetDeviceListQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I3b8f0338cd55592eb92f577afa229a86c3bead00 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/lun/GetDeviceListQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/lun/GetDeviceListQueryTest.java 2 files changed, 10 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8f0338cd55592eb92f577afa229a86c3bead00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetUnregisteredDisksQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetUnregisteredDisksQuery Daos ...................................................................... core: @Inject GetUnregisteredDisksQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I522d0b7f8b397aa916e5b65f8a613dea0ad94759 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQueryTest.java 2 files changed, 22 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I522d0b7f8b397aa916e5b65f8a613dea0ad94759 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetUnregisteredDisksFromDBQuery dao accessors
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredDisksFromDBQuery dao accessors ...................................................................... core: GetUnregisteredDisksFromDBQuery dao accessors Clean up the redundant DAO accessors and use dependency injection to inject the relevant DAO to the tested query. Change-Id: Ia779dccc32cbfca69179c94cb67030829136965f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksFromDBQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksFromDBQueryTest.java 2 files changed, 1 insertion(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia779dccc32cbfca69179c94cb67030829136965f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetUnregisteredDiskQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetUnregisteredDiskQuery Daos ...................................................................... core: @Inject GetUnregisteredDiskQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ib24c68c8a66c3228e16733e6f79098a791a349f3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDiskQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib24c68c8a66c3228e16733e6f79098a791a349f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAncestorImagesByImagesIdsQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAncestorImagesByImagesIdsQuery Daos ...................................................................... core: @Inject GetAncestorImagesByImagesIdsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I76e073c3fbc9cf18959e15201453359c9016ef6e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetAncestorImagesByImagesIdsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/GetAncestorImagesByImagesIdsQueryTest.java 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76e073c3fbc9cf18959e15201453359c9016ef6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllDisksByStorageDomainIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllDisksByStorageDomainIdQuery Daos ...................................................................... core: @Inject GetAllDisksByStorageDomainIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ic140917594ef9248cdabdb05ad45f6eeb8f28810 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetAllDisksByStorageDomainIdQuery.java 1 file changed, 12 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic140917594ef9248cdabdb05ad45f6eeb8f28810 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetUnregisteredCinderDisksByStorageDomainIdQue...
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetUnregisteredCinderDisksByStorageDomainIdQuery Daos ...................................................................... core: @Inject GetUnregisteredCinderDisksByStorageDomainIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I3c3c9a0a644e564f2fdde08bbd609d6f1c8015e8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDisksByStorageDomainIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDisksByStorageDomainIdQueryTest.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c3c9a0a644e564f2fdde08bbd609d6f1c8015e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetUnregisteredCinderDiskByIdAndStorageDomainI...
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetUnregisteredCinderDiskByIdAndStorageDomainIdQuery Daos ...................................................................... core: @Inject GetUnregisteredCinderDiskByIdAndStorageDomainIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I027d8adaee8eeedcfb473104bffdf3ea4e34252e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDiskByIdAndStorageDomainIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I027d8adaee8eeedcfb473104bffdf3ea4e34252e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetLibvirtSecretByIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetLibvirtSecretByIdQuery Daos ...................................................................... core: @Inject GetLibvirtSecretByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I37ce03a16b80dd9b20e57220df41dd0e51ca27e6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetLibvirtSecretByIdQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37ce03a16b80dd9b20e57220df41dd0e51ca27e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0