November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: @Inject GetNextAvailableDiskAliasNameByVMIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetNextAvailableDiskAliasNameByVMIdQuery Daos ...................................................................... core: @Inject GetNextAvailableDiskAliasNameByVMIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ic452e30647c000a54ef8eaf123769f7e0a9b04bf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetNextAvailableDiskAliasNameByVMIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/GetNextAvailableDiskAliasNameByVMIdQueryTest.java 2 files changed, 12 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic452e30647c000a54ef8eaf123769f7e0a9b04bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetStorageServerConnectionExtensionsByHostIdQu...
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetStorageServerConnectionExtensionsByHostIdQuery Daos ...................................................................... core: @Inject GetStorageServerConnectionExtensionsByHostIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ie6fcac49841052f7ae1ab77b581b228c08052d81 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionExtensionsByHostIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6fcac49841052f7ae1ab77b581b228c08052d81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetStorageServerConnectionExtensionByIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetStorageServerConnectionExtensionByIdQuery Daos ...................................................................... core: @Inject GetStorageServerConnectionExtensionByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Iee586c3255139dcb32ad78dc2f66ef4be3f484e6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionExtensionByIdQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee586c3255139dcb32ad78dc2f66ef4be3f484e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetStorageServerConnectionByIscsiBondIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetStorageServerConnectionByIscsiBondIdQuery Daos ...................................................................... core: @Inject GetStorageServerConnectionByIscsiBondIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I707f3bcf0bc3aea21cddf8c85b4287faf2b333a4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionByIscsiBondIdQuery.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I707f3bcf0bc3aea21cddf8c85b4287faf2b333a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetConnectionsByDataCenterAndStorageTypeQuery ...
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetConnectionsByDataCenterAndStorageTypeQuery Daos ...................................................................... core: @Inject GetConnectionsByDataCenterAndStorageTypeQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ic3b5bb69a2036346432216a3e28152881e6c5c0d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetConnectionsByDataCenterAndStorageTypeQuery.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3b5bb69a2036346432216a3e28152881e6c5c0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetAllStorageServerConnectionsQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetAllStorageServerConnectionsQuery Daos ...................................................................... core: @Inject GetAllStorageServerConnectionsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ia62c87cea043af210a80e781d8bb0445d26fed53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetAllStorageServerConnectionsQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia62c87cea043af210a80e781d8bb0445d26fed53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetIscsiBondsByStoragePoolIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetIscsiBondsByStoragePoolIdQuery Daos ...................................................................... core: @Inject GetIscsiBondsByStoragePoolIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I3ace3b475d24c6e3fc7201c303d76f1d6a65c9f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondsByStoragePoolIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondsByStoragePoolIdQueryTest.java 2 files changed, 12 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ace3b475d24c6e3fc7201c303d76f1d6a65c9f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetIscsiBondByIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetIscsiBondByIdQuery Daos ...................................................................... core: @Inject GetIscsiBondByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I826d290f5c4508b3c77dad9e227593cdeabbc353 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondByIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/GetIscsiBondByIdQueryTest.java 2 files changed, 8 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I826d290f5c4508b3c77dad9e227593cdeabbc353 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetStorageServerConnectionByIdQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetStorageServerConnectionByIdQuery Daos ...................................................................... core: @Inject GetStorageServerConnectionByIdQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I1d783c4336da4a07ce822871daeea86da3a78693 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionByIdQuery.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d783c4336da4a07ce822871daeea86da3a78693 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject GetStorageServerConnectionsForDomainQuery Daos
by Code Review 13 Nov '16

13 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject GetStorageServerConnectionsForDomainQuery Daos ...................................................................... core: @Inject GetStorageServerConnectionsForDomainQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: Ib86b7abb0beca9ceb452cf8164ae0012526442f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetStorageServerConnectionsForDomainQuery.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86b7abb0beca9ceb452cf8164ae0012526442f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0