Change in ovirt-engine[master]: core: Move disk loading in AttachDiskToVmCommand to init part
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Move disk loading in AttachDiskToVmCommand to init part
......................................................................
core: Move disk loading in AttachDiskToVmCommand to init part
Using database operations in a class constructor is a bad practice, moved
the disk loading part in AttachDiskToVmCommand which is needed for the
lock map to the init part which runs before the initialize of the lock map
Change-Id: I979e57d64b9f21fcbdd8e543defc03e9461f1a1a
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommandTest.java
2 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I979e57d64b9f21fcbdd8e543defc03e9461f1a1a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in jenkins[master]: moving ng node jobs to fc23 slaves
by tlitovsk＠redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: moving ng node jobs to fc23 slaves
......................................................................
moving ng node jobs to fc23 slaves
Change-Id: I05c4a2f6b2e4d765a167433593e1e1ed8242bb82
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Looks good to me
Anatoly Litovsky: Verified; Ready for merge
--
To view, visit https://gerrit.ovirt.org/55480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05c4a2f6b2e4d765a167433593e1e1ed8242bb82
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: webadmin: cluster popup update
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: cluster popup update
......................................................................
webadmin: cluster popup update
- Made cluster edit/new popup more consistent looking
- Use boostrap grid system to lay out widgets.
- Added patternfly option to EntityModelWidgetWithInfo
- Added patternfly option to KeyValueLineWidget
Change-Id: I4c7d3044a77a50d6eecd20e2d0c76d490ade0091
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1267259
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelRadioGroupEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/RadioGroup.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelRadioButtonEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
14 files changed, 420 insertions(+), 309 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/55417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c7d3044a77a50d6eecd20e2d0c76d490ade0091
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[ovirt-engine-3.6]: core: adding support for ilo_ssh fence agent
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: adding support for ilo_ssh fence agent
......................................................................
core: adding support for ilo_ssh fence agent
This patch adds support for ilo_ssh fence agent.
Change-Id: I110a444f1f25fbbac0ca9a1d13aa80db376506bf
Bug-Url: https://bugzilla.redhat.com/1316583
Signed-off-by: emesika <emesika(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I110a444f1f25fbbac0ca9a1d13aa80db376506bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-release[master]: pull python34-* from epel7
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: pull python34-* from epel7
......................................................................
pull python34-* from epel7
A recent Vdsm commit required these packages. It seems that they have to
be explictly included here as well.
Change-Id: If3a3598f70c54bc481734b7050e3fb167830257b
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M ovirt-el7-deps.repo.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified
--
To view, visit https://gerrit.ovirt.org/55415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3a3598f70c54bc481734b7050e3fb167830257b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-reports[ovirt-engine-reports-3.6]: build: after build reports for 3.6.5
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: build: after build reports for 3.6.5
......................................................................
build: after build reports for 3.6.5
Change-Id: I0bdd63b17e8756a15804ea1c80961c0b148a8bba
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bdd63b17e8756a15804ea1c80961c0b148a8bba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.6
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-reports[ovirt-engine-reports-3.6]: build: build reports for 3.6.5
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: build: build reports for 3.6.5
......................................................................
build: build reports for 3.6.5
Change-Id: Ie2099ad15eb7095e790c19cc2c2daa33b020ba21
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55470
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2099ad15eb7095e790c19cc2c2daa33b020ba21
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.6
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[ovirt-engine-3.6.5]: packaging: spec: Fix deps for ovirt-engine-tools-backup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: spec: Fix deps for ovirt-engine-tools-backup
......................................................................
packaging: spec: Fix deps for ovirt-engine-tools-backup
Allow upgrading setup packages even when tools-backup is indirectly
versionlocked by a previous setup.
Change-Id: I2772037157f2f1ba77b3be96c6375558fe3d6582
Bug-Url: https://bugzilla.redhat.com/1321249
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/55385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2772037157f2f1ba77b3be96c6375558fe3d6582
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[ovirt-engine-3.6.5]: webadmin: Fix name of notifier service
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix name of notifier service
......................................................................
webadmin: Fix name of notifier service
Fixes name of ovirt-engine-notifier service.
Change-Id: I58cda9591b782169a3c4df0f1134782a3a204f5b
Bug-Url: https://bugzilla.redhat.com/1321583
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58cda9591b782169a3c4df0f1134782a3a204f5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Give newest host OS versions the best weight on V...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: scheduler: Give newest host OS versions the best weight on VM startup
......................................................................
scheduler: Give newest host OS versions the best weight on VM startup
During cluster upgrade, when a VM is started the cluster upgrade weight
policy will detect the hosts with the newest major OS version and give
them the best weight possible. All other hosts will get the worst
weight.
Change-Id: I2454fdf5584fa3e16160f54335faa3973c2dabf5
Bug-Url: https://bugzilla.redhat.com/1241149
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnitTest.java
2 files changed, 68 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roman Mohr: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54869
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2454fdf5584fa3e16160f54335faa3973c2dabf5
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months