February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix wrong messages in run vm unit tests
by Code Review 20 Feb '17

20 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: fix wrong messages in run vm unit tests ...................................................................... core: fix wrong messages in run vm unit tests Expected values should come before the actual values. Change-Id: I1cc82c5db44b00176f841000a03e1dd0661b6baf Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/72653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cc82c5db44b00176f841000a03e1dd0661b6baf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add unit tests for max vCPU count computation
by Code Review 20 Feb '17

20 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Add unit tests for max vCPU count computation ...................................................................... core: Add unit tests for max vCPU count computation Change-Id: I3101bb83dcee2e690dccdbd4e46450123c1cdf84 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmCpuCountHelperTest.java 2 files changed, 111 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/72210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3101bb83dcee2e690dccdbd4e46450123c1cdf84 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: eliminate uninformative warnings in the domxml builder
by Code Review 20 Feb '17

20 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: eliminate uninformative warnings in the domxml builder ...................................................................... core: eliminate uninformative warnings in the domxml builder By using the relevant annotations. Change-Id: Ibe460b2656c50f2f0ab931e6ac85d341b96dcf13 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/72645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe460b2656c50f2f0ab931e6ac85d341b96dcf13 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix chrome drag NPE
by Code Review 20 Feb '17

20 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fix chrome drag NPE ...................................................................... webadmin: Fix chrome drag NPE Change-Id: Ib789cfd8bf75c2522534b1692056db45b2bb3e11 Bug-Url: https://bugzilla.redhat.com/1421973 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib789cfd8bf75c2522534b1692056db45b2bb3e11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Adjust the limit on max VCPUs
by Code Review 20 Feb '17

20 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Adjust the limit on max VCPUs ...................................................................... core: Adjust the limit on max VCPUs The maximum number of VCPUs must be multiplication of sockets * cores. This is ensured by the formula computing the maximum number of VCPUs, but the configuration value may not satisfy that constraint. So if we are limited by the configuration value then we must check and adjust that value. This is mostly theoretical in 4.1+ since the current configuration value (288) is higher than the APIC limit (255) so it should cause no trouble in the default 4.1 configuration. Change-Id: I857e1a85950a863752e02a30066f682fff04a7c7 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/72378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I857e1a85950a863752e02a30066f682fff04a7c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: OVIRT-1017 use new SQUID proxy in mock
by Code Review 19 Feb '17

19 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: OVIRT-1017 use new SQUID proxy in mock ...................................................................... OVIRT-1017 use new SQUID proxy in mock This patch changes the proxy URL used inside mock: from proxy.phx.ovirt.org (Fedora 20, to be decommissioned) to proxy01.phx.ovirt.org (CentOS 7) Change-Id: I976d78553f8fbc9bc9b519d20a821857177f7bea Signed-off-by: Evgheni Dereveanchin <ederevea(a)redhat.com> --- M mock_configs/epel-6-x86_64_proxied.cfg M mock_configs/epel-7-ppc64le_proxied.cfg M mock_configs/epel-7-x86_64_proxied.cfg M mock_configs/fedora-23-x86_64_proxied.cfg M mock_configs/fedora-24-ppc64le_proxied.cfg M mock_configs/fedora-24-x86_64_proxied.cfg M mock_configs/fedora-25-ppc64le_proxied.cfg M mock_configs/fedora-25-x86_64_proxied.cfg M mock_configs/mock_genconfig 9 files changed, 16 insertions(+), 16 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests Evgheni Dereveanchin: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/72457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I976d78553f8fbc9bc9b519d20a821857177f7bea Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: db: memory_and_disk_images_storage_domain_view - EXISTS inst...
by Code Review 19 Feb '17

19 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN ...................................................................... db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN Change Ifbedd49da added indexes and changed the memory_and_disk_images_storage_domain_view view to use JOIN instead of EXISTS to determine if the disk is a memory disk/ovf store. On certain datasets and under load that causes postgres to execute the query slower. As we yet to find a case in which using EXISTS for those tables causes to a problem, this patch restores the use of it in the view. Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e Bug-Url: https://bugzilla.redhat.com/1412626 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/72412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: remove the ProductKey section if product key is not pr...
by Code Review 19 Feb '17

19 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: remove the ProductKey section if product key is not provided ...................................................................... core: remove the ProductKey section if product key is not provided The reason is that the sysprep operation fails if the product key is empty. Change-Id: I70c8bb82d28c20d338a0b04466a5e200fc558194 Bug-Url: https://bugzilla.redhat.com/1419562 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> (cherry picked from commit 63262640829d5f3c242dfc15c0f788fe904eccd7) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 2 files changed, 84 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70c8bb82d28c20d338a0b04466a5e200fc558194 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: virtio-scsi is not copied on new template
by Code Review 19 Feb '17

19 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: virtio-scsi is not copied on new template ...................................................................... webadmin: virtio-scsi is not copied on new template When creating a template from VM which has virtio scsi enabled, this flag is not copied to the template. Fixed by properly initing it. Change-Id: I9f269fa447b800eadccd40e923210cf67b4677ce Bug-Url: https://bugzilla.redhat.com/1422374 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VirtioScsiUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f269fa447b800eadccd40e923210cf67b4677ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: use insertion-query from ovirt-js-depe...
by Code Review 17 Feb '17

17 Feb '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: use insertion-query from ovirt-js-dependencies ...................................................................... userportal, webadmin: use insertion-query from ovirt-js-dependencies Change-Id: I36f18abea4f152f0709ef4f9522c17976c6e9241 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag D packaging/branding/ovirt.brand/insQ-1.0.3.min.js 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/72228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36f18abea4f152f0709ef4f9522c17976c6e9241 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0