February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[sdk_4.1]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: I796927b6f694caf20ffcac6b6f49ba490abc10a3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 39101ffef5fdc211247ea80b4312e9699568d710) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddBond.java 1 file changed, 100 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I796927b6f694caf20ffcac6b6f49ba490abc10a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Fix writing of lists of structs
by Code Review 17 Feb '17

17 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix writing of lists of structs ...................................................................... Fix writing of lists of structs Currently when the type of an attribute is a list of structs, the SDK generates the XML using the name of the attribute as the tag for the list, and the same name in singular as the tag for the elements. For example, for the Bonding.slaves attribute it generates the following: <bonding> <slaves> <slave> <name>eth0</name> </slave> <slave> <name>eth1</name> </slave> </slaves> </bonding> But the server expects the name of the type of the element: <bonding> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> Note the use of 'host_nic' instead of 'slave'. The behaviour of the SDK is conceptually more correct than the behaviour of the server, but as we need to support the existing server, without changes, we need to fix the SDK instead. Change-Id: I98722ac732e1fd6a5e2212138890639e6784e5d6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 3ba240f0c3f456d4ae81da9939fdbb314fa40eed) --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/spec/bonding_writer_spec.rb 2 files changed, 55 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98722ac732e1fd6a5e2212138890639e6784e5d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: db: memory_and_disk_images_storage_domain_view - EXISTS inst...
by Code Review 17 Feb '17

17 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN ...................................................................... db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN Change Ifbedd49da added indexes and changed the memory_and_disk_images_storage_domain_view view to use JOIN instead of EXISTS to determine if the disk is a memory disk/ovf store. On certain datasets and under load that causes postgres to execute the query slower. As we yet to find a case in which using EXISTS for those tables causes to a problem, this patch restores the use of it in the view. Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e Bug-Url: https://bugzilla.redhat.com/1412626 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/72406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: remove pool when last VM detached
by Code Review 17 Feb '17

17 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: remove pool when last VM detached ...................................................................... core: remove pool when last VM detached Change-Id: I85c319b492d88ec2f864c6746ffd6afe8469dd0d Bug-Url: https://bugzilla.redhat.com/1419520 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85c319b492d88ec2f864c6746ffd6afe8469dd0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Validate fence agent type upon creation/update
by Code Review 17 Feb '17

17 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Validate fence agent type upon creation/update ...................................................................... core: Validate fence agent type upon creation/update Check if fence agent type is valid for the host upon creation/update of fence agent. Checks are based on valid fence agent types per cluster level, which the host is part of. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1420302 Change-Id: Iecda6f02f96c6696ba01421857db05a32d8a3871 Signed-off-by: Aleksei Slaikovskii <aslaikov(a)redhat.com> (cherry picked from commit 0ce5b2e5c89d4f38c049ef88e14f0fdc21e04da6) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddFenceAgentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateFenceAgentCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/FenceConfigHelper.java 3 files changed, 67 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Aleksei Slaikovskii: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecda6f02f96c6696ba01421857db05a32d8a3871 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Fix installing logutils.jar
by Code Review 17 Feb '17

17 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix installing logutils.jar ...................................................................... core: Fix installing logutils.jar Downstream build doesn't properly work with non-versioned artifacts, so we need to switch back to generating logutils JAR with version and then remove the version when copying the JAR into final destination. Change-Id: Ic40449341c9738010cedec32a51eb6d85384dd0c Bug-Url: https://bugzilla.redhat.com/1408193 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M backend/manager/logutils/pom.xml 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic40449341c9738010cedec32a51eb6d85384dd0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.4.3
by Code Review 17 Feb '17

17 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.0.4.3 ...................................................................... build: ovirt-hosted-engine-setup-2.0.4.3 Change-Id: I8cecc29a63bb31053efe0055c5c8ae05b8e959bf Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cecc29a63bb31053efe0055c5c8ae05b8e959bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.4.3
by Code Review 17 Feb '17

17 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.4.3 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.4.3 Change-Id: Id9398c5e0f6db76fa535f01bda5463b6cdb5d8de Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9398c5e0f6db76fa535f01bda5463b6cdb5d8de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: fixing bad permissions on answer file from the past
by Code Review 17 Feb '17

17 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: fixing bad permissions on answer file from the past ...................................................................... packaging: fixing bad permissions on answer file from the past answers.conf is in the configuration volume on the shared storage since 3.6 while it was just a local file before. The 3.5 -> 3.6 upgrade procedure is able to move it to the shared storage but it runs in ovirt-ha-agent deamon as vdsm user so answers.conf should be readable by vdsm user. Bug-Url: https://bugzilla.redhat.com/1422962 Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: I796927b6f694caf20ffcac6b6f49ba490abc10a3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddBond.java 1 file changed, 100 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I796927b6f694caf20ffcac6b6f49ba490abc10a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0