February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: virtio-scsi is not copied on new template
by Code Review 17 Feb '17

17 Feb '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: webadmin: virtio-scsi is not copied on new template ...................................................................... webadmin: virtio-scsi is not copied on new template When creating a template from VM which has virtio scsi enabled, this flag is not copied to the template. Fixed by properly initing it. Change-Id: I9f269fa447b800eadccd40e923210cf67b4677ce Bug-Url: https://bugzilla.redhat.com/1422374 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VirtioScsiUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f269fa447b800eadccd40e923210cf67b4677ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-node-ng: drop 4.0 pre
by Code Review 17 Feb '17

17 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-node-ng: drop 4.0 pre ...................................................................... ovirt-node-ng: drop 4.0 pre There won't be any more 4.0 releases so there won't be a 4.0 pre release repo. Dropping Change-Id: I2b14e49ba6d98cad62eefe33b7758fe537508517 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b14e49ba6d98cad62eefe33b7758fe537508517 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: appliance: drop 4-0-pre
by Code Review 17 Feb '17

17 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: appliance: drop 4-0-pre ...................................................................... appliance: drop 4-0-pre there won't be any more 4.0 releases so there won't be a pre-release repo. Dropping. Change-Id: I8ca5398c859e0b56f4de64642798131d79131cc9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ca5398c859e0b56f4de64642798131d79131cc9 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher: 4.1: fix pppc64le for python sdk
by Code Review 17 Feb '17

17 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: publisher: 4.1: fix pppc64le for python sdk ...................................................................... publisher: 4.1: fix pppc64le for python sdk Change-Id: I1599197016bfe0dbaa96f0a740c87fba3ba3ad39 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1599197016bfe0dbaa96f0a740c87fba3ba3ad39 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: python-ovirt-engine-sdk4: add ppc64le builds
by Code Review 17 Feb '17

17 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: python-ovirt-engine-sdk4: add ppc64le builds ...................................................................... python-ovirt-engine-sdk4: add ppc64le builds Add ppc64le builds for python-ovirt-engine-sdk4 Dropping ppc64le builds for ovirt-engine-sdk-python being noarch and already built by x86_64 jobs Change-Id: Ie9934ea9c7a27b60c94d988c1cec54a9e157f8e1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 20 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests; Ready for merge Juan Hernandez: Looks good to me Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9934ea9c7a27b60c94d988c1cec54a9e157f8e1 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Deploy documentation to github pages
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Deploy documentation to github pages ...................................................................... Deploy documentation to github pages Change-Id: I79b72ac0f9f836a50c306c046aab19ff238fac33 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M .travis.yml A automation/deploy-on-gh-pages.sh A automation/travis_rsa.enc 3 files changed, 123 insertions(+), 10 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b72ac0f9f836a50c306c046aab19ff238fac33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: I796927b6f694caf20ffcac6b6f49ba490abc10a3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 39101ffef5fdc211247ea80b4312e9699568d710) (cherry picked from commit a55c80861cd42bf106d6746776dc36ab9c49f31e) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddBond.java 1 file changed, 100 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I796927b6f694caf20ffcac6b6f49ba490abc10a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: I9623974b7c8a175d61b2a1098d39aa3d3c66f7f7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 129ac83fd51b114e79dc7e6352481f77b4971df5) (cherry picked from commit bcac27e37081fd7189d8d2484c5219a999bf9d04) --- A sdk/examples/add_bond.rb 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9623974b7c8a175d61b2a1098d39aa3d3c66f7f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix writing of lists of structs
by Code Review 17 Feb '17

17 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix writing of lists of structs ...................................................................... Fix writing of lists of structs Currently when the type of an attribute is a list of structs, the SDK generates the XML using the name of the attribute as the tag for the list, and the same name in singular as the tag for the elements. For example, for the Bonding.slaves attribute it generates the following: <bonding> <slaves> <slave> <name>eth0</name> </slave> <slave> <name>eth1</name> </slave> </slaves> </bonding> But the server expects the name of the type of the element: <bonding> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> Note the use of 'host_nic' instead of 'slave'. The behaviour of the SDK is conceptually more correct than the behaviour of the server, but as we need to support the existing server, without changes, we need to fix the SDK instead. Change-Id: I98722ac732e1fd6a5e2212138890639e6784e5d6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 3ba240f0c3f456d4ae81da9939fdbb314fa40eed) (cherry picked from commit c5f3f87285ff5936707e2f6d129f828c3272921a) --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/spec/bonding_writer_spec.rb 2 files changed, 55 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98722ac732e1fd6a5e2212138890639e6784e5d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: I9623974b7c8a175d61b2a1098d39aa3d3c66f7f7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 129ac83fd51b114e79dc7e6352481f77b4971df5) --- A sdk/examples/add_bond.rb 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9623974b7c8a175d61b2a1098d39aa3d3c66f7f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0