February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: I9623974b7c8a175d61b2a1098d39aa3d3c66f7f7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_bond.rb 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9623974b7c8a175d61b2a1098d39aa3d3c66f7f7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix writing of lists of structs
by Code Review 17 Feb '17

17 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix writing of lists of structs ...................................................................... Fix writing of lists of structs Currently when the type of an attribute is a list of structs, the SDK generates the XML using the name of the attribute as the tag for the list, and the same name in singular as the tag for the elements. For example, for the Bonding.slaves attribute it generates the following: <bonding> <slaves> <slave> <name>eth0</name> </slave> <slave> <name>eth1</name> </slave> </slaves> </bonding> But the server expects the name of the type of the element: <bonding> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> Note the use of 'host_nic' instead of 'slave'. The behaviour of the SDK is conceptually more correct than the behaviour of the server, but as we need to support the existing server, without changes, we need to fix the SDK instead. Change-Id: I98722ac732e1fd6a5e2212138890639e6784e5d6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java A sdk/spec/bonding_writer_spec.rb 2 files changed, 55 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98722ac732e1fd6a5e2212138890639e6784e5d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: Ib845bd5bcce57c84ede6a51a0625d82c8143460c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b38706b02d2258b17caeda9102cde2297ba3e658) (cherry picked from commit 02ec583e795f05dee927dbe39ef49f934a52dfab) --- A sdk/examples/add_bond.py 1 file changed, 104 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib845bd5bcce57c84ede6a51a0625d82c8143460c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Don't generate custom tarball
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Don't generate custom tarball ...................................................................... Don't generate custom tarball Currently the SDK generates a tarball using the 'tar' command explicitly. This tarball is different to the one generated by the distutils 'sdist' command (which is also executed as part of the build). To avoid differences between the files published in the oVirt web site and the files published in PyPI, this patch changes the automation scripts so that this custom tarball is replaced by the tarball generated by the 'sdist' command. In addition, and in order to achieve that, the patch also changes the way that the version numbers of the SDK are generated, so that they follow the advices of PEP440. Note that these changes in version numbers only apply to non release builds, release builds already used PEP440 version numbers. Change-Id: I8febc38acb3980ea78229ba384f1140273866a86 Bug-Url: https://bugzilla.redhat.com/1422979 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build.py M sdk/MANIFEST.in 2 files changed, 29 insertions(+), 26 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8febc38acb3980ea78229ba384f1140273866a86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: Ib845bd5bcce57c84ede6a51a0625d82c8143460c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b38706b02d2258b17caeda9102cde2297ba3e658) --- A sdk/examples/add_bond.py 1 file changed, 104 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib845bd5bcce57c84ede6a51a0625d82c8143460c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add bonding example
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add bonding example ...................................................................... Add bonding example This patch adds an example that shows how to add a bonded network interface and attach it to a network using an static IP address. Change-Id: Ib845bd5bcce57c84ede6a51a0625d82c8143460c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_bond.py 1 file changed, 104 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib845bd5bcce57c84ede6a51a0625d82c8143460c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Don't generate custom tarball
by Code Review 17 Feb '17

17 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Don't generate custom tarball ...................................................................... Don't generate custom tarball Currently the SDK generates a tarball using the 'tar' command explicitly. This tarball is different to the one generated by the distutils 'sdist' command (which is also executed as part of the build). To avoid differences between the files published in the oVirt web site and the files published in PyPI, this patch changes the automation scripts so that this custom tarball is replaced by the tarball generated by the 'sdist' command. In addition, and in order to achieve that, the patch also changes the way that the version numbers of the SDK are generated, so that they follow the advices of PEP440. Note that these changes in version numbers only apply to non release builds, release builds already used PEP440 version numbers. Change-Id: I8febc38acb3980ea78229ba384f1140273866a86 Bug-Url: https://bugzilla.redhat.com/1422979 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M automation/build.py M packaging/spec.el7.in M packaging/spec.fc24.in M packaging/spec.fc25.in M sdk/MANIFEST.in 5 files changed, 32 insertions(+), 29 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8febc38acb3980ea78229ba384f1140273866a86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InternalAuthn type inference
by Code Review 17 Feb '17

17 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InternalAuthn type inference ...................................................................... core: InternalAuthn type inference Change-Id: I4f6fb0e48eb9e1e492e5e45d6900de8dc62a9340 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f6fb0e48eb9e1e492e5e45d6900de8dc62a9340 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InternalAuthn#doLoad signature
by Code Review 17 Feb '17

17 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InternalAuthn#doLoad signature ...................................................................... core: InternalAuthn#doLoad signature Remove the unused output argument. Change-Id: I7e02be845a19b0602f0c7368971bbca6d2f1aea8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e02be845a19b0602f0c7368971bbca6d2f1aea8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InternalAuthn context
by Code Review 17 Feb '17

17 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InternalAuthn context ...................................................................... core: InternalAuthn context The context member is only ever used in the doLoad method. Hence, it can be reduced from a member to a local variable, making the code cleaner and easier to understand and maintain. Change-Id: I9d7860d2f5ef7359e9397cc67fff57b97bc52df8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthn.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d7860d2f5ef7359e9397cc67fff57b97bc52df8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0