February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1.1_tc2 enable ovirt-4.1 repo
by Code Review 16 Feb '17

16 Feb '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1.1_tc2 enable ovirt-4.1 repo ...................................................................... build: ovirt-live-4.1.1_tc2 enable ovirt-4.1 repo Re-enable the release repo for the deps. packages. Change-Id: I4f2ba84970a14a01b5b433cadef9968fb26a7cd3 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f2ba84970a14a01b5b433cadef9968fb26a7cd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Add VM permission to ExportVmCommand
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Add VM permission to ExportVmCommand ...................................................................... core: Add VM permission to ExportVmCommand Added to ExportVmCommand missing PermissionSubject for the corresponding VM and action group. As side effect, VM ID will appear in ExportVmCommand log messages. Change-Id: I1115e8d90ab73c9a6783344283a1a1b2c8c11d35 Bug-Url: https://bugzilla.redhat.com/1379074 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1115e8d90ab73c9a6783344283a1a1b2c8c11d35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: random/urandom update added to next-run snapshot
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: random/urandom update added to next-run snapshot ...................................................................... core: random/urandom update added to next-run snapshot VMs that were running during cluster update 4.0 -> 4.1 didn't get its 'random' rng updated since the 'random' -> 'urandom' change was not included in next-run snapshot. This resulted in VM in updated cluster with incompatible rng device that prevented the VM from running. Fixed by including updated rng device in next-run snapshot. Calls of RngDeviceUtils updated to pass effective compatibility version instead of cluster version. Bug-Url: https://bugzilla.redhat.com/1419924 Change-Id: I917108c2497a2953c7b829120b28a63626d95b29 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/RngDeviceUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HasRngDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 7 files changed, 82 insertions(+), 57 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I917108c2497a2953c7b829120b28a63626d95b29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Rng devices are updated during cluster downgrade
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Rng devices are updated during cluster downgrade ...................................................................... core: Rng devices are updated during cluster downgrade When cluster version is downgraded from 4.1 to 4.0, rng devices of templates and VMs in the cluster are changed from urandom to random. Change-Id: I42080bb17cb0cb31eac3ece8f6f531432e056cb3 Bug-Url: https://bugzilla.redhat.com/1419924 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42080bb17cb0cb31eac3ece8f6f531432e056cb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: fixing bad permissions on answer file from the past
by Code Review 16 Feb '17

16 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: fixing bad permissions on answer file from the past ...................................................................... packaging: fixing bad permissions on answer file from the past answers.conf is in the configuration volume on the shared storage since 3.6 while it was just a local file before. The 3.5 -> 3.6 upgrade procedure is able to move it to the shared storage but it runs in ovirt-ha-agent deamon as vdsm user so answers.conf should be readable by vdsm user. Bug-Url: https://bugzilla.redhat.com/1401359 Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1.1_tc2
by Code Review 16 Feb '17

16 Feb '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1.1_tc2 ...................................................................... build: ovirt-live-4.1.1_tc2 Change-Id: I90f757f4834b6f387007a9ac58a43e318cd3b4a9 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90f757f4834b6f387007a9ac58a43e318cd3b4a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: spelling fix ...Qutoa() -> ...Quota()
by Code Review 16 Feb '17

16 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: spelling fix ...Qutoa() -> ...Quota() ...................................................................... core: spelling fix ...Qutoa() -> ...Quota() Change-Id: I0ebc8559c4e7e1e818f7f09336b5a8b50462cbcc Signed-off-by: Tony Wang <Sline798(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Freddy Rolland: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ebc8559c4e7e1e818f7f09336b5a8b50462cbcc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tony Wang <sline798(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Dismiss HE VM in affinity migration
by Code Review 16 Feb '17

16 Feb '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: scheduling: Dismiss HE VM in affinity migration ...................................................................... scheduling: Dismiss HE VM in affinity migration Fix Affinity rule enforcer manager to dismiss hosted engine VMs when choosing VM candidates for migration. Change-Id: I83bcbc9ae0a70b078fcda377f17241892802873d Bug-Url: https://bugzilla.redhat.com/1421771 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/72325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83bcbc9ae0a70b078fcda377f17241892802873d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Validate fence agent type upon creation/update
by Code Review 16 Feb '17

16 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Validate fence agent type upon creation/update ...................................................................... core: Validate fence agent type upon creation/update Check if fence agent type is valid for the host upon creation/update of fence agent. Checks are based on valid fence agent types per cluster level, which the host is part of. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1420302 Change-Id: Iecda6f02f96c6696ba01421857db05a32d8a3871 Signed-off-by: Aleksei Slaikovskii <aslaikov(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddFenceAgentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateFenceAgentCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/FenceConfigHelper.java 3 files changed, 67 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecda6f02f96c6696ba01421857db05a32d8a3871 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Make mirrors DNF (Fedora) compatible
by Code Review 16 Feb '17

16 Feb '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Make mirrors DNF (Fedora) compatible ...................................................................... Make mirrors DNF (Fedora) compatible DNF lookes for repo metadate files in the place pointed to by the baseurl tag as opposed to next to the repomd.xml file which is where YUM looks for them. To make the mirrors compatible with DNF, the snapshots have been changed to contain only the repomd.xml file, while all other metadata files are stored in the mirror's 'base' directory. To maintain YUM compatibility, HTTPD rewrite rules need to be configured as specified in a comment in the mirror_mgr.sh script. This patch also includes a change to the mirror_client.py script to make it handle repos with 'metalink' configuration properly. Change-Id: I9a20283ec74bb82b8d672389527edc99594f7012 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1112 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M scripts/mirror_client.py M scripts/mirror_mgr.sh M test/test_mirror_client.py 3 files changed, 40 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a20283ec74bb82b8d672389527edc99594f7012 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0