Change in ovirt-engine[ovirt-engine-4.1]: tools: engine-vacuum.sh - exit code 0 on --help
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: tools: engine-vacuum.sh - exit code 0 on --help
......................................................................
tools: engine-vacuum.sh - exit code 0 on --help
Exist with error code 0. It's not an error.
Change-Id: Ie73dda718b76fd180e579bb7f06453296afd2597
Bug-Url: https://bugzilla.redhat.com/1422562
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/bin/engine-vacuum.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/72404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie73dda718b76fd180e579bb7f06453296afd2597
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Fix event notification titles
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Fix event notification titles
......................................................................
core: Fix event notification titles
Change-Id: Iad5657abdcace553b23276142c70a2795b1aa1b9
Bug-Url: https://bugzilla.redhat.com/1356949
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
(cherry picked from commit 73993fc796b55713baeabca282a65e939667c6f5)
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
3 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/72401
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad5657abdcace553b23276142c70a2795b1aa1b9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: Add OST tested RPMs to ovirt-master-snapshot repo
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Add OST tested RPMs to ovirt-master-snapshot repo
......................................................................
Add OST tested RPMs to ovirt-master-snapshot repo
In order to allow deprecating the logic of collecting RPMs directly from
jobs, and instead take RPMs that pass through OST, code had been added
to the nightly publisher job to also collect RPMs from the OST tested
repo if those RPMs had not been collected from jobs.
This will allow project to eschew updating the nightly publisher job
while still having their RPMs eventually reach the noghtly repo.
See more details in the Jira ticket.
Change-Id: I93eba7f6de4aec3452461ad4748ac19f471ab2cf
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1152
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me
Martin Peřina: Looks good to me
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me
--
To view, visit https://gerrit.ovirt.org/72352
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93eba7f6de4aec3452461ad4748ac19f471ab2cf
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: domxml host agnostic - fix placeholder
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: domxml host agnostic - fix placeholder
......................................................................
core: domxml host agnostic - fix placeholder
Replaced "SERIAL:" with "HOST-SERIAL:" as a result of the review
on the VDSM side.
Change-Id: I25bc77fa5c28c4455c2946546678ce0460685596
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/72379
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25bc77fa5c28c4455c2946546678ce0460685596
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: tools: engine-vacuum.sh - exit code 0 on --help
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: tools: engine-vacuum.sh - exit code 0 on --help
......................................................................
tools: engine-vacuum.sh - exit code 0 on --help
Exist with error code 0. It's not an error.
Change-Id: Ie73dda718b76fd180e579bb7f06453296afd2597
Bug-Url: https://bugzilla.redhat.com/1422562
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/bin/engine-vacuum.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/72399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie73dda718b76fd180e579bb7f06453296afd2597
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Fix event notification titles
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Fix event notification titles
......................................................................
core: Fix event notification titles
Change-Id: Iad5657abdcace553b23276142c70a2795b1aa1b9
Bug-Url: https://bugzilla.redhat.com/1356949
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
3 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/72373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad5657abdcace553b23276142c70a2795b1aa1b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-4.1]: centos7: deps: move to Virt SIG testing repos
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: centos7: deps: move to Virt SIG testing repos
......................................................................
centos7: deps: move to Virt SIG testing repos
CentOS developers implemented the publishers for 4.1 content
up to the testing repository.
Still waiting for the publishing to release repos on mirrors.
Change-Id: I45b597549655e5e656f86c53e41bce53a547ebfd
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-el7-ppc64le-deps.repo.in
M ovirt-el7-x86_64-deps.repo.in
M ovirt-release41.spec.in
4 files changed, 12 insertions(+), 13 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45b597549655e5e656f86c53e41bce53a547ebfd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-4.1]: node: add glusterfs to the default firewall zone
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: add glusterfs to the default firewall zone
......................................................................
node: add glusterfs to the default firewall zone
With glusterfs packages present, bring glusterfs into the default
firewalld zone also.
Change-Id: Idcfd1177c46e97a60fd78e8bcf6358c97eb9ead0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1418630
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
(cherry picked from commit b1ddf7b68767295a0459b8e35b9f8b0ffb6a18ea)
---
M ovirt-release41.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcfd1177c46e97a60fd78e8bcf6358c97eb9ead0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-4.1]: node: remove 90-ngn-disable-networkmanager
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: remove 90-ngn-disable-networkmanager
......................................................................
node: remove 90-ngn-disable-networkmanager
Leave NM enabled by default on NGN for VDSM
Change-Id: Iba4f6111157cd44c819e5d0860082d0e8e91111a
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
(cherry picked from commit 439bd2a05d5db122b0fc7300b1f341c4cfb86bc6)
---
M ovirt-release41.spec.in
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/72396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba4f6111157cd44c819e5d0860082d0e8e91111a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: db: memory_and_disk_images_storage_domain_view - EXISTS inst...
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN
......................................................................
db: memory_and_disk_images_storage_domain_view - EXISTS instead of JOIN
Change Ifbedd49da added indexes and changed the
memory_and_disk_images_storage_domain_view view to use JOIN instead of EXISTS
to determine if the disk is a memory disk/ovf store. On certain datasets
and under load that causes postgres to execute the query slower.
As we yet to find a case in which using EXISTS for those tables causes
to a problem, this patch restores the use of it in the view.
Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e
Bug-Url: https://bugzilla.redhat.com/1412626
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/72260
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7daa22d37d67502836f5222fc9acaaa85881379e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months