- Engine-commits - oVirt List Archives

Change in otopi[master]: network: firewalld: Fix version check
by didi＠redhat.com 11 Jul '16

11 Jul '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: network: firewalld: Fix version check ...................................................................... network: firewalld: Fix version check A recent change to firewalld stopped exposing the version through 'client', but only through 'config' - which it always did. Bug-Url: https://bugzilla.redhat.com/1354607 Change-Id: Ief793a3d0c2076630e04521e8d442cb47af55ea4 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/otopi/network/firewalld.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief793a3d0c2076630e04521e8d442cb47af55ea4 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Do not fail CI for 'too big to analyze' reason
by juan.hernandez＠redhat.com 11 Jul '16

11 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Do not fail CI for 'too big to analyze' reason ...................................................................... webadmin: Do not fail CI for 'too big to analyze' reason Change-Id: I05f8d6e41e8825155983fdf0a839680d7d4b2374 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicompat/exclude-filters.xml 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05f8d6e41e8825155983fdf0a839680d7d4b2374 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: instance type not reported for pools
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: instance type not reported for pools ...................................................................... restapi: instance type not reported for pools Added the same way as the templates have it. Change-Id: Iae0c7b5c4f17ad7961ed41da196dbc4e1217db2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310804 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae0c7b5c4f17ad7961ed41da196dbc4e1217db2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core, restapi: /graphicsconsoles did not work properly with '...
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core,restapi: /graphicsconsoles did not work properly with 'current' ...................................................................... core,restapi: /graphicsconsoles did not work properly with 'current' The ;current did not work properly with /graphicsconsoles. Fixed by adding a new query GetNextRunGraphicsDevicesQuery which returns the graphics consoles from the stateless snapshot and using it on REST resources. Change-Id: I76cc883580c38d8aa3c64863f7de41df7ea9ddbf Bug-Url: https://bugzilla.redhat.com/1128453 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextRunGraphicsDevicesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmNextRunConfigurationQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 11 files changed, 89 insertions(+), 21 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76cc883580c38d8aa3c64863f7de41df7ea9ddbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine : Missing replacement values for add cluster audit lo...
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: engine : Missing replacement values for add cluster audit log message ...................................................................... engine : Missing replacement values for add cluster audit log message Adding a new cluster generates audit log messages where the replacement values are missing and shows up as <UNKNOWN>. User/Group Everyone, Namespace *, Authorization provider: <UNKNOWN> was granted permission for Role CpuProfileOperator on Cpu Profile <UNKNOWN>, by admin@internal-authz. Change-Id: I82b936fabe938296a19857ba873953eca9696e8e Bug-Url: https://bugzilla.redhat.com/1350353 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82b936fabe938296a19857ba873953eca9696e8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: vm_status: add global maintenance to --json output
by stirabos＠redhat.com 11 Jul '16

11 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: vm_status: add global maintenance to --json output ...................................................................... vm_status: add global maintenance to --json output This was missed in the previous patch. Poll whether the cluster is in global maintenance and report it in machine readable output as well Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353537 Change-Id: If1ba93ddd53beddca2100c44072bc301e02d8a2a Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ba93ddd53beddca2100c44072bc301e02d8a2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add isShared method for readability
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add isShared method for readability ...................................................................... core: Add isShared method for readability Add isShared method for readability reasons. Change-Id: I4b71b469a4a826a2a06eea6036d9a3c28c80f439 Bug-Url: https://bugzilla.redhat.com/1353137 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/StorageType.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b71b469a4a826a2a06eea6036d9a3c28c80f439 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introduce StorageTypeSharedComparator.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce StorageTypeSharedComparator. ...................................................................... core: Introduce StorageTypeSharedComparator. When selecting a domain to place memory volumes, there are currently three comparators that choose the target domain: * Number of the VM's disks in the domain * File storage over block storage * Free space - prefer domains with more free space To improve resiliency, we should prefer shared domains over local domain as the second criteria. Change-Id: I27fd13f2cc97874440671a24d3dc17af6e2d4b66 Bug-Url: https://bugzilla.redhat.com/1353137 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeSharedComparator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeSharedComparatorTest.java 3 files changed, 54 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27fd13f2cc97874440671a24d3dc17af6e2d4b66 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add a shared domains comparator when reconstruct.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add a shared domains comparator when reconstruct. ...................................................................... core: Add a shared domains comparator when reconstruct. When electing a new master, reconstruction is attempted according to an ascending order of the last time a domain was used as a master. In a DC that contains both shared and local domains, we should add a secondary criteria to prefer shared domains over local domains for resiliency considerations. Change-Id: Iaaa15e56531c046a45eaf201b0d989dbfc7e8517 Bug-Url: https://bugzilla.redhat.com/1353134 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java 2 files changed, 100 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaa15e56531c046a45eaf201b0d989dbfc7e8517 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add validation for update shared DC to local DC.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add validation for update shared DC to local DC. ...................................................................... core: Add validation for update shared DC to local DC. Local DC should not contain more than one host or more than one cluster. When the DC is being updated we should block this operation. Change-Id: If794a97a346e3b87d8444e9067600aaf4caf748b Bug-Url: https://bugzilla.redhat.com/1302185 Bug-Url: https://bugzilla.redhat.com/1309212 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 2 files changed, 34 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If794a97a346e3b87d8444e9067600aaf4caf748b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0