- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: persist before validate() only when there is a parent ...
by laravot＠redhat.com 12 Jul '16

12 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: persist before validate() only when there is a parent with cb ...................................................................... core: persist before validate() only when there is a parent with cb Currently we persist the command entity before the validate() check and on failure the command status is updated to ENDED_WITH_FAILURE. We do that so that When there is a parent command with a callback, it will be able to detect that the child command execution failed on that phase. Additionally, the parent is responsible to clear the command hirerchy. When there is no parent command, the command entity will never be cleared/monitored. In this patch the logic is changed so that the command is persisted before the CDA phase only in case there's a parent with a CB, otherwise it'll be persisted on the execution phase. Change-Id: Iae96cb414677c970c91ef860824d2a5ca981d861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1352825 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae96cb414677c970c91ef860824d2a5ca981d861 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Users with '%' in their password, cannot log in.
by mperina＠redhat.com 12 Jul '16

12 Jul '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Users with '%' in their password, cannot log in. ...................................................................... aaa: Users with '%' in their password, cannot log in. Login form parameters don't need to be decoded Change-Id: Id1946fa9017b7a01e240a24e3fcca0ff0622300b Bug-Url: https://bugzilla.redhat.com/1352721 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp 4 files changed, 14 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1946fa9017b7a01e240a24e3fcca0ff0622300b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandsCallbackPoller - EXECUTION_FAILED handling
by laravot＠redhat.com 12 Jul '16

12 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandsCallbackPoller - EXECUTION_FAILED handling ...................................................................... core: CommandsCallbackPoller - EXECUTION_FAILED handling The initCommandExecutor() method updates command whose exuection wasn't completed to EXECUTION_FAILED status. Command status might be changed on ENDED_WITH_FAILURE even if it wasn't executed yet to indicate failure (for example, when the command fails on the validate() phase), those commands status shouldn't be changed to EXECUTION_FAILED status which is handled by the infrastacture. Change-Id: Ic3eaef060d4e8c148a20c967968838d9101fd45c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353604 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3eaef060d4e8c148a20c967968838d9101fd45c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: build: post ovirt-engine-4.0.1.1
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0.1.1 ...................................................................... build: post ovirt-engine-4.0.1.1 Change-Id: Ia421d868d9aff11cf478ae976c86f7e6b9eb8140 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 59 files changed, 66 insertions(+), 63 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia421d868d9aff11cf478ae976c86f7e6b9eb8140 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-guest-agent[ovirt-4.0]: linux: Fix osinfo script typo as reported in BZ
by vfeenstr＠redhat.com 12 Jul '16

12 Jul '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: linux: Fix osinfo script typo as reported in BZ ...................................................................... linux: Fix osinfo script typo as reported in BZ Previously overlooked typo in the bug report. This fixes this typo. Change-Id: Iebcad103a751537f35a2532bb6c2bc891971ef9d Bug-Url: https://bugzilla.redhat.com/1337942 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit fe036948268ec61b1c485e3b1c30002018d468f3) --- M scripts/ovirt-osinfo 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebcad103a751537f35a2532bb6c2bc891971ef9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: linux: Fix osinfo script typo as reported in BZ
by vfeenstr＠redhat.com 12 Jul '16

12 Jul '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: linux: Fix osinfo script typo as reported in BZ ...................................................................... linux: Fix osinfo script typo as reported in BZ Previously overlooked typo in the bug report. This fixes this typo. Change-Id: Iebcad103a751537f35a2532bb6c2bc891971ef9d Bug-Url: https://bugzilla.redhat.com/1337942 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M scripts/ovirt-osinfo 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebcad103a751537f35a2532bb6c2bc891971ef9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: build: pep8 tool is now called pycodestyle
by vfeenstr＠redhat.com 12 Jul '16

12 Jul '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: build: pep8 tool is now called pycodestyle ...................................................................... build: pep8 tool is now called pycodestyle The codestyle checking tool pep8 has been renamed to pycodestyle with version 2.0 This patch adds a check for pycodestyle if pep8 wasn't found to handle this change but keep the previous name still relevant. Change-Id: I03f486e13d0365f9e8bf114bbe41164b1b85e9c3 Bug-Url: https://bugzilla.redhat.com/1352773 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M configure.ac 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03f486e13d0365f9e8bf114bbe41164b1b85e9c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: 4.0 publisher: moved ruby sdk4 from master to 4.0
by sbonazzo＠redhat.com 12 Jul '16

12 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: 4.0 publisher: moved ruby sdk4 from master to 4.0 ...................................................................... 4.0 publisher: moved ruby sdk4 from master to 4.0 Change-Id: If366f96baa55717385d3ef4a4383cfe21b8cfbac Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If366f96baa55717385d3ef4a4383cfe21b8cfbac Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: build: ovirt-engine-4.0.1.1
by oourfali＠redhat.com 12 Jul '16

12 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: build: ovirt-engine-4.0.1.1 ...................................................................... build: ovirt-engine-4.0.1.1 Change-Id: I719277ba308c06b6b022b05b4e8524792e564b0f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 60 files changed, 65 insertions(+), 65 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I719277ba308c06b6b022b05b4e8524792e564b0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: core: Use the hosted storage domain id instead of name when ...
by tnisan＠redhat.com 12 Jul '16

12 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Use the hosted storage domain id instead of name when importing it ...................................................................... core: Use the hosted storage domain id instead of name when importing it When importing hosted storage domain the system relied on a hardcoded name: "hosted_storage". Instead of using that constant to find and import the domain the code is now using the domain id that is reported by vdsm in the vm data. The system verifies that a hosted engine VM is running on a storage domain to determine if that domain is a hosted engine domain. Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70 Bug-Url: https://bugzilla.redhat.com/1301105 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 31d8036) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java A packaging/dbscripts/upgrade/04_00_0800_remove_hosted_engine_storage_domain_name_config_value.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 16 files changed, 106 insertions(+), 116 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad7c5f4e5557e4c861e5a2317c79bc3fae874e70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0