- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Allow detach of shared SD from local DC
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Allow detach of shared SD from local DC ...................................................................... core: Allow detach of shared SD from local DC There is no need to block detaching of shared storage domain from a local Data Center, since it can be used in other shared Data Centers. Change-Id: I529442ff7f6d95ceaae18de754c5b3b50b0c5567 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java 4 files changed, 6 insertions(+), 24 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I529442ff7f6d95ceaae18de754c5b3b50b0c5567 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove local DC for shared SD
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove local DC for shared SD ...................................................................... core: Remove local DC for shared SD A local DC can now contain shared SDs and local SDs. Removing a local DC used to format the master domain attached to it since local SDs can not be detached. Shared SDs behave differently, since those can be detached. Based on that, if a local DC will be removed the master storage domain will be formatted only if it is a local SD (to keep the previous behaviour) and if it is a shared SD then this storage domain will only be detached. In the future we should have a seperate patch which will let the user choose whether to format the last local SD or only detach and remove it so it can be imported later. Change-Id: I2385ef4a1a8d36761a0359fe420722f7b4a3bf90 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2385ef4a1a8d36761a0359fe420722f7b4a3bf90 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change attach error message to be suitable for local.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change attach error message to be suitable for local. ...................................................................... core: Change attach error message to be suitable for local. Rephrase app error message ERROR_CANNOT_ATTACH_STORAGE_DOMAIN_STORAGE_TYPE_NOT_MATCH to be specific for local storage domains. Change-Id: I2b65567b2577d2f4d399ac4ea06bb7091a3abd96 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b65567b2577d2f4d399ac4ea06bb7091a3abd96 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update storage pool from local to shared and vice versa
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update storage pool from local to shared and vice versa ...................................................................... core: Update storage pool from local to shared and vice versa Update storage pool type should be available from local DC to shared DC and vice versa while there are no local SDs in a shared DC. Change-Id: I57833964b6e29636a71afe101a4599d0c6f69e23 Bug-Url: https://bugzilla.redhat.com/1302185 Bug-Url: https://bugzilla.redhat.com/1309212 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 37 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57833964b6e29636a71afe101a4599d0c6f69e23 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change shared/local validation on attach SD to DC.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change shared/local validation on attach SD to DC. ...................................................................... core: Change shared/local validation on attach SD to DC. A shared data center should not contain local Storage Domain. All the rest of the combinations should be valid. Change-Id: I200c00700d6e9f735414267b89736c8dd6f0f5fd Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I200c00700d6e9f735414267b89736c8dd6f0f5fd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Present shared SD and local DCs on attach.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Present shared SD and local DCs on attach. ...................................................................... webadmin: Present shared SD and local DCs on attach. Present local Data Centers when attaching a shared SD from Data Centers -> Storage sub tab, and present shared storage domains when attaching a storage domain from the Data Center subtab in storage main tab Change-Id: I41dcae28e37214ca05974f29bacdd6d3d6961757 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60171 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41dcae28e37214ca05974f29bacdd6d3d6961757 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: New SD types should not be filtered for local DCs.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: New SD types should not be filtered for local DCs. ...................................................................... webadmin: New SD types should not be filtered for local DCs. ISO and export could be attached to a local DC although regualr data SDs were not allowed. This fix should allow all types of SDs to be attached to a local DC and on a shared DC we only filtering he local SD option Based on that approach, new and edit storage models should not filter storage domains' types based on the Data Center they are related to, since local Data Centers should now support shared storage domains too. Change-Id: Iae37ba0fa517a3689a6e921cf9d37e52e04e2444 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae37ba0fa517a3689a6e921cf9d37e52e04e2444 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Rename storageTypeComparator to be more specific.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Rename storageTypeComparator to be more specific. ...................................................................... core: Rename storageTypeComparator to be more specific. StorageTypeComperator simply compare between file and block storage domain. File type is a more complex type than only file or block therefore renaming the class to be more specific to StorageTypeFileComparator. Change-Id: I128362e6261962e453686b75e9804ea25a950ed5 Bug-Url: https://bugzilla.redhat.com/1353137 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandler.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileComparator.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/sdcomparators/StorageTypeFileComparatorTest.java 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I128362e6261962e453686b75e9804ea25a950ed5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin:Enable storage type at data center popup.
by mlipchuk＠redhat.com 11 Jul '16

11 Jul '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin:Enable storage type at data center popup. ...................................................................... webadmin:Enable storage type at data center popup. Do not disable storage type combo box when updating data center, even if storage domains are already attached. It is the backend responsibility to validate whether a data center can change its storage type based on the storage domain attached to it. Change-Id: Ic551bb93ba684afdec909b75ec2183b405476ff2 Bug-Url: https://bugzilla.redhat.com/1302185 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 0 insertions(+), 19 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/60235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic551bb93ba684afdec909b75ec2183b405476ff2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: dropping the skip on moving downstream bugs to MODIFIED
by eedri＠redhat.com 11 Jul '16

11 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: dropping the skip on moving downstream bugs to MODIFIED ...................................................................... dropping the skip on moving downstream bugs to MODIFIED It might be that in the past we didn't move RHEV bugs to MODIFIED because it required a downstream patch to be included in the fix. This patch assumes that if a bug was included in a commit msg in upstream code it means the patch is fixing that bug and bug status should be updated Change-Id: I805fd00577b0155086c6147375afa2197ea1e326 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I805fd00577b0155086c6147375afa2197ea1e326 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0