- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: Cluster update triggers VM update only if necessary
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Cluster update triggers VM update only if necessary ...................................................................... core: Cluster update triggers VM update only if necessary There was a problem when user tried to edit Cluster while there was a migrating VM in the Cluster. The root cause was collision of VM locks of MigrateVmCommand and UpdateVmCommand called by UpdateClusterCommand. This patch doesn't solve the problem entirely. It only lowers the probability its occurrence by triggering UpdateVmCommand only if cluster compatibility level was changed. Change-Id: Ieccac1f08847681d5f326b9c54a99364720cfdb0 Bug-Url: https://bugzilla.redhat.com/1349526 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieccac1f08847681d5f326b9c54a99364720cfdb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Avoid NPE when external event has link but not id
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Avoid NPE when external event has link but not id ...................................................................... restapi: Avoid NPE when external event has link but not id Currently when an external event is added we support links to specific objects, for examaple, to add an event with a link to a specific virtual machine we accept the following event: <event> <description>File system /home is full</description> <severity>alert</severity> <origin>mymonitor</origin> <custom_id>1467879754</custom_id> <vm id="aae98225-5b73-490d-a252-899209af17e9"/> </event> But we don't check if the "id" attribute of the link is actually populated, which generates a NPE. For example, if the caller sends the name instead of the id: <event> <description>File system /home is full</description> <severity>alert</severity> <origin>mymonitor</origin> <custom_id>1467879754</custom_id> <vm> <name>myvm</name> </vm> </event> This isn't supported at the moment, but it shound't generate a NPE, it should just be ignored. This patch changes the event mapper so that it checks if the id is present. Change-Id: I13a174699e66833d6b31f50d0bb03967c178458e Bug-Url: https://bugzilla.redhat.com/1353460 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 195ac1b2e655629416373e8106cbcdb516b2ae3a) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java 1 file changed, 35 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13a174699e66833d6b31f50d0bb03967c178458e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: vm_status: add global maintenance to --json output
by stirabos＠redhat.com 11 Jul '16

11 Jul '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: vm_status: add global maintenance to --json output ...................................................................... vm_status: add global maintenance to --json output This was missed in the previous patch. Poll whether the cluster is in global maintenance and report it in machine readable output as well Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353537 Change-Id: If1ba93ddd53beddca2100c44072bc301e02d8a2a Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Verified -- To view, visit https://gerrit.ovirt.org/59950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ba93ddd53beddca2100c44072bc301e02d8a2a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Move Java SDK checks and build to Fedora 24
by sbonazzo＠redhat.com 11 Jul '16

11 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Move Java SDK checks and build to Fedora 24 ...................................................................... Move Java SDK checks and build to Fedora 24 This patch moves the Java SDK jobs for the master branch from Fedora 23 to Fedora24. Change-Id: Ia54c514dd4e20971726b01525e297818fe15ad7e Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml 2 files changed, 11 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Ondra Machacek: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia54c514dd4e20971726b01525e297818fe15ad7e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add 'completed' method to RollbackHandler
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: add 'completed' method to RollbackHandler ...................................................................... core: add 'completed' method to RollbackHandler motivation: there's missing onComplete method allowing to do some actions only when transaction completed. Usecases: - 'client' returns MAC address back to MAC address pool. After doing that, rollback can occur and in that case we need to put that MAC address back to pool. Simple 'onRollback' listener seems to be sufficient for that at first, but we need to realize, that putting MAC address back to pool makes it immediately available for other threads, which means we may encounter problems in on rollback handler if someone used this MAC address meantime. So correct solution here would be, when returning MAC address back to pool, pool adds this MAC address to some collection to be returned, and does so only when related transaction succeeded. - OVF refresh is needed when hosted engine VM is edited, but the procedure requires all data to be already present in the database. Fixes: • CommandBase implements RollbackHandler. This is from OO point of view wrong, since command is not a RollbackHandler. • Previous point also touches another issue — having method 'rollback' directly on Command class, declared as 'non final' means that one can easily make error and suppress logging in CommandBase.rollback method while overriding it to add some custom handling. This should be encapsulated, no one should have possibility to tinker with CommandBase RollbackHandler. Multiple handler can be registered, so every command requiring it's own code in rollback handler, should declare and register his own. In case where order of handlers matter, we can defined composite RollbackHandler, but I do not expect necessity of doing so in near future. Bug-Url: https://bugzilla.redhat.com/1283062 Bug-Url: https://bugzilla.redhat.com/1343991 Change-Id: I352be763c84b2c3e640dbc23d15a5a294a6193e1 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveCinderSnapshotDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/NoOpTransactionCompletionListener.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/RollbackHandler.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionCompletionListener.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/transaction/TransactionSupport.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java 12 files changed, 185 insertions(+), 119 deletions(-) Approvals: Martin Sivák: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352be763c84b2c3e640dbc23d15a5a294a6193e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: webadmin: On NUMA pinning update send a fully populated NUMA...
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: On NUMA pinning update send a fully populated NUMA node ...................................................................... webadmin: On NUMA pinning update send a fully populated NUMA node When updating NUMA nodes through the NUMA window, reachable through 'NUMA Support' in the host context menu, the CPU indices of the NUMA nodes were not sent to the backend. As a consequence the NUMA mapping was partially deleted in the DB, leaving the VM in an inconsistent state. Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27 Bug-Url: https://bugzilla.redhat.com/1324830 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: core: remove inaccessible memory during upgrade
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: remove inaccessible memory during upgrade ...................................................................... core: remove inaccessible memory during upgrade This patch fixes an issue discovered in the upgrade process where the upgrade fails while trying to convert memory volumes on a storage domain that does not exist in the system to disk images. So before doing the conversion, such memory volumes are first being removed. They are unusable anyway. Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82 Bug-Url: https://bugzilla.redhat.com/1353219 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iead5deab3c572f6bbc02af1f56c41ffdfdf0fc82 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: On NUMA pinning update send a fully populated NUMA...
by tnisan＠redhat.com 11 Jul '16

11 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: On NUMA pinning update send a fully populated NUMA node ...................................................................... webadmin: On NUMA pinning update send a fully populated NUMA node When updating NUMA nodes through the NUMA window, reachable through 'NUMA Support' in the host context menu, the CPU indices of the NUMA nodes were not sent to the backend. As a consequence the NUMA mapping was partially deleted in the DB, leaving the VM in an inconsistent state. Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27 Bug-Url: https://bugzilla.redhat.com/1324830 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea0ec0e14dab6516b8423ce39fe8e86735c5c27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-wildfly-overlay: move from fc22 to fc24
by sbonazzo＠redhat.com 11 Jul '16

11 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-wildfly-overlay: move from fc22 to fc24 ...................................................................... ovirt-engine-wildfly-overlay: move from fc22 to fc24 - Dropped FC22 build after FC22 EOL - Added FC24 build for WildFly 10 Change-Id: If2933cbf08cd7becc450f9bbd687a091b39a73ec Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2933cbf08cd7becc450f9bbd687a091b39a73ec Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ui: Template version sort not working properly.
by shavivi＠redhat.com 11 Jul '16

11 Jul '16

Shahar Havivi has submitted this change and it was merged. Change subject: ui: Template version sort not working properly. ...................................................................... ui: Template version sort not working properly. When the column was only numbers it was soring good, Now that we have name and number we need to use LexoNumericComparator which is the default. Bug-Url: https://bugzilla.redhat.com/1273825 Change-Id: I8ad1f5f3a4ce1e42ec1519dabdf9f67ed260da3b Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ad1f5f3a4ce1e42ec1519dabdf9f67ed260da3b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0