- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add tests to OvfManagerTest
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add tests to OvfManagerTest ...................................................................... core: Add tests to OvfManagerTest Change-Id: Ie47ce56efa5fd18b22fd702f5fa3c093e0068f9f Bug-Url: https://bugzilla.redhat.com/1339658 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 1 file changed, 147 insertions(+), 31 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/57851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie47ce56efa5fd18b22fd702f5fa3c093e0068f9f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Dashboard storage calculation
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Dashboard storage calculation ...................................................................... webadmin: Dashboard storage calculation - The dashboard storage queries where not taking the status of the storage into account. So it would count detached storage domains in the calculations. This patch makes sure that the detached storage domains are not counted. Change-Id: Ifdfb68afd0f8aa1dd06a15de8c469b4cae5363e8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1336896 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdfb68afd0f8aa1dd06a15de8c469b4cae5363e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Dashboard: no hosts
by awels＠redhat.com 25 May '16

25 May '16

Alexander Wels has submitted this change and it was merged. Change subject: Dashboard: no hosts ...................................................................... Dashboard: no hosts - When the system doesn't have any hosts/storage domains defined yet, the donuts were showing invalid values instead of 0, this patch fixes the data generated by the servlet to return 0 when no hosts or storage domains are available. Change-Id: Ic925633eabdd3875a144bda05523fa4990028c7d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337606 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/GlobalUtilizationCpuSummary.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic925633eabdd3875a144bda05523fa4990028c7d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Dashboard storage calculation
by awels＠redhat.com 25 May '16

25 May '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Dashboard storage calculation ...................................................................... webadmin: Dashboard storage calculation - The dashboard storage queries where not taking the status of the storage into account. So it would count detached storage domains in the calculations. This patch makes sure that the detached storage domains are not counted. Change-Id: Ifdfb68afd0f8aa1dd06a15de8c469b4cae5363e8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1336896 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdfb68afd0f8aa1dd06a15de8c469b4cae5363e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: adding vdsm & engine config for gerrit hooks
by eedri＠redhat.com 25 May '16

25 May '16

Eyal Edri has submitted this change and it was merged. Change subject: adding vdsm & engine config for gerrit hooks ...................................................................... adding vdsm & engine config for gerrit hooks - This is not auto-deployed to Gerrit! - For now its a backup for the config files which are on the gerrit server and should be used for tracking changes until we'll move it to a proper repo we can use to deploy safely to gerrit Change-Id: Id784c5c3851c0bb83d157e5c1b5b86c38d30aa8e Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- A hooks/config/README A hooks/config/ovirt-engine.config A hooks/config/vdsm.config 3 files changed, 37 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id784c5c3851c0bb83d157e5c1b5b86c38d30aa8e Gerrit-PatchSet: 2 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ReplacementUtilsTest type inference
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ReplacementUtilsTest type inference ...................................................................... core: ReplacementUtilsTest type inference Change-Id: I0b6712ea197563662acc2add2744df9600839132 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b6712ea197563662acc2add2744df9600839132 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ReplacementUtilsTest streaming API
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ReplacementUtilsTest streaming API ...................................................................... core: ReplacementUtilsTest streaming API Use Java 8's streaming API where possible in order to clean up the code. Change-Id: I6268feb5bff269860e3b8f503ec6efc13623f522 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java 1 file changed, 3 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6268feb5bff269860e3b8f503ec6efc13623f522 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RaplcemanetUtilsTest foreach usage
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RaplcemanetUtilsTest foreach usage ...................................................................... core: RaplcemanetUtilsTest foreach usage Use an enhanced for loop instead of a while loop to improve the code's readability. Change-Id: Ia6a672be707a6ee376a7aa63b1fe5cb40164b06f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6a672be707a6ee376a7aa63b1fe5cb40164b06f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: fix jsonrpc calls on additional hosts
by stirabos＠redhat.com 25 May '16

25 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: fix jsonrpc calls on additional hosts ...................................................................... storage: fix jsonrpc calls on additional hosts Fixing jsonrpc call to VDSM on additonal host path. Change-Id: If5fedfd5d09b6a0c4434effc2c6516c49d718522 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/storage/storage.py 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fedfd5d09b6a0c4434effc2c6516c49d718522 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsCommandsHelper - fix filtering
by laravot＠redhat.com 25 May '16

25 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: VdsCommandsHelper - fix filtering ...................................................................... core: VdsCommandsHelper - fix filtering the filter checked that the list doesn't contain the vds, while the list contain Guid objects. Change-Id: I20f11d4595ff4d34999f3e2341351e91973ec194 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20f11d4595ff4d34999f3e2341351e91973ec194 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0