- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fixes in cluster migration tab
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixes in cluster migration tab ...................................................................... webadmin: fixes in cluster migration tab - moved the migration related properties to "migration" tab - added disabling the additional properties when a policy is selected - fixed the showing of the description of the policy (needs to be inited only after the view) - removed redundant setting of the changability of the additional properties (leftover after the version cleanup) Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8 Bug-Url: https://bugzilla.redhat.com/1339538 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 5 files changed, 39 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Create vm_templates_view without other entity types
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Create vm_templates_view without other entity types ...................................................................... core: Create vm_templates_view without other entity types The search query used currently for Templates view looks over vm_templates_view that contains several different entity types and then filters templates out of the result that was returned from SQL query. But this works badly with limited queries - the query that is limited to return one page of results (for example, 100 items) may return less. >From Frontend point of view, the page that is not full should be the last one. To fix this, a new view must be created containing only template entities. The post-filtering will not be needed and the query will always return a full page of results for all pages except the last one. Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338816 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 4 files changed, 71 insertions(+), 73 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244c9a22fd3d8bd9e0b3ac2ebea717740fc030d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix UIException when creating a VM from template
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix UIException when creating a VM from template ...................................................................... webadmin: Fix UIException when creating a VM from template Change-Id: Ia1fe1db6521bf4e0e3fdf4a19df5c4c13826f9de Bug-Url: https://bugzilla.redhat.com/1339566 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1fe1db6521bf4e0e3fdf4a19df5c4c13826f9de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: post ovirt-engine-4.0 branching
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0 branching ...................................................................... build: post ovirt-engine-4.0 branching Change-Id: I9d0a5593e54d780074005fffd2e3a359ce74eb9e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml 56 files changed, 59 insertions(+), 56 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d0a5593e54d780074005fffd2e3a359ce74eb9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: ChildCommandsCallbackBase - setSucceeded(false)
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ChildCommandsCallbackBase - setSucceeded(false) ...................................................................... core: ChildCommandsCallbackBase - setSucceeded(false) When the command entity is persisted, its return value is persisted as well. If the command execute() succeeded, getReturnValue().getSucceeded() will return true. The command object is built from the persisted command entity, which means that the return value will be initiated to the persisted return value, when calling endAction() having the return value returning true value when checking getSucceeded() might lead to wrong results. This patch is simple and sets the succeeded flag to false to avoid that issue. Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339536 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/58020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fixes in cluster migration tab
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: fixes in cluster migration tab ...................................................................... webadmin: fixes in cluster migration tab - moved the migration related properties to "migration" tab - added disabling the additional properties when a policy is selected - fixed the showing of the description of the policy (needs to be inited only after the view) - removed redundant setting of the changability of the additional properties (leftover after the version cleanup) Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8 Bug-Url: https://bugzilla.redhat.com/1339538 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 5 files changed, 39 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests Marek Libra: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: topic: Spelling error causing KeyError in minidnf
by didi＠redhat.com 25 May '16

25 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: topic: Spelling error causing KeyError in minidnf ...................................................................... topic: Spelling error causing KeyError in minidnf This misspelling leads to vdsm being unable to install through the ovirt engine due to a KeyError being raised. Change-Id: I04872144215b2cea0f4ca7251fa6c3bbc0cf2cdc Signed-off-by: Hayley Swimelar <hayley(a)linbit.com> --- M src/otopi/minidnf.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hayley Swimelar: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04872144215b2cea0f4ca7251fa6c3bbc0cf2cdc Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Hayley Swimelar <hayley(a)linbit.com> Gerrit-Reviewer: Hayley Swimelar <hayley(a)linbit.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixed typo in migration policy name
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: fixed typo in migration policy name ...................................................................... core: fixed typo in migration policy name replaced 'not may not' to 'may not' Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715 Bug-Url: https://bugzilla.redhat.com/1338843 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: added reporting of current cmd line
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: added reporting of current cmd line ...................................................................... webadmin: added reporting of current cmd line Added the current kernel cmd line reporting to the edit host dialog. Change-Id: I862ddddd1f7d268425786cded42c6d3ef9c0c6d2 Bug-Url: https://bugzilla.redhat.com/1339539 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 5 files changed, 29 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862ddddd1f7d268425786cded42c6d3ef9c0c6d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added kernelArgs storing to vds_dynamic
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added kernelArgs storing to vds_dynamic ...................................................................... core: added kernelArgs storing to vds_dynamic VDSM started to report kernelArgs in caps - this patch adds the engine-side support to store it in the DB. Change-Id: Ib5f8ea42342b78c857a924d51c4f42a6cacd49db Bug-Url: https://bugzilla.redhat.com/1339539 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0710_add_kernel_args_to_vds_dynamic.sql M packaging/dbscripts/vds_sp.sql 10 files changed, 45 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5f8ea42342b78c857a924d51c4f42a6cacd49db Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0