- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: Extract video device from OVF store
by msivak＠redhat.com 25 May '16

25 May '16

Martin Sivák has submitted this change and it was merged. Change subject: Extract video device from OVF store ...................................................................... Extract video device from OVF store To stay in sync with ovirt-engine, also extract video devices from the OVF store. Change-Id: I72f42a299578975a6a1a838ee65eff15586264a9 Related-To: https://bugzilla.redhat.com/1326810 Related-To: https://bugzilla.redhat.com/1328921 Bug-Url: https://bugzilla.redhat.com/1339305 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml M ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml 4 files changed, 40 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Roman Mohr: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72f42a299578975a6a1a838ee65eff15586264a9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Set up bootable property accordingly in new VM popup
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set up bootable property accordingly in new VM popup ...................................................................... webadmin: Set up bootable property accordingly in new VM popup Change-Id: I37640274e1e1198f0fbaf92dbccae0265ccb4b3c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1338510 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 7 files changed, 64 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37640274e1e1198f0fbaf92dbccae0265ccb4b3c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix UIException when creating a VM from template
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix UIException when creating a VM from template ...................................................................... webadmin: Fix UIException when creating a VM from template Change-Id: Ia1fe1db6521bf4e0e3fdf4a19df5c4c13826f9de Bug-Url: https://bugzilla.redhat.com/1339566 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1fe1db6521bf4e0e3fdf4a19df5c4c13826f9de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddImageFromScratchCommand - use getTaskIdList()
by laravot＠redhat.com 25 May '16

25 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: AddImageFromScratchCommand - use getTaskIdList() ...................................................................... core: AddImageFromScratchCommand - use getTaskIdList() currently the created task is added to the internal vdsm task id list always, instead we should use getTaskIdList() which will add the task to the correct list. Change-Id: I417e28db165911963e9eb727303de0b1d8000f13 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AddImageFromScratchCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I417e28db165911963e9eb727303de0b1d8000f13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.4]: packaging: post otopi-1.4.2
by didi＠redhat.com 25 May '16

25 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: post otopi-1.4.2 ...................................................................... packaging: post otopi-1.4.2 Change-Id: I4846c6033422e80ed40258916c150867d0446179 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4846c6033422e80ed40258916c150867d0446179 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.4]: packaging: otopi-1.4.2
by didi＠redhat.com 25 May '16

25 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: otopi-1.4.2 ...................................................................... packaging: otopi-1.4.2 Change-Id: I25aa2965344fd21012a3844dd41836555041f823 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ChangeLog M configure.ac M otopi.spec.in 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25aa2965344fd21012a3844dd41836555041f823 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.4]: core: log: Support filtering regular expressions
by didi＠redhat.com 25 May '16

25 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: core: log: Support filtering regular expressions ...................................................................... core: log: Support filtering regular expressions Change-Id: If27a19f7725dd53fd4bf2e420bd17135a2102d67 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/constants.py M src/plugins/otopi/core/log.py 2 files changed, 32 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If27a19f7725dd53fd4bf2e420bd17135a2102d67 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add memory when creating/restoring from snapshot
by laravot＠redhat.com 25 May '16

25 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Add memory when creating/restoring from snapshot ...................................................................... core: Add memory when creating/restoring from snapshot Include memory to a snapshot by default when creating it or restoring from it. This default is used, in the first place, by REST API when memory option is not set in the request. Change-Id: I3ad11a2802564842938325a11e9dffb8c68d34d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1058661 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java 5 files changed, 8 insertions(+), 3 deletions(-) Approvals: Shmuel Leib Melamud: Verified Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ad11a2802564842938325a11e9dffb8c68d34d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: setup: ask host address on additional hosts
by stirabos＠redhat.com 25 May '16

25 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: setup: ask host address on additional hosts ...................................................................... setup: ask host address on additional hosts Use hostname.getHostname from ovirt_setup_lib to ask and validate the host address on additional host. On the first host we already ask the management interface to create the management bridge on and so we can only take the address that uniquely resolves there. On additional hosts we simply rely on host-deploy to create the management bridge on the interface where the address supplied to hosts.add resolves on and so it's worth to ask the user with a reasonable default. Change-Id: Ic5ce041e47fef02d60aa46159ff56f9e0622d5fc Bug-Url: https://bugzilla.redhat.com/1251968 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/network/bridge.py 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ce041e47fef02d60aa46159ff56f9e0622d5fc Gerrit-PatchSet: 17 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - endAction() lock release
by laravot＠redhat.com 25 May '16

25 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - endAction() lock release ...................................................................... core: CommandBase - endAction() lock release When ending command action the commands locks are freed on endActionInTransactionScope() which is wrong because the transaction should be committed before the lock is released. additionally, currently there is a duplicate call which is unneeded. Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1405b6010cfebc5cdbe4ac8c87822ea6fc0fd72 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0