- Engine-commits - oVirt List Archives

Change in jenkins[master]: ovirt-engine: add 4.0 branch
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: add 4.0 branch ...................................................................... ovirt-engine: add 4.0 branch Change-Id: I45358eeb7a0b55a51ac3c035beba66c810b6ab18 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml A jobs/ovirt-engine_upgrade_to_4.0/build_engine_rpm.sh A jobs/ovirt-engine_upgrade_to_4.0/cleanup.file.otopi A jobs/ovirt-engine_upgrade_to_4.0/cleanup.sh A jobs/ovirt-engine_upgrade_to_4.0/setup.file.otopi A jobs/ovirt-engine_upgrade_to_4.0/upgrade.sh 8 files changed, 840 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45358eeb7a0b55a51ac3c035beba66c810b6ab18 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ChildCommandsCallbackBase - setSucceeded(false)
by laravot＠redhat.com 25 May '16

25 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: ChildCommandsCallbackBase - setSucceeded(false) ...................................................................... core: ChildCommandsCallbackBase - setSucceeded(false) When the command entity is persisted, its return value is persisted as well. If the command execute() succeeded, getReturnValue().getSucceeded() will return true. The command object is built from the persisted command entity, which means that the return value will be initiated to the persisted return value, when calling endAction() having the return value returning true value when checking getSucceeded() might lead to wrong results. This patch is simple and sets the succeeded flag to false to avoid that issue. Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Import template from external provider with balloon de...
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Import template from external provider with balloon device enabled ...................................................................... core: Import template from external provider with balloon device enabled When importing images from external providers as template, set the "Ballon device enabled" to true as done as the default behavior when creating a VM Change-Id: I533ec7e0c2849bc7ab77579f3f4df7a3ea952a40 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1338665 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533ec7e0c2849bc7ab77579f3f4df7a3ea952a40 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: restrict engine build-artifacts to bare metal slaves
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: restrict engine build-artifacts to bare metal slaves ...................................................................... restrict engine build-artifacts to bare metal slaves bug-url: https://ovirt-jira.atlassian.net/browse/OVIRT-523 Change-Id: Ifbb6e36b5527a08100e2dc738417694a5337f71d Signed-off-by: ngoldin <ngoldin(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Nadav Goldin: Verified; Ready for review Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/58007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb6e36b5527a08100e2dc738417694a5337f71d Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Override migration policy
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Override migration policy ...................................................................... webadmin: Override migration policy - The VM popup update patch mangled the override migration policy. This patch fixes that issue. Change-Id: I2c4ec68da042a3977d2432d3f52ad83b96c57428 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338834 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 41 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Alexander Wels: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4ec68da042a3977d2432d3f52ad83b96c57428 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmGuestAgentInterfaceDaoTest type inference
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmGuestAgentInterfaceDaoTest type inference ...................................................................... core: VmGuestAgentInterfaceDaoTest type inference Change-Id: Iacd5936cd99c3f3dfe288289495eb60a88e9199e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacd5936cd99c3f3dfe288289495eb60a88e9199e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskImageDynamicDaoTest type inference
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImageDynamicDaoTest type inference ...................................................................... core: DiskImageDynamicDaoTest type inference Infer types where possible. Change-Id: I0f62f71df547431218b52f8b75a8403c265f2268 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f62f71df547431218b52f8b75a8403c265f2268 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: MassOperationsGenericDao type inference
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: MassOperationsGenericDao type inference ...................................................................... core: MassOperationsGenericDao type inference Change-Id: Ie5d0db2cff056cb125b85bc46a59f12082b35293 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDao.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d0db2cff056cb125b85bc46a59f12082b35293 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskImageDynamicDaoTest implicit autoboxing
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImageDynamicDaoTest implicit autoboxing ...................................................................... core: DiskImageDynamicDaoTest implicit autoboxing Change-Id: I43ef7ff9e32605a885bece780bde7164d0398dc9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43ef7ff9e32605a885bece780bde7164d0398dc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VmStatic from VmStatisticsDaoTest
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VmStatic from VmStatisticsDaoTest ...................................................................... core: Remove VmStatic from VmStatisticsDaoTest VmStatisticsDaoTest is about testing VmStatisticsDao[Impl] - it should not have anything to do with VmStatic. This is especially true as the VmStatic is just retrieved from the database by ID, and then only used to store that ID. Change-Id: I07de1d5f823150acbf26179f769deebfae15a9be Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07de1d5f823150acbf26179f769deebfae15a9be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0