- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add/UpdateVmInterfaceCommand fix compensation
by alkaplan＠redhat.com 25 May '16

25 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add/UpdateVmInterfaceCommand fix compensation ...................................................................... engine: Add/UpdateVmInterfaceCommand fix compensation 'VmBase.ssoMethod' field caused the bug. The enum 'SsoMethod' overrides 'toString()' method. Since 'JsonObjectDeserializerFactory' uses 'EnumResolver.constructUnsafeUsingToString' to create a map of enum keys to enum values, the key of the map is the value of the 'toString()' -> the lower case name of the enum. On the other hand, the serializer uses the 'name()' method as the key of the serialized enum. Since in 'SsoMethod' the 'name()' and the 'toString()' are not the same, the deserialier cannot find the serialized enum. Added '@JsonCreator' and '@JsonValue' to make sure the key in both serialization and deserialization will be the same. Change-Id: Iad3a12d1542e16ca7d8aa6c8a2c142bb2e09e9fd Bug-Url: https://bugzilla.redhat.com/1338601 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SsoMethod.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57913 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad3a12d1542e16ca7d8aa6c8a2c142bb2e09e9fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: introducing pool awareness of transaction and compensa...
by alkaplan＠redhat.com 25 May '16

25 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: introducing pool awareness of transaction and compensation ...................................................................... core: introducing pool awareness of transaction and compensation This patch is needed so that if tx is rollbacked or compensation occurs, then pool content is updated accordingly. This patch is squashed from multiple smaller patches, if you need finer info, please look for following gerrit topic: https://gerrit.ovirt.org/#/q/topic:txAndCompensationAwareMacPools Change-Id: Idbd4967ca53403b03454b22a74f7d0f632104fc4 Bug-Url: https://bugzilla.redhat.com/1283062 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ObjectCompensation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContextBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolDecorator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDc.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactoryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerDcTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitySnapshot.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ReleaseMacsTransientCompensation.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TransientCompensationBusinessEntity.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TransientEntityType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java 34 files changed, 973 insertions(+), 168 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbd4967ca53403b03454b22a74f7d0f632104fc4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error in creating a VM Cinder disk
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error in creating a VM Cinder disk ...................................................................... core: Fix error in creating a VM Cinder disk Change-Id: I09be19d8089cef10e2f6283adb5dd65aa097da8d Bug-Url: https://bugzilla.redhat.com/1339300 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09be19d8089cef10e2f6283adb5dd65aa097da8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error in importing a VM as a clone
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error in importing a VM as a clone ...................................................................... core: Fix error in importing a VM as a clone Change-Id: Ife65f0c41a5d82e85421311e6d9b3b210096aafb Bug-Url: https://bugzilla.redhat.com/1339236 Bug-Url: https://bugzilla.redhat.com/1338526 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife65f0c41a5d82e85421311e6d9b3b210096aafb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Refresh with gerrit local modifications
by dcaro＠redhat.com 24 May '16

24 May '16

David Caro has submitted this change and it was merged. Change subject: Refresh with gerrit local modifications ...................................................................... Refresh with gerrit local modifications Change-Id: Ic295d64884809383be13ecf0e57c84118eec4e65 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED M hooks/custom_hooks/patchset-created.bz.2.correct_product M hooks/custom_hooks/update_tracker 3 files changed, 25 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic295d64884809383be13ecf0e57c84118eec4e65 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Do less ioTune VDSM requests
by msivak＠redhat.com 24 May '16

24 May '16

Martin Sivák has submitted this change and it was merged. Change subject: Do less ioTune VDSM requests ...................................................................... Do less ioTune VDSM requests This patch lowers the number of API calls in cases where no ioTune is available or no change was detected. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337228 Change-Id: I5f190eb49e77f19e391bc27535f67c5b05fded8c Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/57794 Reviewed-by: Roman Mohr <rmohr(a)redhat.com> Continuous-Integration: Jenkins CI --- M mom/Collectors/GuestIoTune.py M mom/Controllers/IoTune.py 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f190eb49e77f19e391bc27535f67c5b05fded8c Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Add GuestBalloonOptional collector
by msivak＠redhat.com 24 May '16

24 May '16

Martin Sivák has submitted this change and it was merged. Change subject: Add GuestBalloonOptional collector ...................................................................... Add GuestBalloonOptional collector This collector allows VM processing even when the balloon device is missing. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337834 Change-Id: Iaa5427212bc1f4c755c2b8fe18cd18662d7e2316 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/57795 Reviewed-by: Roman Mohr <rmohr(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> Continuous-Integration: Jenkins CI --- A mom/Collectors/GuestBalloonOptional.py M mom/Collectors/Makefile.am 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa5427212bc1f4c755c2b8fe18cd18662d7e2316 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: gluster: explicit release 7 in URL
by sbonazzo＠redhat.com 24 May '16

24 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: gluster: explicit release 7 in URL ...................................................................... gluster: explicit release 7 in URL Use explicitly release 7 in order to avoid 7Server and 7Workstation to break yum. Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba (cherry picked from commit a282ad489cf228dc9e2d919c4c7cb91e891dc7a6) --- M ovirt-el7-deps.repo.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c8d79c78bb02fdb3e2500ae43c8da237fe5bcba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddDiskCommand - set correct DiskVmElement
by tnisan＠redhat.com 24 May '16

24 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddDiskCommand - set correct DiskVmElement ...................................................................... core: AddDiskCommand - set correct DiskVmElement AddDiskCommand -> buildAddCinderDiskParameters: setting DiskVmElement correctly. Change-Id: Id05c7ed070a27c30a6c0cf278f5e9d6683b23c1f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/57886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id05c7ed070a27c30a6c0cf278f5e9d6683b23c1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Log message for provider connection failure
by mperina＠redhat.com 24 May '16

24 May '16

Martin Peřina has submitted this change and it was merged. Change subject: engine: Log message for provider connection failure ...................................................................... engine: Log message for provider connection failure Change-Id: If1584c74228f5d36938e1d4a2a581c4691a3476d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/57930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1584c74228f5d36938e1d4a2a581c4691a3476d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0