- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VmStatisticsDaoTest arrays
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmStatisticsDaoTest arrays ...................................................................... core: VmStatisticsDaoTest arrays Use the elipsis operator instead of ugly, manual, array creation. Change-Id: Iad5ae3344fa70e091f46b6b4e44396c0b6e96d2a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad5ae3344fa70e091f46b6b4e44396c0b6e96d2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmStatisticsDaoTest type inference
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmStatisticsDaoTest type inference ...................................................................... core: VmStatisticsDaoTest type inference Change-Id: I20acb0a57e067cefd3919d7a593cb576c0f93bce Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20acb0a57e067cefd3919d7a593cb576c0f93bce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskImageDynamicDaoTest arrays
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImageDynamicDaoTest arrays ...................................................................... core: DiskImageDynamicDaoTest arrays Remove redundant explicit array creations, and just use the elipsis operator instead. Change-Id: Id0239eaaa6dc5df21e0a53b1d513e1e466686918 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0239eaaa6dc5df21e0a53b1d513e1e466686918 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskImageDynamicDaoTest collcetions
by amureini＠redhat.com 25 May '16

25 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImageDynamicDaoTest collcetions ...................................................................... core: DiskImageDynamicDaoTest collcetions Use Collections.singleton instead of Arrays.asList for single element collections. This achieves two goals: 1. A minute performance improvement 2. It better tests the API by passing a Set instead of List, thus adding another usecase. Change-Id: Ib2d2e6375fef8b8ecfae6a96324b52cd2559c082 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d2e6375fef8b8ecfae6a96324b52cd2559c082 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: oVirt Live 3.6.7_rc1
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.6.7_rc1 ...................................................................... build: oVirt Live 3.6.7_rc1 Change-Id: Idfc77cfe9fa7a9e6d8ca349eb89bd3d88b22d560 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfc77cfe9fa7a9e6d8ca349eb89bd3d88b22d560 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Make video device explicit
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Make video device explicit ...................................................................... Make video device explicit ovirt-engine specifies the video device it requires explicitly. This does the same thing for HE setup to avoid any surprises regarding VDSM reporting these devices. In some cases the implicitly added video devices were not completely reported of omitted by VDSM. Change-Id: I75e80f2d4cb008a6c7567acf872736f1347c4971 Related-to: https://bugzilla.redhat.com/1326810 Related-to: https://bugzilla.redhat.com/1328921 Bug-Url: https://bugzilla.redhat.com/1339306 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/gr-he-setup/vm/configurevm.py M templates/vm.conf.in 3 files changed, 21 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75e80f2d4cb008a6c7567acf872736f1347c4971 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error in OVF disk creation
by tnisan＠redhat.com 25 May '16

25 May '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error in OVF disk creation ...................................................................... core: Fix error in OVF disk creation Change-Id: Ib29a2f9c098b71d7e3d8269a2eb877211f4be903 Bug-Url: https://bugzilla.redhat.com/1339330 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfVolumeForStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib29a2f9c098b71d7e3d8269a2eb877211f4be903 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: build: ovirt-release36-3.6.7_rc1
by sbonazzo＠redhat.com 25 May '16

25 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release36-3.6.7_rc1 ...................................................................... build: ovirt-release36-3.6.7_rc1 Change-Id: Ic990d3a491d95dd1b6c727b23ff01dcd7e2d7837 --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic990d3a491d95dd1b6c727b23ff01dcd7e2d7837 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: v2v-source vms list is cleaned in failure
by tjelinek＠redhat.com 25 May '16

25 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: v2v-source vms list is cleaned in failure ...................................................................... webadmin: v2v-source vms list is cleaned in failure While opening the Webadmin Import VM dialog and importing from VMware source or any other external source (v2v), the "virtual machines on source" list was not cleaned in case of entering invalid parameters. After this fix: if you enter valid parameters and click the "load" button -> the "virtual machines on source" list is displayed. If you then enter incorrect parameters and click the "load" button again (either field validation failure or connection failure), the "virtual machines on source" list is now cleaned while an error is displayed. The bug was opened for VMware but this fix is done for all external sources. Change-Id: I85d5e415a34ad4a92c42bd6763ebadb7698f3372 Bug-Url: https://bugzilla.redhat.com/1298293 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85d5e415a34ad4a92c42bd6763ebadb7698f3372 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fixing not necessary NPEs, asking for dao only when ne...
by alkaplan＠redhat.com 25 May '16

25 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: fixing not necessary NPEs, asking for dao only when needed. ...................................................................... core: fixing not necessary NPEs, asking for dao only when needed. Change-Id: I5f19ea7405f450f76b48018da1c9343e19fe18aa Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 3 files changed, 29 insertions(+), 17 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f19ea7405f450f76b48018da1c9343e19fe18aa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0