- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: correct size unit on export image view
by tnisan＠redhat.com 16 Nov '15

16 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: correct size unit on export image view ...................................................................... webadmin: correct size unit on export image view Disks -> Export Dialog: 'Actual Size' values should be converted using SizeUnit.GiB. Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14 Bug-Url: https://bugzilla.redhat.com/1281288 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/48593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: adding custom bond validation to hostSetupNetwork
by alkaplan＠redhat.com 16 Nov '15

16 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding custom bond validation to hostSetupNetwork ...................................................................... webadmin: adding custom bond validation to hostSetupNetwork adding a non empty validaiton to custom mode. Change-Id: I1c0722d8872a700c5d843a0a4784356794725b9b Bug-Url: https://bugzilla.redhat.com/1167812 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml 4 files changed, 39 insertions(+), 24 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c0722d8872a700c5d843a0a4784356794725b9b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: format SQL files
by emesika＠redhat.com 16 Nov '15

16 Nov '15

Eli Mesika has submitted this change and it was merged. Change subject: db: format SQL files ...................................................................... db: format SQL files Introduce basic SQL formatting and apply on all scripts in dbscripts directory. This is done in order to ease gerrit reviews on DB scripts and make code more readable. Main issues addressed 1) Making a change noticeable in a code line (for example splitting column names, values and parameters each in a separate line 2) Code alignment 3) Keywords in uppercase Work was mainly done using http://poorsql.com/ Next step would be to find a way to automate either formatting or validation See [1] for formatting rules applied in this patch [1] http://www.ovirt.org/index.php?title=OVirt-DB-Issues/formatting Change-Id: I19cc61bad1f11fcf9d7d2c5d2a55ced7758ee3da Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/action_version_map_sp.sql M packaging/dbscripts/ad_groups_sp.sql M packaging/dbscripts/affinity_groups_sp.sql M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/async_tasks_sp.sql M packaging/dbscripts/audit_log_sp.sql M packaging/dbscripts/base_disks_sp.sql M packaging/dbscripts/bookmarks_sp.sql M packaging/dbscripts/business_entity_snapshot_sp.sql M packaging/dbscripts/cluster_features_sp.sql M packaging/dbscripts/cluster_policy_sp.sql M packaging/dbscripts/command_entities_sp.sql M packaging/dbscripts/common_sp.sql M packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_functions.sql M packaging/dbscripts/create_views.sql M packaging/dbscripts/custom_actions_sp.sql M packaging/dbscripts/disk_image_dynamic_sp.sql M packaging/dbscripts/disk_images_sp.sql M packaging/dbscripts/disk_lun_map_sp.sql M packaging/dbscripts/disk_profiles_sp.sql M packaging/dbscripts/drop_db.sql M packaging/dbscripts/dwh_history_timekeeping_sp.sql M packaging/dbscripts/dwh_translation_tables_sp.sql M packaging/dbscripts/engine_backup_log_sp.sql M packaging/dbscripts/engine_sessions_sp.sql M packaging/dbscripts/event_sp.sql M packaging/dbscripts/external_variable_sp.sql M packaging/dbscripts/fence_agents_sp.sql M packaging/dbscripts/gluster_georep_sp.sql M packaging/dbscripts/gluster_hooks_sp.sql M packaging/dbscripts/gluster_server_sp.sql M packaging/dbscripts/gluster_services_sp.sql M packaging/dbscripts/gluster_volume_snapshot_schedule_sp.sql M packaging/dbscripts/gluster_volume_snapshot_sp.sql M packaging/dbscripts/gluster_volumes_sp.sql M packaging/dbscripts/host_device_sp.sql M packaging/dbscripts/image_storage_domain_map_sp.sql M packaging/dbscripts/images_sp.sql M packaging/dbscripts/inst_sp.sql M packaging/dbscripts/iscsi_bonds_sp.sql M packaging/dbscripts/job_sp.sql M packaging/dbscripts/libvirt_secrets_sp.sql M packaging/dbscripts/mac_pools_sp.sql M packaging/dbscripts/materialized_views_sp.sql M packaging/dbscripts/multi_level_administration_sp.sql M packaging/dbscripts/network_sp.sql M packaging/dbscripts/numa_sp.sql M packaging/dbscripts/policy_unit_sp.sql M packaging/dbscripts/providers_sp.sql M packaging/dbscripts/qos_sp.sql M packaging/dbscripts/quota_sp.sql M packaging/dbscripts/repo_files_meta_data_sp.sql M packaging/dbscripts/snapshots_sp.sql M packaging/dbscripts/storage_device_sp.sql M packaging/dbscripts/storages_san_sp.sql M packaging/dbscripts/storages_sp.sql M packaging/dbscripts/system_statistics_sp.sql M packaging/dbscripts/tags_sp.sql M packaging/dbscripts/tags_vm_pool_map_sp.sql M packaging/dbscripts/unregistered_OVF_data_sp.sql M packaging/dbscripts/user_profiles_sp.sql M packaging/dbscripts/user_sp.sql M packaging/dbscripts/vdc_option_sp.sql M packaging/dbscripts/vds_groups_sp.sql M packaging/dbscripts/vds_kdump_status_sp.sql M packaging/dbscripts/vds_sp.sql M packaging/dbscripts/vds_spm_id_map_sp.sql M packaging/dbscripts/vm_device_sp.sql M packaging/dbscripts/vm_icons_sp.sql M packaging/dbscripts/vm_jobs_sp.sql M packaging/dbscripts/vm_pool_maps_sp.sql M packaging/dbscripts/vm_pools_sp.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 76 files changed, 21,220 insertions(+), 15,989 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19cc61bad1f11fcf9d7d2c5d2a55ced7758ee3da Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Do not pass -s with -c
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not pass -s with -c ...................................................................... packaging: engine-backup: Do not pass -s with -c Recent versions of tar do not accept -c (--create) with -s (--same-order). Do not pass -s during create. Bug-Url: https://bugzilla.redhat.com/1282397 Change-Id: I5453cb53189c8ef5ffc66ecf30783ec649aa3536 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5453cb53189c8ef5ffc66ecf30783ec649aa3536 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: filter out some more errors during restore
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: filter out some more errors during restore ...................................................................... packaging: setup: filter out some more errors during restore Add pg 8.4 error about already existing plpgsql. Change-Id: I5b9da78c46e88a9b88039e3d24e7bf4cdb47fdac Bug-Url: https://bugzilla.redhat.com/1244720 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/44879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b9da78c46e88a9b88039e3d24e7bf4cdb47fdac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: Stop gluster processes when host moves to maintenance
by sabose＠redhat.com 16 Nov '15

16 Nov '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Stop gluster processes when host moves to maintenance ...................................................................... gluster: Stop gluster processes when host moves to maintenance Stop glusterd and other gluster processes when a host is moved to maintenance mode, so that data is un-available. Start the glusterd service when host is activated again. starting glusterd service will ensure that all the other gluster services are started. Change-Id: Ib4e00fb30b9d0cc84dcaffe9c89864429470f0aa Bug-Url: https://bugzilla.redhat.com/1205724 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterProcessesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 8 files changed, 76 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e00fb30b9d0cc84dcaffe9c89864429470f0aa Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: hwbi <hwbi2008(a)gmail.com>

1 0

Change in ovirt-engine[master]: webadmin: 'passthrough' vnic should be automatically 'pci-pa...
by alkaplan＠redhat.com 16 Nov '15

16 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: 'passthrough' vnic should be automatically 'pci-passthrough' type ...................................................................... webadmin: 'passthrough' vnic should be automatically 'pci-passthrough' type Bug-Url: https://bugzilla.redhat.com/1269405 Bug-Url: https://bugzilla.redhat.com/1271912 Change-Id: I38f5b631ddd6f6bb86914f0cbfb3e849178a0886 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseInterfaceCreatingManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 2 files changed, 44 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f5b631ddd6f6bb86914f0cbfb3e849178a0886 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dal: Add get BaseDisk list by alias
by rgolan＠redhat.com 16 Nov '15

16 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: dal: Add get BaseDisk list by alias ...................................................................... dal: Add get BaseDisk list by alias Adding a procedure to retrive base disks by alias name. Its mainly required to get the hosted engine direct lun disk quickly for removal. Change-Id: I41e5762c9cf55c4bfb683b11c066877e9e5f6366 Bug-Url: https://bugzilla.redhat.com/1273378 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M packaging/dbscripts/base_disks_sp.sql A packaging/dbscripts/upgrade/04_00_0000_index_base_disks.sql 5 files changed, 34 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41e5762c9cf55c4bfb683b11c066877e9e5f6366 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Log tar creation failures
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Log tar creation failures ...................................................................... packaging: engine-backup: Log tar creation failures Change-Id: I39df58b46fff2e34b04a3d6255bc265006c94031 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39df58b46fff2e34b04a3d6255bc265006c94031 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Fix failure notifications
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix failure notifications ...................................................................... packaging: engine-backup: Fix failure notifications Always check and set FAILURE_NOTIFIED before trying to notify. Without this patch, in certain conditions, we could enter an endless loop while trying to notify the engine about a failure. Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5 Bug-Url: https://bugzilla.redhat.com/1240923 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieade3725a9a932c98cfc4e443e4f0c6b96d041d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0