- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageDomainCommandBase early return
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainCommandBase early return ...................................................................... core: StorageDomainCommandBase early return Use the early retun idiom for better readability. Change-Id: Iba20a266e5656556223d79a06bc8a2ce631a834b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 10 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/48156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba20a266e5656556223d79a06bc8a2ce631a834b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix remove vm from export domain
by ahadas＠redhat.com 15 Nov '15

15 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix remove vm from export domain ...................................................................... core: fix remove vm from export domain The injection of BackendInternal broke import from export domain. The problem was that in the constructor of RemoveVmCommand we called getVm() that invokes a query to get the VM from the export domain. However, BackendInternal is not injected at this stage so NPE is thrown. The solution is to extract the initialization code in RemoveVmCommand into the 'init' method that is called after the object is constructed, including its injected fields. Change-Id: Ieb4cd5f4b301d73a996ad4acc505fd8bb42e29fd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/48576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4cd5f4b301d73a996ad4acc505fd8bb42e29fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: add missing 'NETWORK_MAC_ADDRESS_IN_USE' entry to Ap...
by alkaplan＠redhat.com 15 Nov '15

15 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add missing 'NETWORK_MAC_ADDRESS_IN_USE' entry to AppError.java ...................................................................... engine: add missing 'NETWORK_MAC_ADDRESS_IN_USE' entry to AppError.java It was removed by mistake in patch- I06248e23e32b7ca2e7f3397e8c0e28e24eb20bf5 Change-Id: Ifaf72f04194bf255d1b8353082f837dc98bbcd4e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaf72f04194bf255d1b8353082f837dc98bbcd4e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove GetVGList*
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVGList* ...................................................................... core: Remove GetVGList* GetVGList query returns all the VGs a host can access that are not correlated to storage domains saved in the database. It is only used in BackendHostStorageResource, where it is used to retrieve connection information. This information is redundant, as it's always used together with the connections related to GetDeviceList, which retrieves devices related to VGs too, anyway. This patch removes this entire redundant query, cleaning up the code and improving the performance of hosts/{hostId}/storage and hosts/{hostId}/storage/{storageId} by a significant factor. This patch includes: 1. Removing the redundant calls to GetVgList in BackendHostStorageResource and amending the test accordingly. 2. Removing GetVgListQuery class and the corresponding constant from VdcQueryType, now that there are no more usages for it. 3. Removing GetVGListVDSCommand, the corresponding constant in VDSCommandType, the corresponding methods in IVdsServer and its implementations and the related VGListReturnForXmlRpc class, now that there are no more usages for it. Change-Id: Ie16e0da825e74defd0aada439b58bb25e93bc802 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVgListQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 11 files changed, 6 insertions(+), 255 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/48525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie16e0da825e74defd0aada439b58bb25e93bc802 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.5]: UI: sysprep attached by default in run once dialog.
by tnisan＠redhat.com 15 Nov '15

15 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: UI: sysprep attached by default in run once dialog. ...................................................................... UI: sysprep attached by default in run once dialog. Needs to attach on the first run only if there is sysprep data. Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27 Bug-Url: https://bugzilla.redhat.com/1240900 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsDao - adding getAllForStoragePoolAndStatuses()
by laravot＠redhat.com 15 Nov '15

15 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: VdsDao - adding getAllForStoragePoolAndStatuses() ...................................................................... core: VdsDao - adding getAllForStoragePoolAndStatuses() This patch adds getAllForStoragePoolAndStatuses() to VdsDAO to provide abillity to get hosts in different statuses in one db call instead of calling getAllForStoragePoolAndStatus() multiple times and/or perform filtering on the calling side. Change-Id: I5984d5e683b8ae18268248cedb22c1ea66987037 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IdentifiableUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java M packaging/dbscripts/create_functions.sql M packaging/dbscripts/vds_sp.sql 6 files changed, 69 insertions(+), 11 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5984d5e683b8ae18268248cedb22c1ea66987037 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: IrsProxyData.updateVdsDomainsData() - separation to me...
by laravot＠redhat.com 15 Nov '15

15 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: IrsProxyData.updateVdsDomainsData() - separation to methods ...................................................................... core: IrsProxyData.updateVdsDomainsData() - separation to methods This patch separates the logic contained in updateVdsDomainsData() into different methods for simplification and easier maintenance. Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 111 insertions(+), 82 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56124dc1a1511a41af2eda2649dc4f4640d35c76 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: more accurate audit log when domain is deactivated
by laravot＠redhat.com 15 Nov '15

15 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: more accurate audit log when domain is deactivated ...................................................................... core: more accurate audit log when domain is deactivated when a Storage Domain is being deactivated it first moves to "Preparing for maintenance" status and only when it's confirmed that its not accessed (by monitoring) from any host it moves to Maintenance status. However, currently when it moves to "Preparing for maintenance" the audit log indicates that the domain was deactivated and when it actually moves to Maintenance there's no audit log at all. This patch fixes the current audit log and adds a new one for the time the domain status is changed to Maintenance. Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc Bug-Url: https://bugzilla.redhat.com/1247957 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 4 files changed, 26 insertions(+), 11 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia64ce39aeeb4a8874a6c92dc4b337e7e4b1664bc Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: support domains maintenance on more hosts statuses
by laravot＠redhat.com 15 Nov '15

15 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: support domains maintenance on more hosts statuses ...................................................................... core: support domains maintenance on more hosts statuses When a domain is being deactivated its status is changed to PreparingForMaintenance. When it's confirmed that no host in the DC access it (according to the host domain monitoring report) its status is changed to Maintenance. The domain monitoring results of hosts in status other then Up status aren't being analyzed, therfore when there is a host in that status deactivated domains will remain in "Preparing for maintenance". An example for a relevant status is NonOperational, As host can be in Non operational due to various reasons, the domain monitoring results of such hosts should be anazlyzed as well when inspecting if a domain can be moved to maintenance status because if the domain isn't accessed it can move safely to "maintenance". As part of this change when a domain is deactivated the pool information is refreshed on hosts in the relevant statuses in dc that uses the memory backend (to not extend of risk on long connectStoragePool for non operational hosts as the metadata is stored on the storage). While in DC that stores the metadata on storage the metadata refresh will occur by the host recovery mechanism. The domain monitoring report of those hosts is then inspected as well to allow the domain to move to maintenance. In this patch I've added only the NonOperational status as one as the inspected statuses - if it'll be needed we can add other statuses as well. Change-Id: I767106d429f0d8b4bd24b0f539b9a91204be18e9 Bug-Url: https://bugzilla.redhat.com/1256841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java 6 files changed, 63 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roy Golan: Looks good to me, but someone else must approve Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I767106d429f0d8b4bd24b0f539b9a91204be18e9 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: decide whether to process domain monitoring in IrsProx...
by laravot＠redhat.com 15 Nov '15

15 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: decide whether to process domain monitoring in IrsProxyData ...................................................................... core: decide whether to process domain monitoring in IrsProxyData Currently the decision on whether it's needed to process the recevied monitoring data is done in IrsBrokerCommand, as this method is supposed to be used only as a proxy to the actual processing method - it makes more sense to have the logic on when we should consider the report that, otherwise each caller will need to copy that logic. Change-Id: I2c87698477d6fbb7023b3e7f39eac4af62e91f64 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c87698477d6fbb7023b3e7f39eac4af62e91f64 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0