- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-backup: Do not log cmdline parsing errors
by sbonazzo＠redhat.com 16 Nov '15

16 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not log cmdline parsing errors ...................................................................... packaging: engine-backup: Do not log cmdline parsing errors That's especially important for the error about missing log file. Others are also not important to log - we want to log actual failures caught during backup. Bug-Url: https://bugzilla.redhat.com/1240923 Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/48590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id804aeabf3f16cf52a372b07db7d4dcb741b4636 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Block Hotplug/unplug 'pci-passthrough' vNIC types
by alkaplan＠redhat.com 16 Nov '15

16 Nov '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Block Hotplug/unplug 'pci-passthrough' vNIC types ...................................................................... engine: Block Hotplug/unplug 'pci-passthrough' vNIC types Bug-Url: https://bugzilla.redhat.com/1273486 Change-Id: Ic7b32ad027016c0d95dd05ab0abbd176951c4be9 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImplTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 65 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7b32ad027016c0d95dd05ab0abbd176951c4be9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: correct size unit on export image view
by tnisan＠redhat.com 16 Nov '15

16 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: correct size unit on export image view ...................................................................... webadmin: correct size unit on export image view Disks -> Export Dialog: 'Actual Size' values should be converted using SizeUnit.GiB. Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14 Bug-Url: https://bugzilla.redhat.com/1281288 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/48589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc93b41ff6ff5c557efe2614493586d622d4de14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseIscsiBondCommand lambdas
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseIscsiBondCommand lambdas ...................................................................... core: BaseIscsiBondCommand lambdas Replaced BaseIscsiBondCommand's usage of LinqUtils with Java 8's built-in labmda capabilities. Performance is improved by iterating the map's entrySet() instead of iterating the keySet() and calling get(key). Change-Id: I38055254de67cff1e962d1265592fce774cd9c2f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38055254de67cff1e962d1265592fce774cd9c2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveStoragePoolCommand labmdas
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStoragePoolCommand labmdas ...................................................................... core: RemoveStoragePoolCommand labmdas Removed LinqUtils and replaced with the modern, built-in Java 8 syntax. Change-Id: I2cfcb83617b9ff492d60d5c0010d7aa76c1048b9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 6 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cfcb83617b9ff492d60d5c0010d7aa76c1048b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FenceVdsManualyCommand early return
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: FenceVdsManualyCommand early return ...................................................................... core: FenceVdsManualyCommand early return Use the early return idiom in FenceVdsManualyCommand#canDoAction() to reduce code and improve readability. Change-Id: I8d412524f1bfc1363d205d7d563e7322a1cdd166 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d412524f1bfc1363d205d7d563e7322a1cdd166 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FenceVdsManualyCommand finding master domain
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: FenceVdsManualyCommand finding master domain ...................................................................... core: FenceVdsManualyCommand finding master domain Improve performance by querying the master domain from the database instead of querying all the domains in the pool and filtering the master domain in-memory. Change-Id: I552944050f515f5f2f0bb214a6d0e98a9b8c6d9a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I552944050f515f5f2f0bb214a6d0e98a9b8c6d9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshLunsSizeCommand linq usage
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RefreshLunsSizeCommand linq usage ...................................................................... core: RefreshLunsSizeCommand linq usage Replace the usage of LinqUtils.first() with the Java 8 built in streaming API, as part of the attempt to remove LinqUtils from the codebase. Change-Id: I1e062c351a4cdbb8bff243ac3395942f92bc7f0c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e062c351a4cdbb8bff243ac3395942f92bc7f0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshLunsSizeCommand method args
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RefreshLunsSizeCommand method args ...................................................................... core: RefreshLunsSizeCommand method args Removed unused parameter from checkLunsInStorageDomain. Change-Id: I4f04b4009651968c05449558c2b8d98724c4d0fb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f04b4009651968c05449558c2b8d98724c4d0fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: detaching master domain cleanup
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: detaching master domain cleanup ...................................................................... core: detaching master domain cleanup The LinqUtils call in StorageDomainCommandBase#isDetachAllowed(boolean) is useless - it retrieves a domain from the pool that has the same ID of the domain being removed (i.e., the exact same domain) and an "Active" status. The previous call to checkStorageDomainStatus in canDetachDomain ensures its status will be "Maintenance" or "Inactive", so it's known to return an null. Since its result is known, it can be skipped, and save a relatively expensive database call. Change-Id: Iff87f89170d555d98ec071b42e46f3dff1883b1b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 3 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/48155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff87f89170d555d98ec071b42e46f3dff1883b1b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0