- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: moving reportingVdsStatus constant from IrsBrokerCommand
by laravot＠redhat.com 15 Nov '15

15 Nov '15

Liron Aravot has submitted this change and it was merged. Change subject: core: moving reportingVdsStatus constant from IrsBrokerCommand ...................................................................... core: moving reportingVdsStatus constant from IrsBrokerCommand This patch moves the reportingVdsStatus constant to StoragePoolDomainHelper and changes it to be a Set. Change-Id: Ib369139ba0ae6953fb22d9bf35f640cff93ef858 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib369139ba0ae6953fb22d9bf35f640cff93ef858 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix NPE on scheduler when policy filters is null
by tnisan＠redhat.com 15 Nov '15

15 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix NPE on scheduler when policy filters is null ...................................................................... core: fix NPE on scheduler when policy filters is null Patch NPE exception if there are no filters. Fix for patch https://gerrit.ovirt.org/#/c/44244/ Change-Id: I9f121d6f78c0aaea98d4008ff71f3e5f3f6fb0fc Bug-Url: http://bugzilla.redhat.com/1256238 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b74f7a057d74b2f6b0ed0dbde8de2e5daad47b4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Rename parameter in getLUNs
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Rename parameter in getLUNs ...................................................................... core: Rename parameter in getLUNs Renamed the storageDomainId parameter in getLUNs so it doesn't hide the data member of the same name. Change-Id: Iccfb4c75a928a0dee04a68263088ad864ae4184a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccfb4c75a928a0dee04a68263088ad864ae4184a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant parameter
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant parameter ...................................................................... core: Remove redundant parameter The storageDomainId parameter was in fact hiding a data member of the same name, that was always passed to this method. Hence, declaring it as a parameter is both redundant and confusing. Change-Id: Iac4faafe24273955988f845865260857c6ec7932 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4faafe24273955988f845865260857c6ec7932 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant local variable
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove redundant local variable ...................................................................... core: Remove redundant local variable Change-Id: I68acd634e563d0110773447d0b75263a0ff3a206 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68acd634e563d0110773447d0b75263a0ff3a206 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: assertEquals argument order
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: assertEquals argument order ...................................................................... core: assertEquals argument order Change-Id: I665f4be52b45ada38fcbd7b501764078d623a9a5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I665f4be52b45ada38fcbd7b501764078d623a9a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make private helper methods static
by amureini＠redhat.com 15 Nov '15

15 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make private helper methods static ...................................................................... core: Make private helper methods static Change-Id: I147231a587e5e17405c256fa1d9ee6b0c417abb3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I147231a587e5e17405c256fa1d9ee6b0c417abb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Handle incorrect user and group identifiers
by tnisan＠redhat.com 15 Nov '15

15 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Handle incorrect user and group identifiers ...................................................................... restapi: Handle incorrect user and group identifiers Currently the RESTAPI doesn't check the format of user or group identifiers provided by the caller, it just tries to convert them assuming that they are hexadecimal characters. If this fails the exception isn't handled properly and stack trace is returned to the user. This patch changes the relevant resources so that they handle the exception and return the expected HTTP response codes. Change-Id: I1bf0139fd329f63e542d24b8d9f0115e8e7b6c80 Bug-Url: https://bugzilla.redhat.com/1281803 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 549ce58658212b749e02fdfe59beace518ab598a) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUserResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java 4 files changed, 36 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bf0139fd329f63e542d24b8d9f0115e8e7b6c80 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Filter domains by query, not by code
by amureini＠redhat.com 13 Nov '15

13 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Filter domains by query, not by code ...................................................................... core: Filter domains by query, not by code Change-Id: I5b59acce7ff1e73d140ab976a6f03509f011e4d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b59acce7ff1e73d140ab976a6f03509f011e4d2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: packaging: don't touch selinux
by sbonazzo＠redhat.com 13 Nov '15

13 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: don't touch selinux ...................................................................... packaging: don't touch selinux avoid to change selinux enforcements within the Makefile. it's not something that a build system should do. Change-Id: I521967df253025b4a7ad048a0e457715e7d41366 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521967df253025b4a7ad048a0e457715e7d41366 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0