- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: use Collections.singletonList instead of Arrays.asList
by amureini＠redhat.com 10 Nov '15

10 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: backend: use Collections.singletonList instead of Arrays.asList ...................................................................... backend: use Collections.singletonList instead of Arrays.asList When building a list with one node only and with no requirement for adding or removing nodes from the list, it's better to use Collections.singletonList for performance reasons. Change-Id: I0cab98ea362d708712716e956e437e1eeff83d4d Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cab98ea362d708712716e956e437e1eeff83d4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: call GetDeviceList when specifying host in AddDiskC...
by amureini＠redhat.com 10 Nov '15

10 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: backend: call GetDeviceList when specifying host in AddDiskCommand ...................................................................... backend: call GetDeviceList when specifying host in AddDiskCommand When creating a direct lun, if the host id is passed through the parameters to AddDiskCommand, GetDeviceList will be called to get the lun from vdsm. This way, passing the host id will cause AddDiskCommand to store the up to date details of the lun in the db. Change-Id: I27c3b6ba5699e259ede693bf48717687cff3eecb Bug-Url: https://bugzilla.redhat.com/1275649 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 4 files changed, 75 insertions(+), 74 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/48285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27c3b6ba5699e259ede693bf48717687cff3eecb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add missing warning message in storage domain popup
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add missing warning message in storage domain popup ...................................................................... webadmin: Add missing warning message in storage domain popup Patches c273cd696323bab805bc3396b33b8953aa18f518 and 9dd1711da87bbc7dca9b6e7d6c84e9ac06396af8 introduced changes to the NFS and Posix storage view but by mistake removed also the error message in those views causing the storage popup not to show errors in storage domain creation/edit among those errors the error of a path that already exists in the system, this patch restores the error label so the error will appear Change-Id: I74274212099014a5eb5f081629e39a705bb4b6fe Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1279192 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74274212099014a5eb5f081629e39a705bb4b6fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Opteron G2 and newer allowed for Windows 10 guest OS
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Opteron G2 and newer allowed for Windows 10 guest OS ...................................................................... core: Opteron G2 and newer allowed for Windows 10 guest OS KVM QE found following combinations as working: * Host OS: RHEL6.7-z * Machine type: rhel6.5.0/rhel6.6.0 * Guest OS: Win10 (both 32 and 64 bit) * CPU: Opteron G2, G3, G4, G5 Thus we decided to enable these CPUs with guest OS Windows 10 and machine type 7.2. Change-Id: I87f7db295a5a0a12870b8ce1925bc08999d09419 Bug-Url: https://bugzilla.redhat.com/1277214 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87f7db295a5a0a12870b8ce1925bc08999d09419 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove remains of JPA/Hibernate configuration
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove remains of JPA/Hibernate configuration ...................................................................... core: Remove remains of JPA/Hibernate configuration Removes remains of JPA/Hibernate configurations from application server configuration file. Change-Id: Ic0c5ac4bc6838c8d58fc711a51cf818e84b3ba3c Bug-Url: https://bugzilla.redhat.com/1279767 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0c5ac4bc6838c8d58fc711a51cf818e84b3ba3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: manage-domains: Fix issue with domain in upper case
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: manage-domains: Fix issue with domain in upper case ...................................................................... manage-domains: Fix issue with domain in upper case Converts domain specified on command line to lower case, because manage-domains doesn't work properly with domains in upper/mixed case. The issue was cause in patch I983b60824e31f279df0fe11c8adeb34b16f56e6a. Change-Id: Ied3ab5d8820119477c4c5a1942d2a0f14b72a8c8 Bug-Url: https://bugzilla.redhat.com/1279798 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied3ab5d8820119477c4c5a1942d2a0f14b72a8c8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Opteron G2 and newer allowed for Windows 10 guest OS
by ahadas＠redhat.com 10 Nov '15

10 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Opteron G2 and newer allowed for Windows 10 guest OS ...................................................................... core: Opteron G2 and newer allowed for Windows 10 guest OS KVM QE found following combinations as working: * Host OS: RHEL6.7-z * Machine type: rhel6.5.0/rhel6.6.0 * Guest OS: Win10 (both 32 and 64 bit) * CPU: Opteron G2, G3, G4, G5 Thus we decided to enable these CPUs with guest OS Windows 10 and machine type 7.2. Change-Id: I87f7db295a5a0a12870b8ce1925bc08999d09419 Bug-Url: https://bugzilla.redhat.com/1277214 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87f7db295a5a0a12870b8ce1925bc08999d09419 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Metamodel improvements
by juan.hernandez＠redhat.com 10 Nov '15

10 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Metamodel improvements ...................................................................... restapi: Metamodel improvements This patch introduces some improvements to the metadel that are required for the JAX-RS code generator that will be introduced in a later patch. The more relevant changes are the introduction of service inheritance and the distinction between "declared" and "all" attributes. Change-Id: I28043ef262d646bcd2b0638ed748dc5073bb6365 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnalyzer.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Module.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Service.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/StructType.java M backend/manager/modules/restapi/metamodel/concepts/src/main/java/org/ovirt/api/metamodel/concepts/Type.java M backend/manager/modules/restapi/metamodel/tool/src/main/java/org/ovirt/api/metamodel/tool/SchemaGenerator.java 6 files changed, 320 insertions(+), 79 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28043ef262d646bcd2b0638ed748dc5073bb6365 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: periodic reduce by 20 for abandoning and warnings
by eedri＠redhat.com 10 Nov '15

10 Nov '15

Eyal Edri has submitted this change and it was merged. Change subject: periodic reduce by 20 for abandoning and warnings ...................................................................... periodic reduce by 20 for abandoning and warnings Change-Id: I991eb820dfc2a45fde2878a747a0ba2539220b39 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for review -- To view, visit https://gerrit.ovirt.org/48341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I991eb820dfc2a45fde2878a747a0ba2539220b39 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Generate parse tables during build
by juan.hernandez＠redhat.com 10 Nov '15

10 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Generate parse tables during build ...................................................................... cli: Generate parse tables during build Currently the parse tables used by ply are generated during the RPM installation, or, for non RPM platforms, during runtime. This causes warnings because the user running the CLI may not have permissions to write those parse tables. To avoid those warnings this patch changes the CLI build process so that the parse tables are generated from the "setup.py" script and included in the binary distribution. Change-Id: I933a56b3ccbf5bc0e39feed9a2c61be89970dd84 Bug-Url: https://bugzilla.redhat.com/1255409 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 657752f46c3f657be6c09cdcc3f89f6f9b1f0fc3) --- M ovirt-engine-cli.spec.in M setup.py M src/cli/plyparse.py 3 files changed, 36 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I933a56b3ccbf5bc0e39feed9a2c61be89970dd84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0