- Engine-commits - oVirt List Archives

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: engine_page: Add validation for None type
by dougsland＠redhat.com 10 Nov '15

10 Nov '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Add validation for None type ...................................................................... engine_page: Add validation for None type Currently there is no validation which might break when users try to set the root password using TUI. This patch adds the validation. Change-Id: Ieb20d1563fa9d13f1d266942a8fb8486da1882ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279329 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/48319 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> (cherry picked from commit 761bee37a93b6557e0729e499169a7c96f936c54) Reviewed-on: https://gerrit.ovirt.org/48381 --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb20d1563fa9d13f1d266942a8fb8486da1882ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: Add validation for None type
by dougsland＠redhat.com 10 Nov '15

10 Nov '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Add validation for None type ...................................................................... engine_page: Add validation for None type Currently there is no validation which might break when users try to set the root password using TUI. This patch adds the validation. Change-Id: Ieb20d1563fa9d13f1d266942a8fb8486da1882ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279329 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/48319 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Fabian Deutsch: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb20d1563fa9d13f1d266942a8fb8486da1882ca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm: add missing builder for fc23
by sbonazzo＠redhat.com 10 Nov '15

10 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: add missing builder for fc23 ...................................................................... vdsm: add missing builder for fc23 Change-Id: Icaa66988713f22de517eba007b2a2f5a05c1bf6c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/48380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaa66988713f22de517eba007b2a2f5a05c1bf6c Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm: Adding fc23 builds
by sbonazzo＠redhat.com 10 Nov '15

10 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: Adding fc23 builds ...................................................................... vdsm: Adding fc23 builds Requires https://gerrit.ovirt.org/48180 Change-Id: I6c6db03d3ca6aa07a3abac9333f07d21e6926470 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge David Caro: Verified -- To view, visit https://gerrit.ovirt.org/48182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c6db03d3ca6aa07a3abac9333f07d21e6926470 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: NPE in GLUSTERFSStorageHelper
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: NPE in GLUSTERFSStorageHelper ...................................................................... engine: NPE in GLUSTERFSStorageHelper Fixing the ConnectHostToStoragePoolServersParameters constructor, to include 'StoragePool'. In the flow of refreshing storage connections and pool metada due to Vdsm reports, the ConnectHostToStoragePoolServersParameters constructor was used without 'StoragePool'. Several classes like CINDERStorageHelper and GLUSTERFSStorageHelper are expecting the parameter to have a StoragePool populated. Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138 Bug-Url: https://bugzilla.redhat.com/1277570 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConnectHostToStoragePoolServersParameters.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Amit Aviram: Looks good to me, but someone else must approve Freddy Rolland: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add missing warning message in storage domain popup
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add missing warning message in storage domain popup ...................................................................... webadmin: Add missing warning message in storage domain popup Patches c273cd696323bab805bc3396b33b8953aa18f518 and 9dd1711da87bbc7dca9b6e7d6c84e9ac06396af8 introduced changes to the NFS and Posix storage view but by mistake removed also the error message in those views causing the storage popup not to show errors in storage domain creation/edit among those errors the error of a path that already exists in the system, this patch restores the error label so the error will appear Change-Id: I74274212099014a5eb5f081629e39a705bb4b6fe Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1279192 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74274212099014a5eb5f081629e39a705bb4b6fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: UI: sysprep attached by default in run once dialog.
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: UI: sysprep attached by default in run once dialog. ...................................................................... UI: sysprep attached by default in run once dialog. Needs to attach on the first run only if there is sysprep data. Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1190663 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75a1bc4dce36337d14baeae8101b803706d2fd27 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Run Once dialog > Host: widgets alignment
by tnisan＠redhat.com 10 Nov '15

10 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Run Once dialog > Host: widgets alignment ...................................................................... webadmin: Run Once dialog > Host: widgets alignment Vertical alignment of widgets in Run Once dialog, Host part Change-Id: I3f0cc01d1f744be069037a4df550e108692fd070 Bug-Url: https://bugzilla.redhat.com/1269092 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f0cc01d1f744be069037a4df550e108692fd070 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change enum JSON deserialization
by masayag＠redhat.com 10 Nov '15

10 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Change enum JSON deserialization ...................................................................... core: Change enum JSON deserialization This patch introduces an enum deserializer to replace the behavior that in case of an unnown literal an exception would be thrown. This may happen in the future, if a Command parameter class with an enum field is stored in DB, and then oVirt engine is upgraded, and the new code contains a change in the enum literal. Change-Id: Ie9d6f2e4a02eeda999e525101c2f54789a34cfaf Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonEnumDeserializer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerFactory.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerProvider.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerTest.java 5 files changed, 108 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/17951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9d6f2e4a02eeda999e525101c2f54789a34cfaf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm: fix extra repos for fc23
by sbonazzo＠redhat.com 10 Nov '15

10 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: fix extra repos for fc23 ...................................................................... vdsm: fix extra repos for fc23 Change-Id: I596991bcf4c2fa3dfde4d2f5182f20cbe25a2b7b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml M jobs/confs/projects/vdsm/vdsm_create_libgfapi-rpms.yaml M jobs/confs/projects/vdsm/vdsm_install-rpm-sanity.yaml 3 files changed, 2 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I596991bcf4c2fa3dfde4d2f5182f20cbe25a2b7b Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0