- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "engine: IntegerValidation refactor"
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: IntegerValidation refactor" ...................................................................... Revert "engine: IntegerValidation refactor" This patch reverts commit 314cb377bdaa42e5bfc67c828051db36364e603f which caused a bug that made it impossible to create storage domains in the engine Bug-Url: https://bugzilla.redhat.com/1277664 Bug-Url: https://bugzilla.redhat.com/1277667 Change-Id: I731d91126398fa54695e40cf314eac63ca7ffbe6 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IntegerValidation.java D frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/IntegerValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 78 insertions(+), 90 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I731d91126398fa54695e40cf314eac63ca7ffbe6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: snapshot with multiple cinder disks reported as failed
by derez＠redhat.com 04 Nov '15

04 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: snapshot with multiple cinder disks reported as failed ...................................................................... core: snapshot with multiple cinder disks reported as failed Creation of a snapshot with multiple Cinder disks is reported as a failure since 'endAction' is invoked for each disk. Hence, ensuring a single invocation by checking the size of child commands list. Change-Id: If42c8f940531bf3b3ad46e0b7baf72d1939d7436 Bug-Url: https://bugzilla.redhat.com/1277558 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42c8f940531bf3b3ad46e0b7baf72d1939d7436 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Rename cpu-type IBM POWER 8
by oliel＠redhat.com 04 Nov '15

04 Nov '15

Ori Liel has submitted this change and it was merged. Change subject: engine: Rename cpu-type IBM POWER 8 ...................................................................... engine: Rename cpu-type IBM POWER 8 Change "IBM POWER 8" to "IBM POWER8". The displayed value comes from the database, so accordingly the changes are in the DB scripts. Bug-URL: https://bugzilla.redhat.com/1248867 Change-Id: Ib82590d829b577fc6612b73b1de279109edaf9c1 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1950_rename_cpu_type_ibm_power_8.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 9 insertions(+), 7 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib82590d829b577fc6612b73b1de279109edaf9c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: build: ovirt-engine-3.5.6.2
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-3.5.6.2 ...................................................................... build: ovirt-engine-3.5.6.2 Change-Id: Ice1339b382515698138975534bd7ad83cba95be1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dependencies/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 52 files changed, 54 insertions(+), 51 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice1339b382515698138975534bd7ad83cba95be1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: String broken in 'New or Edit Network Interface' d...
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: String broken in 'New or Edit Network Interface' dialog ...................................................................... webadmin: String broken in 'New or Edit Network Interface' dialog String broken in 'New or Edit Network Interface' dialog when [ja_JP] [es_ES]. Up and down status changed from horizontal to vertical layout Change-Id: Ieaa26fb7fd1b742d536807d2449fce8090284212 Bug-Url: https://bugzilla.redhat.com/1183462 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieaa26fb7fd1b742d536807d2449fce8090284212 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-engine: drop 3.6.0 jobs
by dcaro＠redhat.com 04 Nov '15

04 Nov '15

David Caro has submitted this change and it was merged. Change subject: ovirt-engine: drop 3.6.0 jobs ...................................................................... ovirt-engine: drop 3.6.0 jobs 3.6.0 is going to go GA today, no more builds on this branch. Change-Id: I6196da61dfa669e52ff5a8af55c3b296220a8ad2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for review Jenkins CI: Passed CI tests David Caro: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/48050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6196da61dfa669e52ff5a8af55c3b296220a8ad2 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.0
by sbonazzo＠redhat.com 04 Nov '15

04 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.0 ...................................................................... build: ovirt-live-3.6.0 Change-Id: I772cebf2f5e2237d3434f1fa51589eae733172aa Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I772cebf2f5e2237d3434f1fa51589eae733172aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: External VMs can be created on PPC
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: External VMs can be created on PPC ...................................................................... core: External VMs can be created on PPC External VM creation is properly handled on PPC by setting: - default operating system - default graphics device Change-Id: I339e6556c3ee29a72bc78599dfed26693a2e226b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1170219 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java 1 file changed, 46 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339e6556c3ee29a72bc78599dfed26693a2e226b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix detection of preferred hosts for numa nodes
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix detection of preferred hosts for numa nodes ...................................................................... core: Fix detection of preferred hosts for numa nodes This fixes two things: When adding new numa nodes through the rest api or the numa support dialog in the host context menu, the detection of the preferred hosts failed in AddVmNumaNodesCommand#canDoAction. When creating or updating VMs, the first time the admin switched to "non migratable", the detection of the preferred hosts failed. This led to the situation where the whole VM was created, except for the numa nodes. When updating a VM all numa nodes were deleted and could not be added again. So the whole numa configuration disappeared. Bug-Url: https://bugzilla.redhat.com/1248049 Bug-Url: https://bugzilla.redhat.com/1256725 Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java 2 files changed, 143 insertions(+), 1 deletion(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal: Fixed New Template dialog size
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Fixed New Template dialog size ...................................................................... userportal: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it. Also had to change the size of the DisksAllocationView to make it look better. Change-Id: I0de8d2a6b39b352da01f3ea9b551bb899927205e Bug-Url: https://bugzilla.redhat.com/1220128 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de8d2a6b39b352da01f3ea9b551bb899927205e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0