- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: sdk: Remove -Xdoclint in EL6 and EL7
by juan.hernandez＠redhat.com 05 Nov '15

05 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Remove -Xdoclint in EL6 and EL7 ...................................................................... sdk: Remove -Xdoclint in EL6 and EL7 The "-Xdoclint" option isn't available in the version of the Javadoc tool available in the EL6 and EL7 distributions. This patch changes the spec files so that they remove it from the POM before the build. Change-Id: I18f0dd87b91bb5c19e3bcf1114985fa3c19575bc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/spec.el6.in M sdk/spec.el7.in 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18f0dd87b91bb5c19e3bcf1114985fa3c19575bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-engine-wildfly-overlay: split version 8 and 10
by sbonazzo＠redhat.com 05 Nov '15

05 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-wildfly-overlay: split version 8 and 10 ...................................................................... ovirt-engine-wildfly-overlay: split version 8 and 10 Change-Id: Ib356a331bece7899ef7259b21731df95b86f7860 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml 1 file changed, 24 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib356a331bece7899ef7259b21731df95b86f7860 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Add -Xdoclint:none to the Javadoc options
by juan.hernandez＠redhat.com 05 Nov '15

05 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add -Xdoclint:none to the Javadoc options ...................................................................... sdk: Add -Xdoclint:none to the Javadoc options This patch adds "-Xdoclint:none" to the Javadoc optins, as otherwise recent versions of the Javadoc tool fail the build because they don't accept some of the constructs that we use in the Javadoc comments. Change-Id: Ic9930b26213b8c0411884b413d37aa178befa72e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/pom.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9930b26213b8c0411884b413d37aa178befa72e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: userportal, webadmin: boolean params not always parsed well f...
by tnisan＠redhat.com 05 Nov '15

05 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: boolean params not always parsed well for browser plugins ...................................................................... userportal,webadmin: boolean params not always parsed well for browser plugins The GWT JSNI sometimes returns the boolean as int and it needs to be casted back to boolean Change-Id: I715bae32006945ce5faa49402832742f25ac5e8e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1272181 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1273031 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715bae32006945ce5faa49402832742f25ac5e8e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: disbale rebalance for non distribute volumes
by sabose＠redhat.com 04 Nov '15

04 Nov '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: disbale rebalance for non distribute volumes ...................................................................... gluster: disbale rebalance for non distribute volumes Disable gluster volume rebalance option for non distribute volume in UI. Change-Id: I9455294afe5f42c21922356b788079e9325c6714 Bug-Url: https://bugzilla.redhat.com/1261516 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Kanagaraj M: Looks good to me, approved Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/48088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9455294afe5f42c21922356b788079e9325c6714 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: snapshot with multiple cinder disks reported as failed
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: snapshot with multiple cinder disks reported as failed ...................................................................... core: snapshot with multiple cinder disks reported as failed Creation of a snapshot with multiple Cinder disks is reported as a failure since 'endAction' is invoked for each disk. Hence, ensuring a single invocation by checking the size of child commands list. Change-Id: If42c8f940531bf3b3ad46e0b7baf72d1939d7436 Bug-Url: https://bugzilla.redhat.com/1277558 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42c8f940531bf3b3ad46e0b7baf72d1939d7436 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: avoid NPE on add template when balloonEnabled is null
by tnisan＠redhat.com 04 Nov '15

04 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: avoid NPE on add template when balloonEnabled is null ...................................................................... core: avoid NPE on add template when balloonEnabled is null When importing an image as template from Glance, 'balloonEnabled' is null. Consequently, an NPE is thrown on VmDeviceUtils -> copyVmDevices. Since 'balloonEnabled' been defaulted to null on I16adef671bc77e26f56657add59621a1aa9b1c4a, fixed by comparing to TRUE. Change-Id: Ie54212974b8deea6141d0a1b07dca393565e1dc0 Bug-Url: https://bugzilla.redhat.com/1275629 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie54212974b8deea6141d0a1b07dca393565e1dc0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove redundant a return statement
by derez＠redhat.com 04 Nov '15

04 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: core: remove redundant a return statement ...................................................................... core: remove redundant a return statement Removed a redundant return statement on CreateCinderSnapshotCommand. Change-Id: Iaeab1f3c482af12164ce9e42aea344370321436d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeab1f3c482af12164ce9e42aea344370321436d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: v2v is not handling 32bit vms
by shavivi＠redhat.com 04 Nov '15

04 Nov '15

Shahar Havivi has submitted this change and it was merged. Change subject: engine: v2v is not handling 32bit vms ...................................................................... engine: v2v is not handling 32bit vms Change-Id: I3cae7a8c1b7178c2094a7451d1cd1320c1c9f368 Bug-Url:https://bugzilla.redhat.com/1277452 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cae7a8c1b7178c2094a7451d1cd1320c1c9f368 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal: Only assignable roles shown on VM/Template permi...
by tjelinek＠redhat.com 04 Nov '15

04 Nov '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Only assignable roles shown on VM/Template permission tab ...................................................................... userportal: Only assignable roles shown on VM/Template permission tab In userportal: The "Role to Assign" drop down list on VM/Template Permission Popup View shows: - only non-admin roles when logged as a standard user - all roles (admin+user) when logged as an admin The corresponding list in the webadmin shows all roles (since the logged user is an admin). The roles are filtered on business layer. Change-Id: Iad85c4a242e196c7fa3a0fef4d18bdf96a36bbd2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1273025 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRolesQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRolesQueryTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDaoTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M packaging/dbscripts/multi_level_administration_sp.sql 9 files changed, 58 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad85c4a242e196c7fa3a0fef4d18bdf96a36bbd2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0