- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix adding Cinder snapshot after commiting previewed s...
by mlipchuk＠redhat.com 03 Nov '15

03 Nov '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix adding Cinder snapshot after commiting previewed snapshot. ...................................................................... core: Fix adding Cinder snapshot after commiting previewed snapshot. Fix the scenario when commiting a Cinder snapshot and after that adding a new Cinder snapshot. The problem is that the volume that is being updated is the basic one instead of the new active volume which has just been commited Change-Id: I9fa2e1f138bd68b0f09d7892c4ab5490f004942f Bug-Url: https://bugzilla.redhat.com/1277469 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa2e1f138bd68b0f09d7892c4ab5490f004942f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Windows 10 requires special CPU
by tnisan＠redhat.com 03 Nov '15

03 Nov '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Windows 10 requires special CPU ...................................................................... core: Windows 10 requires special CPU Because of BSOD: SYSTEM_THREAD_EXCEPTION_NOT_HANDLES, running guest OS Windows 10 is limited westmere+ CPUs This patch makes RunVmCommand to respect 'cpu.unsupported' entries in osinfo-defaults.properties file. Change-Id: Iaa53264e12d8f80562987ea5bfa131e91d5737b2 Bug-Url: https://bugzilla.redhat.com/1275810 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandlerRule.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerRule.java M packaging/conf/osinfo-defaults.properties 6 files changed, 151 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa53264e12d8f80562987ea5bfa131e91d5737b2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in gerrit-admin[master]: Fix to the warn_if_not_merged_to_previous_branch
by dcaroest＠redhat.com 03 Nov '15

03 Nov '15

David Caro has submitted this change and it was merged. Change subject: Fix to the warn_if_not_merged_to_previous_branch ...................................................................... Fix to the warn_if_not_merged_to_previous_branch Change-Id: I58ce7a20844177ed8456c1e243e0f2ec4d94b7a8 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/patchset-created.warn_if_not_merged_to_previous_branch 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58ce7a20844177ed8456c1e243e0f2ec4d94b7a8 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in gerrit-admin[master]: Adapting to target_milestone
by dcaroest＠redhat.com 03 Nov '15

03 Nov '15

David Caro has submitted this change and it was merged. Change subject: Adapting to target_milestone ...................................................................... Adapting to target_milestone Due to latest changes in bugzilla, target release is not used anymore but target milestone is, the hook is essentially the same but using a different field, needs some config changes in the gerrit machine * Created the helper function tools.match * Created the bz.check_target_milestone * Created the bz.get_target_milestone * Created patchset-created.bz.3.correct_target_milestone hook script Change-Id: Iac1aeab9dfcc3513b6e1edd0e20d4d50100031ed Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A hooks/custom_hooks/patchset-created.bz.3.correct_target_milestone M hooks/custom_hooks/patchset-created.bz.3.correct_target_release M hooks/lib/bz.py M hooks/lib/bz.sh M hooks/lib/tools.sh 5 files changed, 240 insertions(+), 9 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac1aeab9dfcc3513b6e1edd0e20d4d50100031ed Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>

1 0

Change in jenkins[master]: Starting anew the system tests
by dcaroest＠redhat.com 03 Nov '15

03 Nov '15

David Caro has submitted this change and it was merged. Change subject: Starting anew the system tests ...................................................................... Starting anew the system tests For now, only a timed triggered job on released 3.5 repo, running once a day Change-Id: I1cdaeaf47df95e815d84aad989b8c8f39e211567 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/shell-scripts/system_tests.cleanup.sh M jobs/confs/shell-scripts/system_tests.collect_logs.sh A jobs/confs/shell-scripts/system_tests.sh D jobs/confs/shell-scripts/system_tests_common_std.sh M jobs/confs/yaml/builders/system_tests_builders.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 7 files changed, 102 insertions(+), 230 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/47882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cdaeaf47df95e815d84aad989b8c8f39e211567 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: default volume format selection in new template wi...
by derez＠redhat.com 03 Nov '15

03 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: frontend: default volume format selection in new template window ...................................................................... frontend: default volume format selection in new template window When making a template from a vm via the ui, one can choose the volume format of each template disk (92665e0af829d25273d5d45669847569eae6f5cc). Before this feature, the format of each disk was the same as its base snapshot, but now it's set to QCOW2 by default. This patch restores the old behavior such that the format is chosen to be the same as the base snapshot's format by default. Change-Id: I364a8f23f75b583c1f5b24051d374f32fa53a39d Bug-Url: https://bugzilla.redhat.com/1257240 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M packaging/dbscripts/disk_images_sp.sql 9 files changed, 190 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I364a8f23f75b583c1f5b24051d374f32fa53a39d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: add a parameterized constructor to IdsQueryParameters
by derez＠redhat.com 03 Nov '15

03 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: backend: add a parameterized constructor to IdsQueryParameters ...................................................................... backend: add a parameterized constructor to IdsQueryParameters Change-Id: I47d09f6576ec995607c70268a67baa6655d3e450 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdsQueryParameters.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/47928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47d09f6576ec995607c70268a67baa6655d3e450 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: fix naming and spacing in IdsQueryParameters
by derez＠redhat.com 03 Nov '15

03 Nov '15

Daniel Erez has submitted this change and it was merged. Change subject: backend: fix naming and spacing in IdsQueryParameters ...................................................................... backend: fix naming and spacing in IdsQueryParameters Change-Id: I7e99e4c5d3ef1db7ff80416acf5ed4b5035c7b93 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdsQueryParameters.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/47927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e99e4c5d3ef1db7ff80416acf5ed4b5035c7b93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : Importing an image from glance never finishes
by masayag＠redhat.com 02 Nov '15

02 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: engine : Importing an image from glance never finishes ...................................................................... engine : Importing an image from glance never finishes Importing an image from glance leaves the disk locked after image has been downloaded Change-Id: I43fa65de4443ad234a23ac493e9f1e49c355b71a Bug-Url: https://bugzilla.redhat.com/1275629 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43fa65de4443ad234a23ac493e9f1e49c355b71a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.2.1
by sbonazzo＠redhat.com 02 Nov '15

02 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.3.2.1 ...................................................................... build: ovirt-hosted-engine-ha-1.3.2.1 Change-Id: Ie6edda12bc179a794167be83e0d3524da418d0f6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6edda12bc179a794167be83e0d3524da418d0f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0