- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Improve the custom findbugs Maven plugin
by juan.hernandez＠redhat.com 01 Oct '15

01 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Improve the custom findbugs Maven plugin ...................................................................... core: Improve the custom findbugs Maven plugin This patch improves the custom findbugs Maven plugin, renaming it to use the usual Maven naming convention for plugins. Change-Id: I189f1552af77c49592356b53b82d1818aa3b53a4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M build-tools-root/ovirt-findbugs-maven-plugin/pom.xml R build-tools-root/ovirt-findbugs-maven-plugin/src/main/java/org/ovirt/maven/plugins/findbugs/FindbugsMojo.java A build-tools-root/ovirt-findbugs-maven-plugin/src/main/resources/exclude-filters-general.xml M findbugs.sh 4 files changed, 92 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189f1552af77c49592356b53b82d1818aa3b53a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-artwork-1.0.0
by sbonazzo＠redhat.com 01 Oct '15

01 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-artwork-1.0.0 ...................................................................... build: ovirt-live-artwork-1.0.0 Change-Id: I1dc649a26b7cfa128345b7df2ce65d2ad0ac13d9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-live-artwork/configure.ac M ovirt-live-artwork/ovirt-live-artwork.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dc649a26b7cfa128345b7df2ce65d2ad0ac13d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: using versionlock for ovirt-engine-wildfly
by sbonazzo＠redhat.com 01 Oct '15

01 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: using versionlock for ovirt-engine-wildfly ...................................................................... packaging: setup: using versionlock for ovirt-engine-wildfly Using versionlock to prevent unwanted updates of ovirt-engine-wildfly rpms. Fixing the behaviour of tolist helper function on empty strings. Change-Id: I2b56d985c2c8bb6eda34508397ce271519fd7f2b Bug-Url: https://bugzilla.redhat.com/1264435 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/bin/ovirt-engine-upgrade-check M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py 6 files changed, 60 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b56d985c2c8bb6eda34508397ce271519fd7f2b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use version 1.1 of the WildFly datasources schema
by juan.hernandez＠redhat.com 01 Oct '15

01 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use version 1.1 of the WildFly datasources schema ...................................................................... core: Use version 1.1 of the WildFly datasources schema We currently use version 1.0, which isn't supported by WildFly 10. Version 1.1 works with WildFly 8, JBoss EAP 6 and WildFly 10. Change-Id: I058ba067ae3576a84076104fd6e1457c731f79a0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I058ba067ae3576a84076104fd6e1457c731f79a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in gerrit-admin[master]: patchset-created.bz.2.correct_product: add oVirt classification
by dcaroest＠redhat.com 01 Oct '15

01 Oct '15

David Caro has submitted this change and it was merged. Change subject: patchset-created.bz.2.correct_product: add oVirt classification ...................................................................... patchset-created.bz.2.correct_product: add oVirt classification Add oVirt classification to correct products, keeping it backwards compatible Change-Id: I31024bae713353cde2b57058481c6ced3f749600 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/custom_hooks/patchset-created.bz.2.correct_product M hooks/lib/bz.sh 2 files changed, 34 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31024bae713353cde2b57058481c6ced3f749600 Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in jenkins[master]: Changing the amount of node archives to store
by dcaroest＠redhat.com 01 Oct '15

01 Oct '15

David Caro has submitted this change and it was merged. Change subject: Changing the amount of node archives to store ...................................................................... Changing the amount of node archives to store Change-Id: Id4021eb6bdaf48dec9b724433de86c0814ac4cec Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/46841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4021eb6bdaf48dec9b724433de86c0814ac4cec Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Test config key after checking null
by juan.hernandez＠redhat.com 01 Oct '15

01 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Test config key after checking null ...................................................................... tools: Test config key after checking null This is needed in order to avoid the following findbugs error: Nullcheck of value previously dereferenced A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous. Bug kind and pattern: RCN - RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE Change-Id: I9292e64e0b995320a2d7edf6db465192c2664012 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9292e64e0b995320a2d7edf6db465192c2664012 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Limiting ovirt-engine archived builds
by dcaroest＠redhat.com 01 Oct '15

01 Oct '15

David Caro has submitted this change and it was merged. Change subject: Limiting ovirt-engine archived builds ...................................................................... Limiting ovirt-engine archived builds Setting it to half of what it had before Change-Id: I7ebec90c298d9533a17bd882fa7573b3e91fdf54 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml M jobs/confs/yaml/templates/standard-stage.yaml 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/46893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebec90c298d9533a17bd882fa7573b3e91fdf54 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-appliance: Limit to keep 2 builds
by sbonazzo＠redhat.com 01 Oct '15

01 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-appliance: Limit to keep 2 builds ...................................................................... ovirt-appliance: Limit to keep 2 builds Change-Id: I00ebb80a44e36ded0411ca9f0bcbedf4f0ca7194 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml M jobs/confs/yaml/templates/standard-stage.yaml 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/46876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00ebb80a44e36ded0411ca9f0bcbedf4f0ca7194 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: Not archiving the rpm for check* stages
by sbonazzo＠redhat.com 01 Oct '15

01 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Not archiving the rpm for check* stages ...................................................................... Not archiving the rpm for check* stages We already have the build-artifacts stage that is being archived and published, archiving the check-patch and check-merged take too much space on the ci system Change-Id: Ia7a36a46f1a43e4c80fa4390ff0fc8c4fe20f906 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M automation/check-merged.sh M automation/check-patch.sh 2 files changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified -- To view, visit https://gerrit.ovirt.org/46887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a36a46f1a43e4c80fa4390ff0fc8c4fe20f906 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0